[Lldb-commits] [lldb] 728101f - Reland "[LLDB] Fix the use of "platform process launch" with no extra arguments"

Author: David Spickett Date: 2023-06-29T08:21:42Z New Revision: 728101f97286c1665814e74686c083a4d5ff208c URL: https://github.com/llvm/llvm-project/commit/728101f97286c1665814e74686c083a4d5ff208c DIFF: https://github.com/llvm/llvm-project/commit/728101f97286c1665814e74686c083a4d5ff208c.diff LOG

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

DavidSpickett added a comment. Relanded as https://github.com/llvm/llvm-project/commit/728101f97286c1665814e74686c083a4d5ff208c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153636/new/ https://reviews.llvm.org/D153636 __

[Lldb-commits] [PATCH] D153513: [lldb] Check that qLaunchGDBServer packet does not return an error

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153513/new/ https://reviews.llvm.org/D153513 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

azhan92 marked 3 inline comments as done. azhan92 added a comment. @hubert.reinterpretcast I have the call stack on AIX: #0 0x0904304c in read () from /usr/lib/libc.a(shr_64.o) #1 0x000100d5f044 in llvm::sys::RetryAfterSignal(int const&, long ( const&)(int, void*, unsigned long

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ivanhernandez13 added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.h:251-252 /// \return - /// A \a PacketStatus object indicating the sucess or failure of the - /// request. - PacketStatus SendReverseRequest(llvm::json::Object request, -

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti updated this revision to Diff 535864. ashgti added a comment. Fixing stale comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153447/new/ https://reviews.llvm.org/D153447 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vs

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 535911. ashgti added a comment. Adding ` as an escape hatch in auto mode to ensure lldb commands can always be run directly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

kastiglione created this revision. kastiglione added reviewers: jingham, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `formatter` logs include a function name, but these functions

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

augusto2112 accepted this revision. augusto2112 added a comment. This revision is now accepted and ready to land. I've bumped into this problem before, so really like this change. It's a bit sad that you'll only print the kind of data formatter once though, so someone reading the logs might have

[Lldb-commits] [lldb] 227b218 - Creating a startDebugging reverse DAP request handler in lldb-vscode.

Author: John Harrison Date: 2023-06-29T14:45:57-04:00 New Revision: 227b2180eb2be94986d63c75c144f88be13fc52f URL: https://github.com/llvm/llvm-project/commit/227b2180eb2be94986d63c75c144f88be13fc52f DIFF: https://github.com/llvm/llvm-project/commit/227b2180eb2be94986d63c75c144f88be13fc52f.diff

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

This revision was automatically updated to reflect the committed changes. Closed by commit rG227b2180eb2b: Creating a startDebugging reverse DAP request handler in lldb-vscode. (authored by ashgti, committed by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D154028: [lldb-vscode] Prior to running the launchCommands during a launch request set the launch info so the configured launch information is accessible by the launch commands.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc52f8dc6ce2: [lldb-vscode] Prior to running the launchCommands during a launch request set… (authored by ashgti, committed by dgoldman). Changed prior to commit: https://reviews.llvm.org/D154028?vs=53

[Lldb-commits] [lldb] fc52f8d - [lldb-vscode] Prior to running the launchCommands during a launch request set the launch info so the configured launch information is accessible by the launch commands.

Author: John Harrison Date: 2023-06-29T14:50:19-04:00 New Revision: fc52f8dc6ce2ddd19b7b0f5ffdc9598c3abe105f URL: https://github.com/llvm/llvm-project/commit/fc52f8dc6ce2ddd19b7b0f5ffdc9598c3abe105f DIFF: https://github.com/llvm/llvm-project/commit/fc52f8dc6ce2ddd19b7b0f5ffdc9598c3abe105f.diff

[Lldb-commits] [lldb] b9b0ab3 - [lldb-vscode] Adjusting CreateSource to detect compiler generated frames.

Author: John Harrison Date: 2023-06-29T15:31:08-04:00 New Revision: b9b0ab32f9d0a40ee225b2dc71bdf2f66b7127e8 URL: https://github.com/llvm/llvm-project/commit/b9b0ab32f9d0a40ee225b2dc71bdf2f66b7127e8 DIFF: https://github.com/llvm/llvm-project/commit/b9b0ab32f9d0a40ee225b2dc71bdf2f66b7127e8.diff

[Lldb-commits] [PATCH] D154026: [lldb-vscode] Adjusting CreateSource to detect compiler generated frames.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9b0ab32f9d0: [lldb-vscode] Adjusting CreateSource to detect compiler generated frames. (authored by ashgti, committed by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

kastiglione added a comment. I just test gave `__PRETTY_FUNCTION__` a test drive, and it's a bit verbose/noisy: For example: [ImplSP lldb_private::FormatManager::Get(lldb_private::ValueObject &, lldb::DynamicValueType) [ImplSP = std::shared_ptr]] Begin synthetic lookup. Here's an example of

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

augusto2112 added a comment. Personally I vote for the formatter kind on every line, so we don't need to jump around the logs when reading them, up to you though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154128/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D153513: [lldb] Check that qLaunchGDBServer packet does not return an error

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ah, sorry for not getting back to this one! Nice job coming up with a test. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 536031. ashgti added a comment. Pull + Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 Files: lldb/tools/lldb-vscode/JSONUtils.cpp lldb/tools/lldb-vscode/J

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti added a reviewer: wallace. ashgti added a comment. Hi wallace, I created to improve the repl behavior of lldb-vscode allowing users to more easily run lldb commands. I started https://discourse.llvm.org/t/rfc-lldb-vscode-evaluate-repl-behavior-and-improvements/71667 as well to outline s

[Lldb-commits] [PATCH] D154169: add a target dump section-load-list command for inspecting the Target's SectionLoadList

jasonmolenda created this revision. jasonmolenda added a reviewer: mib. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. When debugging possible issues

[Lldb-commits] [PATCH] D154169: add a target dump section-load-list command for inspecting the Target's SectionLoadList

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. That's indeed very helpful! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154169/new/ https://reviews.llvm.org/D154169

[Lldb-commits] [PATCH] D154169: add a target dump section-load-list command for inspecting the Target's SectionLoadList

mib added inline comments. Comment at: lldb/source/Target/SectionLoadList.cpp:265-266 ++pos) { -s.Printf("addr = 0x%16.16" PRIx64 ", section = %p: ", pos->first, - static_cast(pos->second.get())); pos->second->Dump(s.AsRawOstream(), s.GetIndentLevel()

[Lldb-commits] [PATCH] D154169: add a target dump section-load-list command for inspecting the Target's SectionLoadList

jasonmolenda added inline comments. Comment at: lldb/source/Target/SectionLoadList.cpp:265-266 ++pos) { -s.Printf("addr = 0x%16.16" PRIx64 ", section = %p: ", pos->first, - static_cast(pos->second.get())); pos->second->Dump(s.AsRawOstream(), s.GetInde

[Lldb-commits] [lldb] ad45114 - Add 'target dump section-load-list' for lldb debugging

Author: Jason Molenda Date: 2023-06-29T17:02:54-07:00 New Revision: ad451146e8f59de76e393094d3aafc97a854c40b URL: https://github.com/llvm/llvm-project/commit/ad451146e8f59de76e393094d3aafc97a854c40b DIFF: https://github.com/llvm/llvm-project/commit/ad451146e8f59de76e393094d3aafc97a854c40b.diff

[Lldb-commits] [PATCH] D154169: add a target dump section-load-list command for inspecting the Target's SectionLoadList

This revision was automatically updated to reflect the committed changes. Closed by commit rGad451146e8f5: Add 'target dump section-load-list' for lldb debugging (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D154169?vs=536049&id=536057#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D154037: Recognize BSS-only DATA segments as sections that need to be slid/loaded at addresses

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154037/new/ https://reviews.llvm.org/D154037 ___

[Lldb-commits] [lldb] 623e845 - Recognize BSS-only DATA segments as sections that need to be slid

Author: Jason Molenda Date: 2023-06-29T17:51:41-07:00 New Revision: 623e8455919af69b039fe7450118ba953423a027 URL: https://github.com/llvm/llvm-project/commit/623e8455919af69b039fe7450118ba953423a027 DIFF: https://github.com/llvm/llvm-project/commit/623e8455919af69b039fe7450118ba953423a027.diff

[Lldb-commits] [PATCH] D154037: Recognize BSS-only DATA segments as sections that need to be slid/loaded at addresses

This revision was automatically updated to reflect the committed changes. Closed by commit rG623e8455919a: Recognize BSS-only DATA segments as sections that need to be slid (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154

[Lldb-commits] [lldb] 37d11e9 - "fp" -> "flags" typeo in description of generic registers

Author: Jason Molenda Date: 2023-06-29T18:22:58-07:00 New Revision: 37d11e94a4eb5452158f0ae73ed7752136e41439 URL: https://github.com/llvm/llvm-project/commit/37d11e94a4eb5452158f0ae73ed7752136e41439 DIFF: https://github.com/llvm/llvm-project/commit/37d11e94a4eb5452158f0ae73ed7752136e41439.diff