[Lldb-commits] [lldb] 28722dc - Summary: [lldb] Fix libncurses, libpanel library link order

Author: Hau Hsu Date: 2023-06-28T15:00:22+08:00 New Revision: 28722dcc2556b9cea5c7d9a4dd8343ac68e696ef URL: https://github.com/llvm/llvm-project/commit/28722dcc2556b9cea5c7d9a4dd8343ac68e696ef DIFF: https://github.com/llvm/llvm-project/commit/28722dcc2556b9cea5c7d9a4dd8343ac68e696ef.diff LOG:

[Lldb-commits] [PATCH] D153844: Summary: [lldb] Fix libncurses, libpanel library link order

This revision was automatically updated to reflect the committed changes. Closed by commit rG28722dcc2556: Summary: [lldb] Fix libncurses, libpanel library link order (authored by hauhsu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153844/new/ ht

[Lldb-commits] [PATCH] D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch

DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:1232 + +assert(launch_info.GetHijackListener()); + This assert fails on Linux. Is it necessary or should I look into why it's null here on Linux? WaitForProc

[Lldb-commits] [PATCH] D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch

DavidSpickett added a comment. Thanks for testing and fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153922/new/ https://reviews.llvm.org/D153922 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch

DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:1232 + +assert(launch_info.GetHijackListener()); + DavidSpickett wrote: > This assert fails on Linux. Is it necessary or should I look into why it's > null he

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/platform/process/launch/TestPlatformProcessLaunch.py:50 +self.runCmd("settings set target.run-args D E") +self.runCmd("platform process launch --stdout {}".format(outfile)) +self.runC

[Lldb-commits] [lldb] 4d5c9ad - [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

Author: Felipe de Azevedo Piovezan Date: 2023-06-28T08:31:02-04:00 New Revision: 4d5c9ad9c3d7ed84efa1307ec158829b95badc6f URL: https://github.com/llvm/llvm-project/commit/4d5c9ad9c3d7ed84efa1307ec158829b95badc6f DIFF: https://github.com/llvm/llvm-project/commit/4d5c9ad9c3d7ed84efa1307ec158829b9

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d5c9ad9c3d7: [lldb] Use LLVM's implementation of AppleTables for apple_{names,namespaces} (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] e12c701 - [lldb] Use LLVM's implementation of AppleTables for apple_debug_types

Author: Felipe de Azevedo Piovezan Date: 2023-06-28T09:19:14-04:00 New Revision: e12c701ff0405880045f0330fb6ff94e31ec5c47 URL: https://github.com/llvm/llvm-project/commit/e12c701ff0405880045f0330fb6ff94e31ec5c47 DIFF: https://github.com/llvm/llvm-project/commit/e12c701ff0405880045f0330fb6ff94e3

[Lldb-commits] [PATCH] D153867: [lldb] Use LLVM's implementation of AppleTables for apple_debug_types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe12c701ff040: [lldb] Use LLVM's implementation of AppleTables for apple_debug_types (authored by fdeazeve). Repository: rG LLVM Github Monorepo C

[Lldb-commits] [lldb] 8e71d14 - [lldb] Use LLVM's implementation of AppleTables for apple_objc

Author: Felipe de Azevedo Piovezan Date: 2023-06-28T10:05:36-04:00 New Revision: 8e71d14972b48df8c5b701a9aec19af3194f9a5e URL: https://github.com/llvm/llvm-project/commit/8e71d14972b48df8c5b701a9aec19af3194f9a5e DIFF: https://github.com/llvm/llvm-project/commit/8e71d14972b48df8c5b701a9aec19af31

[Lldb-commits] [PATCH] D153868: [lldb] Use LLVM's implementation of AppleTables for apple_objc

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e71d14972b4: [lldb] Use LLVM's implementation of AppleTables for apple_objc (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153868/new

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

azhan92 updated this revision to Diff 535389. azhan92 added a comment. Herald added subscribers: JDevlieghere, jdoerfert. Remove unrelated changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Files:

[Lldb-commits] [PATCH] D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC)

kastiglione abandoned this revision. kastiglione added a comment. Herald added a subscriber: Michael137. Herald added a project: All. This was superseded by D145276 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:81-83 +<< "note: object description requested, but type doesn't implement " + "a custom object description. Consider using \"p\" instead of " + "\"po\"\n"; -

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

kastiglione added a comment. > I wonder if we should hint in all 3 command objects (expr, frame var and > DWIM) or if we should limit this to DWIM instead (since DWIM is the one > aliased to p and po and I don't think vo or expr -O are often used > unintentionally). I missed this comment. My i

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.h:46-51 + /// Add a hint if object description was requested, but no description + /// function was implemented, and dump valobj to output_stream after. + static void MaybeAddPoHintAndDu

[Lldb-commits] [lldb] ee47699 - [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.

Author: Caroline Tice Date: 2023-06-28T11:46:55-07:00 New Revision: ee476996bec7f170928505a4c5b7715183cfbada URL: https://github.com/llvm/llvm-project/commit/ee476996bec7f170928505a4c5b7715183cfbada DIFF: https://github.com/llvm/llvm-project/commit/ee476996bec7f170928505a4c5b7715183cfbada.diff

[Lldb-commits] [PATCH] D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.

This revision was automatically updated to reflect the committed changes. Closed by commit rGee476996bec7: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate. (authored by cmtice). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit: https

[Lldb-commits] [PATCH] D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.

cmtice added a comment. Herald added subscribers: Michael137, JDevlieghere. I updated the version that I committed to use 'sizeof' as recommended. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153840/new/ https://reviews.llvm.org/D153840 _

[Lldb-commits] [PATCH] D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.

dblaikie added a comment. I'm not sure if this is the right fix - these reads are for implementing DW_OP_deref_size, by the looks of it - so I think it does make sense that the size read is not the size of the address, but the size specified in the DW_OP_deref_size. There is a requirement that

[Lldb-commits] [PATCH] D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:1232 + +assert(launch_info.GetHijackListener()); + DavidSpickett wrote: > DavidSpickett wrote: > > This assert fails on Linux. Is it necessary or should I look i

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 updated this revision to Diff 535561. augusto2112 marked 5 inline comments as done. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153489/new/ https://reviews.llvm.org/D153489 Files: lld

[Lldb-commits] [PATCH] D154025: [lldb-vscode] Prior to running the launchCommands during a launch request set the launch info so the configured launch information is accessible by the launch commands.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. [lldb-vscode] Adding support for column break points. [lldb-vscode] Creating a new flag for adjusting the behavior of evaluat

[Lldb-commits] [PATCH] D154026: [lldb-vscode] Adjusting CreateSource to detect compiler generated frames.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154026 Files: lldb/tools/lldb-vscode/JSONUtils.cpp Index

[Lldb-commits] [PATCH] D154028: [lldb-vscode] Prior to running the launchCommands during a launch request set the launch info so the configured launch information is accessible by the launch commands.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154028 Files: lldb/tools/lldb-vscode/README.md lldb/tool

[Lldb-commits] [PATCH] D154029: [lldb-vscode] Adding support for column break points.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154029 Files: lldb/tools/lldb-vscode/JSONUtils.cpp lldb/

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a new flag and lldb runtime command to allow users to manage the behavior of the lldb-vscode evaluate repl request.

[Lldb-commits] [PATCH] D154026: [lldb-vscode] Adjusting CreateSource to detect compiler generated frames.

ashgti added reviewers: ivanhernandez13, wallace. ashgti added a comment. A small fix for displaying compiler-generated frames. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154026/new/ https://reviews.llvm.org/D154026

[Lldb-commits] [PATCH] D154028: [lldb-vscode] Prior to running the launchCommands during a launch request set the launch info so the configured launch information is accessible by the launch commands.

ashgti added a reviewer: wallace. ashgti added a comment. A small improvement to allow launchCommands to access the configured launch info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154028/new/ https://reviews.llvm.org/D154028 ___

[Lldb-commits] [PATCH] D154029: [lldb-vscode] Adding support for column break points.

ashgti added reviewers: wallace, ivanhernandez13. ashgti added a comment. Adding column information to breakpoints, including the ability to set column inline breakpoints from VS Code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154029/new/ http

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 535580. ashgti added a comment. Small tweak to the auto expression mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 Files: lldb/tools/lldb-vscode/JSONUtils.cpp

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 535590. ashgti added a comment. Another tweak to the auto mode behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 Files: lldb/tools/lldb-vscode/JSONUtils.cpp

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 535591. ashgti added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 Files: lldb/tools/lldb-vscode/JSONUtils.cpp lldb/tools/lldb-vscode/JSON

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 535592. ashgti added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 Files: lldb/tools/lldb-vscode/JSONUtils.cpp lldb/tools/lldb-vscode/JSONU

[Lldb-commits] [PATCH] D154026: [lldb-vscode] Adjusting CreateSource to detect compiler generated frames.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. pretty nice. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154026/new/ https://reviews.llvm.org/D154026 _

[Lldb-commits] [PATCH] D154028: [lldb-vscode] Prior to running the launchCommands during a launch request set the launch info so the configured launch information is accessible by the launch commands.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. THANKS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154028/new/ https://reviews.llvm.org/D154028 ___

[Lldb-commits] [PATCH] D154037: Recognize BSS-only DATA segments as sections that need to be slid/loaded at addresses

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. ObjectFileMachO::SetLoadAddress() takes a slide or base load ad

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

hubert.reinterpretcast added a comment. @azhan92, please incorporate a revert of https://reviews.llvm.org/rG64ca650cf9f180cc0b68c0005639028084066e10. Since it is an `XFAIL`. once the problem is fixed, the test will end up being an "unexpected success" unless we remove the `XFAIL`. Repository:

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

hubert.reinterpretcast added a comment. @azhan92, rG6ace52e5e49cff6664fc301fa4985fc28c88f26f and rGc14df228ff3ca73e3c5c00c495216bba56665fd5 should also be

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

hubert.reinterpretcast added a comment. In D151567#4458232 , @hubert.reinterpretcast wrote: > @azhan92, please incorporate a revert of > https://reviews.llvm.org/rG64ca650cf9f180cc0b68c0005639028084066e10. Since it > is an `XFAIL`. once the problem is