[Lldb-commits] [lldb] 898b880 - [LLDB] Update AArch64/Windows XFAIl decorators on TestNamespace.py

Author: Muhammad Omair Javaid Date: 2023-05-30T13:06:09+04:00 New Revision: 898b880308f1ce31520c939ab19366dc3b82c930 URL: https://github.com/llvm/llvm-project/commit/898b880308f1ce31520c939ab19366dc3b82c930 DIFF: https://github.com/llvm/llvm-project/commit/898b880308f1ce31520c939ab19366dc3b82c9

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

tbaeder updated this revision to Diff 526557. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150772/new/ https://reviews.llvm.org/D150772 Files: lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py Index: lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

erichkeane added a comment. What is the justification for this? Do other compilers do this? Was there an RFC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://reviews.llvm.org/D151683 ___

[Lldb-commits] [PATCH] D151603: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix

Michael137 added a comment. modulo Felipe's comment, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151603/new/ https://reviews.llvm.org/D151603 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

aprantl added a comment. If we can come up with a counterexample where the heuristic in this patch is doing the wrong thin then I think emitting a DW_AT_LLVM_no_unique_address attribute sounds reasonable to me. But otherwise I don't see a problem with using a heuristic. Repository: rG LLVM

[Lldb-commits] [PATCH] D151603: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:1001 -bool ObjCLanguage::GetFormatterPrefixSuffix(ValueObject &valobj, -ConstString type_hint, -

[Lldb-commits] [PATCH] D151603: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix

bulbazord updated this revision to Diff 526705. bulbazord added a comment. Remove use of `std::call_once` where not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151603/new/ https://reviews.llvm.org/D151603 Files: lldb/include/lldb/Targe

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150772/new/ https://reviews.llvm.org/D150772 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D151603: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151603/new/ https://reviews.llvm.org/D151603 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D151599: [lldb][NFCI] Remove use of ConstString from StructuredDataDarwinLog static functions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp:1496-1500 LLDB_LOGF(log, "StructuredDataDarwinLog::

[Lldb-commits] [lldb] 8e0001e - [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix

Author: Alex Langford Date: 2023-05-30T13:11:55-07:00 New Revision: 8e0001eb95ce8654660510ddb06f5a8a3c5c6d68 URL: https://github.com/llvm/llvm-project/commit/8e0001eb95ce8654660510ddb06f5a8a3c5c6d68 DIFF: https://github.com/llvm/llvm-project/commit/8e0001eb95ce8654660510ddb06f5a8a3c5c6d68.diff

[Lldb-commits] [PATCH] D151603: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e0001eb95ce: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151603/new/ ht

[Lldb-commits] [PATCH] D151748: [lldb] Consult summary provider before printing children of root references

kastiglione created this revision. kastiglione added reviewers: jingham, bulbazord, aprantl, Michael137. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When printing the root of a value, if it's a r

[Lldb-commits] [lldb] f46638b - [lldb][NFCI] Change type of SBDebugger::m_instance_name

Author: Alex Langford Date: 2023-05-30T13:21:56-07:00 New Revision: f46638b01d1bd66aa879188132e0d19a0a7f5928 URL: https://github.com/llvm/llvm-project/commit/f46638b01d1bd66aa879188132e0d19a0a7f5928 DIFF: https://github.com/llvm/llvm-project/commit/f46638b01d1bd66aa879188132e0d19a0a7f5928.diff

[Lldb-commits] [PATCH] D151524: [lldb][NFCI] Change type of SBDebugger::m_instance_name

This revision was automatically updated to reflect the committed changes. Closed by commit rGf46638b01d1b: [lldb][NFCI] Change type of SBDebugger::m_instance_name (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151524/new/ htt

[Lldb-commits] [PATCH] D151599: [lldb][NFCI] Remove use of ConstString from StructuredDataDarwinLog static functions

bulbazord updated this revision to Diff 526768. bulbazord added a comment. LLDB_LOGF -> LLDB_LOG to avoid a temporary string construction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151599/new/ https://reviews.llvm.org/D151599 Files: lldb/sou

[Lldb-commits] [lldb] 9e8a412 - [lldb][NFCI] Remove use of ConstString from StructuredDataDarwinLog static functions

Author: Alex Langford Date: 2023-05-30T13:47:09-07:00 New Revision: 9e8a412cb37d2a1201bd33878fce0993587ef335 URL: https://github.com/llvm/llvm-project/commit/9e8a412cb37d2a1201bd33878fce0993587ef335 DIFF: https://github.com/llvm/llvm-project/commit/9e8a412cb37d2a1201bd33878fce0993587ef335.diff

[Lldb-commits] [PATCH] D151599: [lldb][NFCI] Remove use of ConstString from StructuredDataDarwinLog static functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e8a412cb37d: [lldb][NFCI] Remove use of ConstString from StructuredDataDarwinLog static… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] e348dbc - [lldb] Fix build after Clang API change

Author: Jan Svoboda Date: 2023-05-30T14:08:04-07:00 New Revision: e348dbc4b2766f17c251b6c305a3b34fbdb9be96 URL: https://github.com/llvm/llvm-project/commit/e348dbc4b2766f17c251b6c305a3b34fbdb9be96 DIFF: https://github.com/llvm/llvm-project/commit/e348dbc4b2766f17c251b6c305a3b34fbdb9be96.diff L

[Lldb-commits] [PATCH] D151748: [lldb] Consult summary provider before printing children of root references

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. makes sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151748/new/ https://reviews.llvm.org/D151748

[Lldb-commits] [PATCH] D151748: [lldb] Consult summary provider before printing children of root references

bulbazord accepted this revision. bulbazord added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151748/new/ https://reviews.llvm.org/D151748 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D150928: Two bug fixes for loading process save-core created core files, plus perf improvements

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Looks like my concerns were addressed. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150928/new/ https://reviews.llvm.org/D150928

[Lldb-commits] [PATCH] D151351: [lldb] Prevent dwim-print from showing kNoResult error

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:1 //===-- CommandObjectDWIMPrint.cpp --*- C++ -*-===// // ni

[Lldb-commits] [lldb] a79b0f9 - [lldb] Fix build after Clang API change at rev 769d282d7292

Author: Jorge Gorbe Moya Date: 2023-05-30T14:21:21-07:00 New Revision: a79b0f9f1d8275b023bcd2bf1763b148d088ad97 URL: https://github.com/llvm/llvm-project/commit/a79b0f9f1d8275b023bcd2bf1763b148d088ad97 DIFF: https://github.com/llvm/llvm-project/commit/a79b0f9f1d8275b023bcd2bf1763b148d088ad97.di

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added a comment. In D151683#4380877 , @erichkeane wrote: > What is the justification for this? What exactly are you asking for? Why I'd like to back port it? This would make quite a bit of code in libc++ simpler and avoids pit-falls where an at

[Lldb-commits] [lldb] 57154a6 - [lldb] Introduce FileSpec::GetComponents

Author: Alex Langford Date: 2023-05-30T15:13:17-07:00 New Revision: 57154a63a07f732552968141136279350bcdf99d URL: https://github.com/llvm/llvm-project/commit/57154a63a07f732552968141136279350bcdf99d DIFF: https://github.com/llvm/llvm-project/commit/57154a63a07f732552968141136279350bcdf99d.diff

[Lldb-commits] [PATCH] D151399: [lldb] Introduce FileSpec::GetComponents

This revision was automatically updated to reflect the committed changes. Closed by commit rG57154a63a07f: [lldb] Introduce FileSpec::GetComponents (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151399/new/ https://reviews.ll

[Lldb-commits] [lldb] c7eb1b0 - [lldb] Consult summary provider before printing children of root references

Author: Dave Lee Date: 2023-05-30T15:35:03-07:00 New Revision: c7eb1b07470b9babfcd258f014df3661e5f84b30 URL: https://github.com/llvm/llvm-project/commit/c7eb1b07470b9babfcd258f014df3661e5f84b30 DIFF: https://github.com/llvm/llvm-project/commit/c7eb1b07470b9babfcd258f014df3661e5f84b30.diff LOG:

[Lldb-commits] [PATCH] D151748: [lldb] Consult summary provider before printing children of root references

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7eb1b07470b: [lldb] Consult summary provider before printing children of root references (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [lldb] 48a12ae - Fix a few bugs with Mach-O corefile loading, plus perf

Author: Jason Molenda Date: 2023-05-30T15:36:40-07:00 New Revision: 48a12ae8212c22d9d1d84270db659ac76ecfa972 URL: https://github.com/llvm/llvm-project/commit/48a12ae8212c22d9d1d84270db659ac76ecfa972 DIFF: https://github.com/llvm/llvm-project/commit/48a12ae8212c22d9d1d84270db659ac76ecfa972.diff

[Lldb-commits] [PATCH] D150928: Two bug fixes for loading process save-core created core files, plus perf improvements

This revision was automatically updated to reflect the committed changes. Closed by commit rG48a12ae8212c: Fix a few bugs with Mach-O corefile loading, plus perf (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150928/new/ h

[Lldb-commits] [lldb] 061a839 - [lldb] Prevent dwim-print from showing kNoResult error

Author: Dave Lee Date: 2023-05-30T15:38:42-07:00 New Revision: 061a839033dc5f11c4e43fb64ed49cc85e1e5f32 URL: https://github.com/llvm/llvm-project/commit/061a839033dc5f11c4e43fb64ed49cc85e1e5f32 DIFF: https://github.com/llvm/llvm-project/commit/061a839033dc5f11c4e43fb64ed49cc85e1e5f32.diff LOG:

[Lldb-commits] [PATCH] D151351: [lldb] Prevent dwim-print from showing kNoResult error

This revision was automatically updated to reflect the committed changes. Closed by commit rG061a839033dc: [lldb] Prevent dwim-print from showing kNoResult error (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151351/new/ ht

[Lldb-commits] [PATCH] D151762: [lldb] Remove __FUNCTION__ from log messages in lldbHost (NFC)

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: All. JDevlieghere requested review of this revision. LLDB's logging infrastructure supports prepending log messages with the name of the file and function that generates the log (see `help log enable`

[Lldb-commits] [PATCH] D151762: [lldb] Remove __FUNCTION__ from log messages in lldbHost (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. The change itself looks fine and is fairly mechanical. Easy to verify. One thing that I see here is we're treating the result of `llvm::StringRef::data()` as a c-string which isn't guara

[Lldb-commits] [PATCH] D151762: [lldb] Remove __FUNCTION__ from log messages in lldbHost (NFC)

mib accepted this revision as: mib. mib added a comment. LGTM! Are you considering doing it for the rest of the codebase as well ? That would be very nice :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151762/new/ https://reviews.llvm.org/D151762

[Lldb-commits] [PATCH] D151764: [lldb] Support file and function names in LLDB_LOGF macro

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: All. JDevlieghere requested review of this revision. LLDB's logging machinery supports prepending log messages with the name of the file and function that generates the log. However, currently this fu

[Lldb-commits] [PATCH] D151764: [lldb] Support file and function names in LLDB_LOGF macro

mib accepted this revision as: mib. mib added a comment. This revision is now accepted and ready to land. LGTM! Can we add a test for this ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151764/new/ https://reviews.llvm.org/D151764 ___ lldb-c

[Lldb-commits] [lldb] 1418677 - Fix SBValue::FindValue for file static variables

Author: Jim Ingham Date: 2023-05-30T17:12:35-07:00 New Revision: 14186773e79b8c6787afac2f9ee69738151377ec URL: https://github.com/llvm/llvm-project/commit/14186773e79b8c6787afac2f9ee69738151377ec DIFF: https://github.com/llvm/llvm-project/commit/14186773e79b8c6787afac2f9ee69738151377ec.diff LO

[Lldb-commits] [PATCH] D151392: Fix SBValue::FindValue for file static variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG14186773e79b: Fix SBValue::FindValue for file static variables (authored by jingham). Changed prior to commit: https://reviews.llvm.org/D151392?vs=525391&id=526852#toc Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D151764: [lldb] Support file and function names in LLDB_LOGF macro

JDevlieghere updated this revision to Diff 526853. JDevlieghere added a comment. Add unit test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151764/new/ https://reviews.llvm.org/D151764 Files: lldb/include/lldb/Utility/Log.h lldb/source/Utility/Log.cpp lldb/unittests/Utility/LogT

[Lldb-commits] [PATCH] D151762: [lldb] Remove __FUNCTION__ from log messages in lldbHost (NFC)

JDevlieghere added a comment. In D151762#4382679 , @mib wrote: > LGTM! Are you considering doing it for the rest of the codebase as well ? > That would be very nice :) Yup, that's the goal. I wanted to gather some initial feedback before I go through t

[Lldb-commits] [PATCH] D151762: [lldb] Remove __FUNCTION__ from log messages in lldbHost (NFC)

JDevlieghere updated this revision to Diff 526854. JDevlieghere added a comment. Use `LLDB_LOG` when `StringRef`s are involved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151762/new/ https://reviews.llvm.org/D151762 Files: lldb/source/Host/common/HostInfoBase.cpp lldb/source/Hos

[Lldb-commits] [lldb] be9b79f - [lldb] Remove commented out code/logging in BreakpointSiteList (NFC)

Author: Jonas Devlieghere Date: 2023-05-30T17:27:58-07:00 New Revision: be9b79fb14ce0776e147860c9fbffc84ea7b39e6 URL: https://github.com/llvm/llvm-project/commit/be9b79fb14ce0776e147860c9fbffc84ea7b39e6 DIFF: https://github.com/llvm/llvm-project/commit/be9b79fb14ce0776e147860c9fbffc84ea7b39e6.d

[Lldb-commits] [PATCH] D151765: [lldb] Introduce the FileSpecBuilder abstraction

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Mutating a FileSpec is quite expensive. E

[Lldb-commits] [lldb] f63155a - [clang] Show line numbers in diagnostic code snippets

Author: Timm Bäder Date: 2023-05-31T07:26:03+02:00 New Revision: f63155aaa6467bd2610820dfd1996af3bb6029a7 URL: https://github.com/llvm/llvm-project/commit/f63155aaa6467bd2610820dfd1996af3bb6029a7 DIFF: https://github.com/llvm/llvm-project/commit/f63155aaa6467bd2610820dfd1996af3bb6029a7.diff LO

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

tbaeder closed this revision. tbaeder added a comment. I merged the changes into the original line number commit and pushed them as https://github.com/llvm/llvm-project/commit/f63155aaa6467bd2610820dfd1996af3bb6029a7 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150772/new/ https://rev