[Lldb-commits] [PATCH] D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction()

Fznamznon updated this revision to Diff 509285. Fznamznon added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use private shared_ptr in `DumpModuleInfoAction` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/n

[Lldb-commits] [PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This looks much better to me, thank you! LGTM with one small nit for safety. Comment at: clang/include/clang/Frontend/FrontendActions.h:191 + DumpModuleInfoAct

[Lldb-commits] [PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Fznamznon updated this revision to Diff 509372. Fznamznon added a comment. Add a little bit of safety. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412 Files: clang/include/clang/Frontend/FrontendActions

[Lldb-commits] [PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

tahonermann added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:2182-2183 -clang::DumpModuleInfoAction dump_module_info; -dump_module_info.OutputStream = &result.GetOutputStream().AsRawOstream(); +std::shared_ptr Out( +&result.Get

[Lldb-commits] [PATCH] D147084: [lldb] Move ObjectFileJIT to lldbExpression

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Makes sense to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147084/new/ https://reviews.llvm.org/D147084 _

[Lldb-commits] [PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Fznamznon updated this revision to Diff 509420. Fznamznon added a comment. Add comment explaining custom deleter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412 Files: clang/include/clang/Frontend/Fron

[Lldb-commits] [PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Fznamznon added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:2182-2183 -clang::DumpModuleInfoAction dump_module_info; -dump_module_info.OutputStream = &result.GetOutputStream().AsRawOstream(); +std::shared_ptr Out( +&result.GetOu

[Lldb-commits] [PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

tahonermann accepted this revision. tahonermann added a comment. Thank you, Mariya! Looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412 ___ lldb-c

[Lldb-commits] [lldb] a7005d7 - [lldb] Unify target triples across compiler and linker invocations

Author: Jonas Devlieghere Date: 2023-03-29T14:58:19-07:00 New Revision: a7005d7813b392f6d1c749239089bbc5cd6e0c54 URL: https://github.com/llvm/llvm-project/commit/a7005d7813b392f6d1c749239089bbc5cd6e0c54 DIFF: https://github.com/llvm/llvm-project/commit/a7005d7813b392f6d1c749239089bbc5cd6e0c54.d