[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:3036 if (!std::is_trivially_destructible::value) { - auto DestroyPtr = [](void *V) { static_cast(V)->~T(); }; - AddDeallocation(DestroyPtr, Ptr); + auto DestroyPtr = [](void *V)

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

delcypher added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1316 +auto_generated_function.AppendString("def __user_code():"); +for (int i = 0; i < num_lines; ++i) { + sstr.Clear(); Why do

[Lldb-commits] [PATCH] D144904: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach.

rupprecht created this revision. rupprecht added reviewers: jingham, DavidSpickett, labath. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A common reason for LLDB failing to attach to an already-runn

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

bulbazord added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1316 +auto_generated_function.AppendString("def __user_code():"); +for (int i = 0; i < num_lines; ++i) { + sstr.Clear(); delcyp

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

jingham added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1316 +auto_generated_function.AppendString("def __user_code():"); +for (int i = 0; i < num_lines; ++i) { + sstr.Clear(); bulbazor

[Lldb-commits] [PATCH] D144929: Add SBCommandInterpreter::UserCommandExists

jingham created this revision. jingham added reviewers: JDevlieghere, mib. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Turns out there's no API to find out if a user command exists. There's SBComma

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

mib updated this revision to Diff 500975. mib added a comment. Rename `is_oneliner` flag to `is_callback` and swap the logic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144688/new/ https://reviews.llvm.org/D144688 Files: lldb/include/lldb/Interpreter/ScriptInterpreter.h lldb/sou

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

delcypher created this revision. Herald added a project: All. delcypher requested review of this revision. Herald added a project: LLDB. This patch adds the following methods: - `GetType()` - `IsWatchVariable()` - `GetWatchSpec()` These effectively expose methods that `lldb_private::Watchpoint`

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

delcypher updated this revision to Diff 500993. delcypher added a comment. Herald added a subscriber: JDevlieghere. Fix reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144937/new/ https://reviews.llvm.org/D144937 Files: lldb/bindings/int

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

delcypher updated this revision to Diff 500994. delcypher added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144937/new/ https://reviews.llvm.org/D144937 Files: lldb/bindings/interface/SBWatchpointDocstrings.i lldb/include

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

delcypher accepted this revision. delcypher added a comment. @mib Thanks for working on this. LGTM (with very minor nits), but you should probably wait for someone who works on LLDB more frequently than me to give you the ok. Comment at: lldb/source/Plugins/ScriptInterpreter