[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

2023-01-25 Thread Pavel Kosov via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2af0a478eaee: [lldb] Consider all breakpoints in breakpoint detection (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140368/new/ https

[Lldb-commits] [lldb] 2af0a47 - [lldb] Consider all breakpoints in breakpoint detection

2023-01-25 Thread Pavel Kosov via lldb-commits
Author: Pavel Kosov Date: 2023-01-25T11:06:07+03:00 New Revision: 2af0a478eaee5e6236e7e9fd9b1e3207228ce2ff URL: https://github.com/llvm/llvm-project/commit/2af0a478eaee5e6236e7e9fd9b1e3207228ce2ff DIFF: https://github.com/llvm/llvm-project/commit/2af0a478eaee5e6236e7e9fd9b1e3207228ce2ff.diff L

[Lldb-commits] [lldb] 4ae221f - [NFC][LLDB] Rename test file

2023-01-25 Thread Pavel Kosov via lldb-commits
Author: Pavel Kosov Date: 2023-01-25T12:03:11+03:00 New Revision: 4ae221f5a4d1977f316b7d5f033763f876b471e7 URL: https://github.com/llvm/llvm-project/commit/4ae221f5a4d1977f316b7d5f033763f876b471e7 DIFF: https://github.com/llvm/llvm-project/commit/4ae221f5a4d1977f316b7d5f033763f876b471e7.diff L

[Lldb-commits] [PATCH] D140624: [LLDB] Fixes summary formatter for libc++ map allowing modification of contained value

2023-01-25 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This rev has broken lldb-arm-ubuntu buildbot https://lab.llvm.org/buildbot/#/builders/17/builds/33173 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D140624: [LLDB] Fixes summary formatter for libc++ map allowing modification of contained value

2023-01-25 Thread Pavel Kosov via Phabricator via lldb-commits
kpdev42 added a comment. In D140624#4079306 , @omjavaid wrote: > This rev has broken lldb-arm-ubuntu buildbot > https://lab.llvm.org/buildbot/#/builders/17/builds/33173 Sorry. I've added a small fix for it https://github.com/llvm/llvm-project/commit/4a

[Lldb-commits] [PATCH] D140624: [LLDB] Fixes summary formatter for libc++ map allowing modification of contained value

2023-01-25 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett closed this revision. DavidSpickett added a comment. The fix worked - https://lab.llvm.org/buildbot/#/builders/17/builds/33176 Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140624/new/ https://reviews.llvm.org/D140624 __

[Lldb-commits] [PATCH] D142552: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines

2023-01-25 Thread David Stenberg via Phabricator via lldb-commits
dstenb created this revision. dstenb added reviewers: jasonmolenda, clayborg, aeubanks, ayermolo. dstenb added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. Herald added a project: All. dstenb requested review of this revision. Herald added a reviewer: j

[Lldb-commits] [PATCH] D142552: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines

2023-01-25 Thread David Stenberg via Phabricator via lldb-commits
dstenb added a comment. First time looking at LLDB, so I had trouble finding a suitable way to create a reproducer for this. I would be happy to change to another type of lit test if that is more suitable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] 4076664 - [lldb][test] Replace use of p with expression (NFC)

2023-01-25 Thread Dave Lee via lldb-commits
Author: Dave Lee Date: 2023-01-25T11:03:58-08:00 New Revision: 40766642283854d035a992513e314d59c1b4ca53 URL: https://github.com/llvm/llvm-project/commit/40766642283854d035a992513e314d59c1b4ca53 DIFF: https://github.com/llvm/llvm-project/commit/40766642283854d035a992513e314d59c1b4ca53.diff LOG:

[Lldb-commits] [PATCH] D141539: [lldb][test] Replace use of p with expression (NFC)

2023-01-25 Thread Dave Lee via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG407666422838: [lldb][test] Replace use of p with expression (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141539/new/ https

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

2023-01-25 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D138618#4077851 , @ayermolo wrote: > In D138618#4073329 , @labath wrote: > >> I think that the 1-based index thingy helps a lot here, but I haven't seen >> anything (in your reponse, or

[Lldb-commits] [PATCH] D142266: [lldb] Add PlatformMetadata for ScriptedPlatform

2023-01-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Cool, I like how this sidesteps having to go through the plugin instantiation mechanism. LGTM if Pavel's happy. Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:19 +class CommandObjectPlatformSelect; // PlatformOptionGroup --

[Lldb-commits] [PATCH] D142513: [lldb][test] Set minimum compiler_versions

2023-01-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. In D142513#4078932 , @kastiglione wrote: > It's the LLDB matrix that's failing, where previous compiler versions are > also used. Gotcha, that makes sense Repository: rG LLVM Github

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

2023-01-25 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76697/new/ https://reviews.llvm.org/D76697 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits