Author: Kazu Hirata
Date: 2023-01-15T09:04:57-08:00
New Revision: 9ce7b40ad49f4e16c74d0a181c5cd25d21e417c8
URL:
https://github.com/llvm/llvm-project/commit/9ce7b40ad49f4e16c74d0a181c5cd25d21e417c8
DIFF:
https://github.com/llvm/llvm-project/commit/9ce7b40ad49f4e16c74d0a181c5cd25d21e417c8.diff
L
Author: Saagar Jha
Date: 2023-01-15T11:10:52-08:00
New Revision: 93b00d9717b58ba93f0942a243ba6dac4ef6
URL:
https://github.com/llvm/llvm-project/commit/93b00d9717b58ba93f0942a243ba6dac4ef6
DIFF:
https://github.com/llvm/llvm-project/commit/93b00d9717b58ba93f0942a243ba6dac4ef6.diff
LO
This revision was automatically updated to reflect the committed changes.
Closed by commit rG93b00d97: [lldb] Fix typos and update "GDB To LLDB
Command Map" to be a bit more clear (authored by saagarjha, committed by
JDevlieghere).
Changed prior to commit:
https://reviews.llvm.org/D28758?v
JDevlieghere added a comment.
Thanks Saagar!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D28758/new/
https://reviews.llvm.org/D28758
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
Author: Benjamin Kramer
Date: 2023-01-15T21:39:31+01:00
New Revision: 8959968b7225d154dca05cdeee17f9477429c420
URL:
https://github.com/llvm/llvm-project/commit/8959968b7225d154dca05cdeee17f9477429c420
DIFF:
https://github.com/llvm/llvm-project/commit/8959968b7225d154dca05cdeee17f9477429c420.dif
eloparco added inline comments.
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2177
+ const auto max_instruction_size = g_vsc.target.GetMaximumOpcodeByteSize();
+ const auto bytes_offset = -instruction_offset * max_instruction_size;
+ auto start_addr = base_addr - bytes_of
jloser created this revision.
jloser added reviewers: MaskRay, serge-sans-paille, dblaikie.
Herald added subscribers: Moerafaat, zero9178, bzcheeseman, kosarev, ayermolo,
sdasgup3, wenzhicui, wrengr, foad, cota, teijeong, rdzhabarov, tatianashp,
msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerb
saagarjha created this revision.
Herald added a project: All.
saagarjha requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
It seems like these were copied from the single-step code and not
updated to match the new flags.
Repository:
rG LLV
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Right: `BCR_M_IMVA_MISMATCH` would be mismatch. LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141816/new/
https://reviews.llvm
Author: Saagar Jha
Date: 2023-01-15T23:39:22-08:00
New Revision: 08d6cf232c0e4ca8ebafc3e2b9eb488f014f5b41
URL:
https://github.com/llvm/llvm-project/commit/08d6cf232c0e4ca8ebafc3e2b9eb488f014f5b41
DIFF:
https://github.com/llvm/llvm-project/commit/08d6cf232c0e4ca8ebafc3e2b9eb488f014f5b41.diff
LO
This revision was automatically updated to reflect the committed changes.
Closed by commit rG08d6cf232c0e: [lldb] Fix comments referring to
BCR_M_IMVA_MATCH (authored by saagarjha, committed by JDevlieghere).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.
serge-sans-paille added a comment.
LGTM
Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:652
auto data =
+ llvm::MutableArrayRef(static_cast(buf), bytes_read);
random nit: This could be rewritten as
```
llvm::MutableArrayRef data(static_
12 matches
Mail list logo