[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + labath wrote: > mib wrote: > > labath wrote: > > > mib wrot

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. Awesome, thank you for reviewing, I appreciate it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa3fa4d0d423: [llvm][dwwarf] Change CU/TU index to 64-bit (authored by ayermolo). Changed prior to commit: https://reviews.llvm.org/D139379?vs=485160&id=487881#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D141021: [lldb] Remove tools copied into LLDB.framework before install

bulbazord added inline comments. Comment at: lldb/source/API/CMakeLists.txt:215-216 + + add_dependencies(install-liblldb +lldb-framework-cleanup) endif() I think you need to add it as a dependency of `install-liblldb-stripped` as well? CHANGES SINCE LAST

[Lldb-commits] [PATCH] D141021: [lldb] Remove tools copied into LLDB.framework before install

JDevlieghere updated this revision to Diff 487901. JDevlieghere added a comment. Add dependency to `install-liblldb-stripped`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141021/new/ https://reviews.llvm.org/D141021 Files: lldb/cmake/modules/AddLLDB.cmake lldb/cmake/modules/LLDBC

[Lldb-commits] [lldb] f6ce39c - [lldb] Remove tools copied into LLDB.framework before install

Author: Jonas Devlieghere Date: 2023-01-10T11:22:47-08:00 New Revision: f6ce39cf1d1d80699e13cd1422f60d428e5cf0ec URL: https://github.com/llvm/llvm-project/commit/f6ce39cf1d1d80699e13cd1422f60d428e5cf0ec DIFF: https://github.com/llvm/llvm-project/commit/f6ce39cf1d1d80699e13cd1422f60d428e5cf0ec.d

[Lldb-commits] [PATCH] D141021: [lldb] Remove tools copied into LLDB.framework before install

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6ce39cf1d1d: [lldb] Remove tools copied into LLDB.framework before install (authored by JDevlieghere). Herald added a project: LLDB. Repository:

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

kastiglione created this revision. kastiglione added reviewers: jingham, labath, aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add support for the `--gdb-format`/`-G` flag to `dwim-print`.

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

mib updated this revision to Diff 487989. mib added a comment. Herald added a subscriber: Michael137. Update unittests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139249/new/ https://reviews.llvm.org/D139249 Files: lldb/bindings/interface/SBPlatform.i lldb/include/lldb/API/SBDebu

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib updated this revision to Diff 488004. mib edited the summary of this revision. mib added a comment. Address @JDevlieghere comment: - refactor SWIG scripted object create methods into a single one CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139250/new/ https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D139251: [lldb/Interpreter] Introduce ScriptedPlatform{, Python}Interface

mib updated this revision to Diff 488006. mib marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139251/new/ https://reviews.llvm.org/D139251 Files: lldb/include/lldb/Interpreter/ScriptInterpreter.h lldb/include/lldb/Interpreter/ScriptedPlatformInterface.

[Lldb-commits] [PATCH] D141219: Add a .lldbinit file to autoload LLVM/Clang data formatters

jingham added a comment. I've been holding off on actually promoting the lldbDataFormatters until there was some tests written for these formatters. llvm data structures are constantly changing and so formatters in these files often break. It shouldn't be hard to build a little test executabl

[Lldb-commits] [PATCH] D141219: Add a .lldbinit file to autoload LLVM/Clang data formatters

jingham added a comment. Also for anyone not using CLion, having the local .lldbinit file in the root directory is not all that helpful, you'd really want it to be copied into the bin directory of your build, since most people when debugging their new binaries cd to the bin directory and run it

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib updated this revision to Diff 488014. mib added a comment. Log the error message instead of consuming it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139252/new/ https://reviews.llvm.org/D139252 Files: lldb/source/Plugins/Platform/CMakeLists.txt lldb/source/Plugins/Platform/sc

[Lldb-commits] [PATCH] D140102: [lldb] Explain memory history provider in mem hist command description

jingham added a comment. This is a fine idea. However, it doesn't seem immediately obvious that a "memory history provider plugin" is a property of the executable, not lldb. In other instances we say we don't have an architecture plugin for your architecture, etc. So that ends up sounding mor

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I haven't followed the lldb-vscode codebase closely enough to have useful comments on that part of the code. But so far as I can tell, you didn't add a test for SBTarget::GetMaxim

[Lldb-commits] [PATCH] D140249: [lldb] Do not deallocate memory after exec

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. It doesn't seem unreasonable that in the course of time we'll come across another circumstance where it's not worth deallocating these memory regions (for instance, we really don't

[Lldb-commits] [lldb] 302f4ae - [lldb] Only add lldb-framework-cleanup dependency to existing targets

Author: Jonas Devlieghere Date: 2023-01-10T16:23:43-08:00 New Revision: 302f4aef7930c125236f071140eb9482532f2877 URL: https://github.com/llvm/llvm-project/commit/302f4aef7930c125236f071140eb9482532f2877 DIFF: https://github.com/llvm/llvm-project/commit/302f4aef7930c125236f071140eb9482532f2877.d

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

mib updated this revision to Diff 488029. mib added a comment. Address comments from @JDevlieghere & @bulbazord CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139484/new/ https://reviews.llvm.org/D139484 Files: lldb/test/API/functionalities/scripted_process/Makefile lldb/test/API/fu

[Lldb-commits] [PATCH] D140249: [lldb] Do not deallocate memory after exec

bulbazord updated this revision to Diff 488035. bulbazord added a comment. Address @jingham's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140249/new/ https://reviews.llvm.org/D140249 Files: lldb/include/lldb/Target/Memory.h lldb/sou

[Lldb-commits] [PATCH] D140293: [lldb] Update custom commands to always be overrriden

mib updated this revision to Diff 488036. mib added a comment. Fix typo in `crashlog.py` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140293/new/ https://reviews.llvm.org/D140293 Files: lldb/examples/darwin/heap_find/heap.py lldb/examples/python/bsd.py lldb/examples/python/cmdte

[Lldb-commits] [PATCH] D134642: Propagate FORK events back to client

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. First off, Is there a meaningful distinction between "fork" and "clone" in this context? we call the act whereby a process generates a child process a fork everywhere else in lldb

[Lldb-commits] [PATCH] D134642: Propagate FORK events back to client

jingham added a comment. Note, IMO the better solution to the problem of how to follow parent & child over a fork is to implement another "follow-fork" mode: "both" that when it sees the fork event, creates a separate target for the child process, and sets lldb debugging both. Then the user co

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I don't think this is quite right. First off, it's a little weird that your `dwim-print` command only supports the gdb-format option and not the format option? In the long run, I

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

jingham added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:61 + // The numerous flags of `OptionGroupValueObjectDisplay` are not exposed by + // the `dwim-print` command. However its defaults are needed for dumping Is this your