[Lldb-commits] [lldb] a06342d - [lldb] Modify TestThreadJump to work around a change in clang's debug_line generation

Author: Pavel Labath Date: 2022-12-12T09:31:35+01:00 New Revision: a06342d250ec7bee37dc93477f233e43e597aca5 URL: https://github.com/llvm/llvm-project/commit/a06342d250ec7bee37dc93477f233e43e597aca5 DIFF: https://github.com/llvm/llvm-project/commit/a06342d250ec7bee37dc93477f233e43e597aca5.diff

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

labath added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + I am surprised that you want to go down the "run" path f

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

lh03061238 created this revision. lh03061238 added reviewers: SixWeining, wangleiat, xen0n, xry111, MaskRay, DavidSpickett, seehearfeel. Herald added a subscriber: StephenFan. Herald added a project: All. lh03061238 requested review of this revision. Herald added a project: LLDB. Herald added a su

[Lldb-commits] [PATCH] D139463: Fix breakpoint-command.test when no script interpreter is compiled in.

labath added inline comments. Comment at: lldb/test/Shell/Breakpoint/breakpoint-command.test:1 +# REQUIRES: script-interpreter # RUN: %build %p/Inputs/dummy-target.c -o %t.out Maybe this could just be `REQUIRES: lua || python`? I don't expect we will have many

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + labath wrote: > I am surprised that you want to go down the

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

labath added a comment. I just found out that this test (the non-shared-library version) fails on linux if the executable is built with `-no-pie` (which is the default if the `CLANG_DEFAULT_PIE_ON_LINUX` option is not set, which happened to be the case for my build). I think the important fact

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

Michael137 added a comment. In D138724#3988318 , @labath wrote: > I just found out that this test (the non-shared-library version) fails on > linux if the executable is built with `-no-pie` (which is the default if the > `CLANG_DEFAULT_PIE_ON_LINUX` opt

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib updated this revision to Diff 482112. mib marked 3 inline comments as done. mib added a comment. Address @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139252/new/ https://reviews.llvm.org/D139252 Files: lldb/examples/python/scripted_process/scripted_platform.p

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib updated this revision to Diff 482113. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139252/new/ https://reviews.llvm.org/D139252 Files: lldb/source/Plugins/Platform/CMakeLists.txt lldb/source/Plugins/Platform/scripted/CMakeLists.txt lldb/source/Plugins/Platform/scripted/Scripte

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

Michael137 added a comment. In D138724#3988318 , @labath wrote: > I just found out that this test (the non-shared-library version) fails on > linux if the executable is built with `-no-pie` (which is the default if the > `CLANG_DEFAULT_PIE_ON_LINUX` opt

[Lldb-commits] [lldb] 5e6467b - [lldb] Remove redundant XFAIL

Author: Paul Robinson Date: 2022-12-12T08:05:03-08:00 New Revision: 5e6467bb3fd214b96b69de8bba4852002ef2c9b9 URL: https://github.com/llvm/llvm-project/commit/5e6467bb3fd214b96b69de8bba4852002ef2c9b9 DIFF: https://github.com/llvm/llvm-project/commit/5e6467bb3fd214b96b69de8bba4852002ef2c9b9.diff

[Lldb-commits] [PATCH] D139734: [LLDB] Remove redundant XFAIL

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e6467bb3fd2: [lldb] Remove redundant XFAIL (authored by probinson). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

mib created this revision. mib added reviewers: jingham, bulbazord. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch enhances queue support in Scripted Process

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

steven_wu added a comment. > Can you tell if this has been fixed by > https://github.com/llvm/llvm-project/commit/303f20a2cab4554a10ec225fd853709146f8c51c > ? I can still reproduce this with latest commit. It is not fixed. At least it can easily reproduce on Darwin platform with bootstrap (sta

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp:757 + bool is_scripted_process = m_process->GetPluginName() == "ScriptedProcess"; for (ThreadSP thread_sp : m_process->Threads()) { Comparing th

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/CMakeLists.txt:9 add_subdirectory(POSIX) +add_subdirectory(scripted) add_subdirectory(QemuUser) Comment at: lldb/source/Plugins/Platform/scripted/ScriptedPlatform.c

[Lldb-commits] [lldb] 81f1f6d - [lldb] Make ParseTemplateParameterInfos return false if there are no template params

Author: Arthur Eubanks Date: 2022-12-12T10:28:52-08:00 New Revision: 81f1f6db40abc2cc7f964bf450a2e9f78f14a8a8 URL: https://github.com/llvm/llvm-project/commit/81f1f6db40abc2cc7f964bf450a2e9f78f14a8a8 DIFF: https://github.com/llvm/llvm-project/commit/81f1f6db40abc2cc7f964bf450a2e9f78f14a8a8.diff

[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

This revision was automatically updated to reflect the committed changes. Closed by commit rG81f1f6db40ab: [lldb] Make ParseTemplateParameterInfos return false if there are no template… (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139249/new/ https://reviews.llvm.org/D139249 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D139463: Fix breakpoint-command.test when no script interpreter is compiled in.

hctim marked an inline comment as done. hctim added inline comments. Comment at: lldb/test/Shell/Breakpoint/breakpoint-command.test:1 +# REQUIRES: script-interpreter # RUN: %build %p/Inputs/dummy-target.c -o %t.out labath wrote: > Maybe this could just be `REQUI

[Lldb-commits] [PATCH] D139463: Fix breakpoint-command.test when no script interpreter is compiled in.

hctim updated this revision to Diff 482190. hctim marked an inline comment as done. hctim added a comment. change to using existing python/lua glue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139463/new/ https://reviews.llvm.org/D139463 Files:

[Lldb-commits] [PATCH] D139463: Fix breakpoint-command.test when no script interpreter is compiled in.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139463/new/ https://reviews.llvm.org/D139463 __

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

mib added inline comments. Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp:757 + bool is_scripted_process = m_process->GetPluginName() == "ScriptedProcess"; for (ThreadSP thread_sp : m_process->Threads()) { JDevlieghere wrote: >

[Lldb-commits] [PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

serge-sans-paille created this revision. serge-sans-paille added a reviewer: nikic. Herald added subscribers: steakhal, pmatos, asb, jhenderson, abrachet, ormris, martong, phosek, kadircet, arphaman, steven_wu, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: JDevlieghere. Herald

[Lldb-commits] [lldb] 1b75324 - Fix breakpoint-command.test when no script interpreter is compiled in.

Author: Mitch Phillips Date: 2022-12-12T14:12:52-08:00 New Revision: 1b753240d50a930c12c42e2f230804db3dccde96 URL: https://github.com/llvm/llvm-project/commit/1b753240d50a930c12c42e2f230804db3dccde96 DIFF: https://github.com/llvm/llvm-project/commit/1b753240d50a930c12c42e2f230804db3dccde96.diff

[Lldb-commits] [PATCH] D139463: Fix breakpoint-command.test when no script interpreter is compiled in.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b753240d50a: Fix breakpoint-command.test when no script interpreter is compiled in. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13946

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added a comment. ping @JDevlieghere Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + mib wrote: > labath wrote: > > I am surprise

[Lldb-commits] [PATCH] D139251: [lldb/Interpreter] Introduce ScriptedPlatform{, Python}Interface

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPlatformPythonInterface.cpp:97 + +#endif nit: This `#endif` should have a ` // L

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

SixWeining added a comment. 1. Does the directory `lldb/source/Plugins/Instruction/LoongArch/` target both `LoongArch64` and `LoongArch32`? 2. Will you handle floating pointer branching instructions `bceqz` and `bcnez` in future? Comment at: lldb/source/Plugins/Instruction/L

[Lldb-commits] [PATCH] D139910: [NFC] Cleanup: Remove Function::getBasicBlockList() when not required.

vporpo created this revision. vporpo added reviewers: aeubanks, asbirlea. Herald added subscribers: Moerafaat, zero9178, Enna1, bzcheeseman, mattd, awarzynski, sdasgup3, wenzhicui, wrengr, ormris, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aa