[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

seehearfeel added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_loongarch64.cpp:27 +// NT_PRSTATUS and NT_FPREGSET definition +#include + SixWeining wrote: > [[ https://llvm.org/docs/CodingStandards.html#include-style

[Lldb-commits] [PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. lldb parts LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138539/new/ https://reviews.llvm.org/D138539 ___ lldb-commits

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_loongarch64.cpp:221 + + uint8_t *src = const_cast(data_sp->GetBytes()); + if (src == nullptr) { seehearfeel wrote: > DavidSpickett wrote: > > Possibly

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

Michael137 created this revision. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a formatter for `std::ranges::ref_view`. It simply holds a `T*`, so all this formatter does is derefer

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

Michael137 updated this revision to Diff 477439. Michael137 added a comment. - Use typedef in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138558/new/ https://reviews.llvm.org/D138558 Files: lldb/source/Plugins/Language/CPlusPlus/CMakeList

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

Michael137 updated this revision to Diff 477440. Michael137 added a comment. - Clean up test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138558/new/ https://reviews.llvm.org/D138558 Files: lldb/source/Plugins/Language/CPlusPlus/CMakeLists.txt

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

seehearfeel added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_loongarch64.cpp:221 + + uint8_t *src = const_cast(data_sp->GetBytes()); + if (src == nullptr) { DavidSpickett wrote: > seehearfeel wrote: > > DavidSpick

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_loongarch64.cpp:221 + + uint8_t *src = const_cast(data_sp->GetBytes()); + if (src == nullptr) { seehearfeel wrote: > DavidSpickett wrote: > > seehearf

[Lldb-commits] [lldb] 14aace3 - Revert "Add runToBinaryEntry option for lldb-vscode"

Author: Pavel Labath Date: 2022-11-23T13:26:11+01:00 New Revision: 14aace34c35da1ae5ffc4abc599cbdb36bf33a01 URL: https://github.com/llvm/llvm-project/commit/14aace34c35da1ae5ffc4abc599cbdb36bf33a01 DIFF: https://github.com/llvm/llvm-project/commit/14aace34c35da1ae5ffc4abc599cbdb36bf33a01.diff

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

labath added a comment. Unfortunately, it looks like that patch broke things too. I haven't looked at the cause too closely, as the error was the same on linux and macos, but if you have problems reproducing it, let me know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

labath added a comment. Ah, now I see that patch didn't land yet. In the future, I think you can land simple changes like that without waiting for a (pre-commit) review, but if you don't feel comfortable doing that, then please revert the original patch so as to not leave the build in a broken

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Okay, looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138259/new/ https://reviews.llvm.org/D138259

[Lldb-commits] [lldb] 6d4ab6d - [LLDB][RISCV] Add RV32F instruction support for EmulateInstructionRISCV

Author: Emmmer Date: 2022-11-23T22:09:14+08:00 New Revision: 6d4ab6d921792125969e5f917b84cc810a1ba95c URL: https://github.com/llvm/llvm-project/commit/6d4ab6d921792125969e5f917b84cc810a1ba95c DIFF: https://github.com/llvm/llvm-project/commit/6d4ab6d921792125969e5f917b84cc810a1ba95c.diff LOG: [

[Lldb-commits] [PATCH] D138447: [LLDB][RISCV] Add RV32F instruction support for EmulateInstructionRISCV

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d4ab6d92179: [LLDB][RISCV] Add RV32F instruction support for EmulateInstructionRISCV (authored by Emmmer). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D138589: Add runToBinaryEntry option for lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch add

[Lldb-commits] [lldb] d941fce - Add the ability to see when a type in incomplete.

Author: Greg Clayton Date: 2022-11-23T10:07:12-08:00 New Revision: d941fceca8e9bc9b5a00c9865ee022ba5507df32 URL: https://github.com/llvm/llvm-project/commit/d941fceca8e9bc9b5a00c9865ee022ba5507df32 DIFF: https://github.com/llvm/llvm-project/commit/d941fceca8e9bc9b5a00c9865ee022ba5507df32.diff

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd941fceca8e9: Add the ability to see when a type in incomplete. (authored by clayborg). Changed prior to commit: https://reviews.llvm.org/D138259?vs=477314&id=477548#toc Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D138589: Add runToBinaryEntry option for lldb-vscode

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We have to let the IDE set breakpoints after the "initialized" packet is sent and _then_ do this functionality. So this patch needs to be modified to make that happen. ===

[Lldb-commits] [PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138539/new/ https://reviews.llvm.org/D138539 _

[Lldb-commits] [PATCH] D138589: Add runToBinaryEntry option for lldb-vscode

clayborg added a comment. Ideally this feature would enable a one shot breakpoint and let the startup happen just like it was before this patch. We don't want the user to see this stop right? It seems like we should allow some commands to be run with this one shot breakpoint and have it auto c

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

mstorsjo added a comment. This seems to have caused build errors with GCC: ../tools/lldb/source/Symbol/CompilerType.cpp: In member function ‘bool lldb_private::CompilerType::IsForcefullyCompleted() const’: ../tools/lldb/source/Symbol/CompilerType.cpp:99:25: error: base operand of ‘->’ has n

[Lldb-commits] [PATCH] D138589: Add runToBinaryEntry option for lldb-vscode

yinghuitan abandoned this revision. yinghuitan added a comment. Discussed offline. We can't rely on initialized event because it has to happen before all breakpoints are set. Will create a new design for htis. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

MaskRay added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:218 + explicit NameLookup(std::nullopt_t) : Data(nullptr, true) {} explicit NameLookup(std::nullptr_t) : Data(nullptr, false) {} NameLookup() : NameLookup(nullptr) {} --

[Lldb-commits] [lldb] 8b95d08 - Unbreak lldb build broken by d941fceca8e9

Author: Benjamin Kramer Date: 2022-11-23T21:01:47+01:00 New Revision: 8b95d08799cabaebf9b7549356e0552a17791dc6 URL: https://github.com/llvm/llvm-project/commit/8b95d08799cabaebf9b7549356e0552a17791dc6 DIFF: https://github.com/llvm/llvm-project/commit/8b95d08799cabaebf9b7549356e0552a17791dc6.dif

[Lldb-commits] [lldb] 34bcadc - Use std::nullopt_t instead of NoneType (NFC)

Author: Kazu Hirata Date: 2022-11-23T14:16:04-08:00 New Revision: 34bcadc38c2240807cd079fd03b93fc96cf64c84 URL: https://github.com/llvm/llvm-project/commit/34bcadc38c2240807cd079fd03b93fc96cf64c84 DIFF: https://github.com/llvm/llvm-project/commit/34bcadc38c2240807cd079fd03b93fc96cf64c84.diff L

[Lldb-commits] [PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34bcadc38c22: Use std::nullopt_t instead of NoneType (NFC) (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks created this revision. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This simplifies an upcoming patch. Repository: rG LLVM Github Monorepo https://revie

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks updated this revision to Diff 477608. aeubanks added a comment. Herald added a subscriber: JDevlieghere. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138612/new/ https://reviews.llvm.org/D138612 Files: lldb/source/Plugins/Symbol

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks updated this revision to Diff 477611. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138612/new/ https://reviews.llvm.org/D138612 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp lldb

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo created this revision. Herald added subscribers: hoy, modimo, wenlei, arphaman. Herald added a reviewer: shafik. Herald added a project: All. ayermolo published this revision for review. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a pr

[Lldb-commits] [lldb] a2f1879 - [lldb] Fix a warning

Author: Kazu Hirata Date: 2022-11-23T15:55:05-08:00 New Revision: a2f1879c2d8ad5e6c2773d77d9f6d3fdaffbe3ea URL: https://github.com/llvm/llvm-project/commit/a2f1879c2d8ad5e6c2773d77d9f6d3fdaffbe3ea DIFF: https://github.com/llvm/llvm-project/commit/a2f1879c2d8ad5e6c2773d77d9f6d3fdaffbe3ea.diff L

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

seehearfeel updated this revision to Diff 477650. seehearfeel added a comment. (1) Put elf.h before sys/uio.h (2) Remove unnecessary indent (3) Remove const cast of data_sp->GetBytes() (4) Return k_num_register_sets in GetRegisterSetCount() (5) Add register name alias CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

SixWeining added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfos_loongarch64.h:21 +#define GPR_OFFSET(idx) ((idx)*8 + 0) +#define FPR_OFFSET(idx) ((idx)*8 + sizeof(RegisterInfoPOSIX_loongarch64::GPR)) +#define FCC_OFFSET(idx) ((idx)*1 + 32 * 8 + si

[Lldb-commits] [PATCH] D138638: Report which modules have forcefully completed types in statistics.

clayborg created this revision. clayborg added a reviewer: yinghuitan. Herald added a reviewer: shafik. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A previous patch added the ability for us to tell

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

xen0n added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfos_loongarch64.h:98 +DEFINE_GPR64_ALT(r20, t8, LLDB_INVALID_REGNUM), +DEFINE_GPR64_ALT(r21, u0, LLDB_INVALID_REGNUM), +DEFINE_GPR64_ALT(r22, fp, LLDB_REGNUM_GENERIC_FP), --

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

seehearfeel added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfos_loongarch64.h:21 +#define GPR_OFFSET(idx) ((idx)*8 + 0) +#define FPR_OFFSET(idx) ((idx)*8 + sizeof(RegisterInfoPOSIX_loongarch64::GPR)) +#define FCC_OFFSET(idx) ((idx)*1 + 32 * 8 + s

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

seehearfeel updated this revision to Diff 477690. seehearfeel added a comment. (1) define *_OFFSET in RegisterInfoPOSIX_loongarch64.cpp (2) remove the alias u0 for r21, use fp and s9 for r22 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138407/new/ https://reviews.llvm.org/D138407 File