[Lldb-commits] [PATCH] D135648: [lldb] Add matching based on Python callbacks for data formatters.

jgorbe created this revision. jgorbe added reviewers: jingham, labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. This patch adds a new matching method for data formatters, in addition to the existin

[Lldb-commits] [PATCH] D135461: [LLDB] Fix crash when printing a struct with a static wchar_t member

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. > although those changes don't actually test the code path changed here Yeah I'm just cargo culting on that one so it doesn't look strange that a few are missing. If we're going

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

DavidSpickett added inline comments. Comment at: lldb/source/Utility/Diagnostics.cpp:43 + std::lock_guard guard(m_callbacks_mutex); + m_callbacks.push_back(callback); +} DavidSpickett wrote: > Is it worth adding an assert that the callback is not already in the

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

labath added a comment. I'm not sure if this will do what you wanted it to do. Despite the title, this patch is not adding a new log *channel* -- it is adding a new log *category* to the "lldb" channel. Our logging infra, perhaps somewhat misleadingly, manages all of the log state on a per-chan

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

labath added a comment. seems fine to me. Comment at: lldb/test/Shell/Diagnostics/TestCopyLogs.test:3 +# RUN: mkdir -p %t +# The "ll''db" below is not a typo but a way to prevent lit from substituting 'lldb'. +# RUN: %lldb -o 'log enable ll''db commands -f %t/commands.log' -o

[Lldb-commits] [PATCH] D134962: [LLDB] Change pointer to ref in EmulateInstruction::ReadRegister methods

DavidSpickett added a comment. No problem, thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134962/new/ https://reviews.llvm.org/D134962 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [lldb] 2a627e2 - [LLDB] Change pointer to ref in EmulateInstruction::ReadRegister methods

Author: David Spickett Date: 2022-10-11T12:31:55Z New Revision: 2a627e2ad1d80b660fcb02dde85b346f61193ade URL: https://github.com/llvm/llvm-project/commit/2a627e2ad1d80b660fcb02dde85b346f61193ade DIFF: https://github.com/llvm/llvm-project/commit/2a627e2ad1d80b660fcb02dde85b346f61193ade.diff LOG

[Lldb-commits] [PATCH] D134962: [LLDB] Change pointer to ref in EmulateInstruction::ReadRegister methods

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a627e2ad1d8: [LLDB] Change pointer to ref in EmulateInstruction::ReadRegister methods (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectDiagnostics.cpp:85 + result.AppendError(llvm::toString(directory.takeError())); + result.SetStatus(eReturnStatusFailed); + return result.Succeeded(); AppendError set

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

DavidSpickett added a comment. So either way, if someone was running with no logs enabled we would have to ask them to enable them then re-run and get a new set of diagnostics (which is fine as is , not a criticism). Option 1 they would need to add `-o "log enable gdb-remote packets -f "`. Opti

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

DavidSpickett added a comment. Also is the buffer option the same as "circular" here? -h ( --log-handler ) Specify a log handler which determines where log messages are written. Values: default | stream | circular | os So we could have diagnostics also save anything kept in "ci

[Lldb-commits] [lldb] 81832af - [LLDB] Switch to RegisterInfo& for EmulateInstruction::WriteRegister

Author: David Spickett Date: 2022-10-11T13:24:55Z New Revision: 81832afc04e130a386a89f57d3f4f2d7f19006f7 URL: https://github.com/llvm/llvm-project/commit/81832afc04e130a386a89f57d3f4f2d7f19006f7 DIFF: https://github.com/llvm/llvm-project/commit/81832afc04e130a386a89f57d3f4f2d7f19006f7.diff LOG

[Lldb-commits] [PATCH] D134963: [LLDB] Switch to RegisterInfo& for EmulateInstruction::WriteRegister

This revision was automatically updated to reflect the committed changes. Closed by commit rG81832afc04e1: [LLDB] Switch to RegisterInfo& for EmulateInstruction::WriteRegister (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

lldb-commits@lists.llvm.org

Author: David Spickett Date: 2022-10-11T13:59:05Z New Revision: c7ddbd62d811524726e6f8e293ab1576c5b289f3 URL: https://github.com/llvm/llvm-project/commit/c7ddbd62d811524726e6f8e293ab1576c5b289f3 DIFF: https://github.com/llvm/llvm-project/commit/c7ddbd62d811524726e6f8e293ab1576c5b289f3.diff LOG

lldb-commits@lists.llvm.org

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7ddbd62d811: [LLDB] Change RegisterValue::GetAsMemoryData to const RegisterInfo& (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

lldb-commits@lists.llvm.org

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. All callers were either assuming their pointer was not null before calling this, or checking beforehand. Repos

lldb-commits@lists.llvm.org

DavidSpickett added a reviewer: clayborg. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. This set of 4 patches will be it for a while on this front, honest :) Thanks for the reviews so far! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D135670: [LLDB] Pass const RegisterInfo& to RegisterValue::SetValueFromData

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Familiar story, callers are either checking upfront that the pointer wasn't null or not checking at all. SetValu

lldb-commits@lists.llvm.org

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. No one was pasing nullptr here. Depends on D135670 Repository: rG LLVM G

[Lldb-commits] [PATCH] D135672: [LLDB] Change EmulateInstriction::ReadRegister to return Optional

DavidSpickett created this revision. Herald added subscribers: atanasyan, jrtc27. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Making it easier to understand and harder to misuse. This only appl

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. In D135631#3849295 , @DavidSpickett wrote: > So either way, if someone was running with no logs enabled we would have to > ask them to enable them then re-run and get a new set

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere added a comment. In D135621#3849043 , @labath wrote: > I'm not sure if this will do what you wanted it to do. Despite the title, > this patch is not adding a new log *channel* -- it is adding a new log > *category* to the "lldb" channel. Ou

[Lldb-commits] [PATCH] D135607: Summary:

JDevlieghere added a comment. In D135607#3848334 , @HenriqueBucher wrote: > To be frank, I think this formatting is silly and wrong now that I am looking > at it. > Looking at the rendered markdown at Github >

[Lldb-commits] [PATCH] D135577: Summary:

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llvm.org/D135577 ___

[Lldb-commits] [PATCH] D135577: Summary:

JDevlieghere added a comment. Henrique, do you have commit access? Whoever ends up committing this, please make sure the commit has a reasonable commit description and not "Summary:". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ http

[Lldb-commits] [lldb] eab5c2f - [LLDB] Fix crash when printing a struct with a static wchar_t member

Author: Arthur Eubanks Date: 2022-10-11T11:04:32-07:00 New Revision: eab5c2f94f5aae17c3fc513ee347ee9bc1d2bcae URL: https://github.com/llvm/llvm-project/commit/eab5c2f94f5aae17c3fc513ee347ee9bc1d2bcae DIFF: https://github.com/llvm/llvm-project/commit/eab5c2f94f5aae17c3fc513ee347ee9bc1d2bcae.diff

[Lldb-commits] [PATCH] D135461: [LLDB] Fix crash when printing a struct with a static wchar_t member

This revision was automatically updated to reflect the committed changes. Closed by commit rGeab5c2f94f5a: [LLDB] Fix crash when printing a struct with a static wchar_t member (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1354

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

clayborg added a comment. Maybe use LLDBLog::Diagnostics instead of LLDBLog::AlwaysOn? and maybe "diagnostics" instead of "always-on"? I am also questioning if the these even belong in the LLDB logging stuff? Seems like it would be just as easy to create a diagnostic message by calling Diagnos

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

clayborg added inline comments. Comment at: lldb/source/Commands/CommandObjectDiagnostics.cpp:84 +if (!directory) { + result.AppendError(llvm::toString(directory.takeError())); + result.SetStatus(eReturnStatusFailed); Do we want to just create a tem

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

clayborg added a comment. > It might be nice to also have a "diagnostics" log channel that _can_ be > enabled, and any diagnostic messages would then also be included in the log > output but only if enabled by the user? And if the logging gets enabled, we can write out all of the diagnostics an

[Lldb-commits] [PATCH] D135620: Prevent lldb-vscode tests from source lldbinit file

yinghuitan updated this revision to Diff 466909. yinghuitan added a comment. Add comment per feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135620/new/ https://reviews.llvm.org/D135620 Files: lldb/packages/Python/lldbsuite/test/tools/lld

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

davrec accepted this revision. davrec added a comment. Looks good, over to @ChuanqiXu Comment at: clang/include/clang/Sema/Template.h:80 +struct ArgumentListLevel { + Decl *AssociatedDecl; + ArgList Args; mizvekov wrote: > davrec wrote: > > mizvek

[Lldb-commits] [lldb] ef25a21 - Prevent lldb-vscode tests from source lldbinit file

Author: Jeffrey Tan Date: 2022-10-11T15:43:35-07:00 New Revision: ef25a217266aaf3b6df68ac155537e3a1171dccf URL: https://github.com/llvm/llvm-project/commit/ef25a217266aaf3b6df68ac155537e3a1171dccf DIFF: https://github.com/llvm/llvm-project/commit/ef25a217266aaf3b6df68ac155537e3a1171dccf.diff L

[Lldb-commits] [PATCH] D135620: Prevent lldb-vscode tests from source lldbinit file

This revision was automatically updated to reflect the committed changes. Closed by commit rGef25a217266a: Prevent lldb-vscode tests from source lldbinit file (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135620/new/ https:

[Lldb-commits] [PATCH] D135577: Summary:

HenriqueBucher added a comment. I assume not since I have never committed on any LLVM project. But I would like to as I plan to contribute more in the future. Just sent Chris Clattner an email with the request. Note: The reason the summary is so terse is that the ARC tool opens two windows and