[Lldb-commits] [PATCH] D133501: [lldb] Use std::size instead of llvm::array_lengthof

jloser created this revision. jloser added reviewers: MaskRay, dblaikie, kazu, clayborg. Herald added subscribers: StephenFan, atanasyan, jrtc27, kbarton, nemanjai, sdardis. Herald added a project: All. jloser requested review of this revision. Herald added a project: LLDB. Herald added a subscrib

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

aprantl added a comment. Could we land this today so we can get the bots green again? Please still make sure to respond to any post-commit feedback from @labath in case there's anything hasn't been addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D133501: [lldb] Use std::size instead of llvm::array_lengthof

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133501/new/ https://reviews.llvm.org/D133501 ___

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

dmlary added a comment. @labath you are correct, lldb-test is performing the relocations. I'm digging into why I'm not seeing the changes I would expect in the section. I'll update the diff with tests when I get that resolved. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd42122cd5db0: [clang] use getCommonSugar in an assortment of place

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve updated this revision to Diff 458793. fdeazeve edited the summary of this revision. fdeazeve added a comment. Updated wording of error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://reviews.llvm.org/D132940 File

[Lldb-commits] [lldb] 9b825dc - [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContext when ICF happens.

Author: Zequan Wu Date: 2022-09-08T10:42:12-07:00 New Revision: 9b825dcdb267ee21e75e279c79ec2b3c50fd7346 URL: https://github.com/llvm/llvm-project/commit/9b825dcdb267ee21e75e279c79ec2b3c50fd7346 DIFF: https://github.com/llvm/llvm-project/commit/9b825dcdb267ee21e75e279c79ec2b3c50fd7346.diff LOG

[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContext when ICF happens.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b825dcdb267: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContext when ICF happens. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D133243?vs=458299&id=458794#toc Repos

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc38eeecbc7d9: [lldb] Use just-built libcxx for tests when available (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [lldb] c38eeec - [lldb] Use just-built libcxx for tests when available

Author: Felipe de Azevedo Piovezan Date: 2022-09-08T13:42:56-04:00 New Revision: c38eeecbc7d929c9601f2189214a7a90d3982a47 URL: https://github.com/llvm/llvm-project/commit/c38eeecbc7d929c9601f2189214a7a90d3982a47 DIFF: https://github.com/llvm/llvm-project/commit/c38eeecbc7d929c9601f2189214a7a90d

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve added a comment. It seems that a linux bot is failing after this: https://lab.llvm.org/buildbot/#/builders/68/builds/39086 This job does _not_ build the libcxx projects, and yet the `LIBCPP_INCLUDE_DIR` variable is defined. I'm investigating Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D133038: Add GetSourceMap public API

yinghuitan updated this revision to Diff 458809. yinghuitan added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files: lldb/bindings/interface/SBDebugger.i lldb/i

[Lldb-commits] [lldb] 9a41f6e - Revert "[lldb] Use just-built libcxx for tests when available"

Author: Felipe de Azevedo Piovezan Date: 2022-09-08T14:38:08-04:00 New Revision: 9a41f6e7080e7ca6274a460e9e32ba616fa46249 URL: https://github.com/llvm/llvm-project/commit/9a41f6e7080e7ca6274a460e9e32ba616fa46249 DIFF: https://github.com/llvm/llvm-project/commit/9a41f6e7080e7ca6274a460e9e32ba616

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve added a comment. I've reverted this while I find an Ubuntu machine to investigate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://reviews.llvm.org/D132940 ___ lldb-commits mail

[Lldb-commits] [PATCH] D133513: [lldb] Fix detection of LLDB_PYTHON_EXE_RELATIVE_PATH

skosukhin created this revision. skosukhin added a reviewer: lawrence_danna. Herald added a project: All. skosukhin requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It looks like f07ddbc6

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

tra added a comment. It appears that this change may result in clang crashing (e.g. it broke CUDA compilation: https://lab.llvm.org/buildbot/#/builders/55/builds/35047/steps/3/logs/stdio). Reproducer: class { typedef __complex__ a; operator=(double b){c *= b} a c $bin/clang++ -c

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. Thanks for the repro! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

dmlary updated this revision to Diff 458825. dmlary marked an inline comment as done. dmlary added a comment. - Added test cases for REL and RELA cases - Removed assert & fixme comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132954/new/ https://reviews.llvm.org/D132954 Files: l

[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

jingham added a comment. To be clear, I'm not trying to implement a preemptive interrupt using these callbacks. There are so many places where lldb is doing work that you really can't interrupt - e.g. we can't drop symbol parsing and then pick it up again later - that that doesn't really even

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting()/GetSettings() public APIs

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/bindings/interface/SBDebugger.i:228 +lldb::SBStructuredData GetSettings(); + remove this and document the function b

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

aprantl created this revision. aprantl added reviewers: JDevlieghere, Michael137, jingham, labath. Herald added a project: All. aprantl requested review of this revision. This patch adds a new page to the LLDB documentation that documents, among other things the `-gmodules` debug info format. h

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

JDevlieghere added a comment. You'll need to add this to the index.rst page. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133519/new/ https://reviews.llvm.org/D133519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

aprantl updated this revision to Diff 458839. aprantl added a comment. Herald added a subscriber: arphaman. Wire up the ToC CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133519/new/ https://reviews.llvm.org/D133519 Files: lldb/docs/index.rst lldb/docs/use/extensions.rst Index: lld

[Lldb-commits] [lldb] 47b7663 - [lldb] Use std::size instead of llvm::array_lengthof

Author: Joe Loser Date: 2022-09-08T14:21:55-06:00 New Revision: 47b76631e76810bfc6d91d534dc1b095e8058ff4 URL: https://github.com/llvm/llvm-project/commit/47b76631e76810bfc6d91d534dc1b095e8058ff4 DIFF: https://github.com/llvm/llvm-project/commit/47b76631e76810bfc6d91d534dc1b095e8058ff4.diff LOG

[Lldb-commits] [PATCH] D133501: [lldb] Use std::size instead of llvm::array_lengthof

This revision was automatically updated to reflect the committed changes. Closed by commit rG47b76631e768: [lldb] Use std::size instead of llvm::array_lengthof (authored by jloser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133501/new/ https://r

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

JDevlieghere added a comment. Content looks good to me, but I'll hold off on accepting the review until the others have had a chance to see this in their review queue. Comment at: lldb/docs/use/extensions.rst:72 + +:: + DW_TAG_compile_unit Missing newline (i

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

ronlieb added a comment. i am seeing similar issues in openmp buildbot failing with this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 ___ lldb-commits

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. In D111509#3778277 , @ronlieb wrote: > i am seeing similar issues in openmp buildbot failing with this patch I got a small patch coming up soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D133461: [LLDB][NativePDB] Set block address range.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133461/new/ https://reviews.llvm.org/D133461 ___ lldb-

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. Fix at https://reviews.llvm.org/D133522 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D133525: fix extra bytes when compressing for 32bit objcopy

ckissane created this revision. ckissane added a reviewer: MaskRay. Herald added subscribers: StephenFan, abrachet, hiraditya, mgorny, emaste. Herald added a reviewer: jhenderson. Herald added a project: All. ckissane requested review of this revision. Herald added projects: LLDB, LLVM. Herald adde

[Lldb-commits] [PATCH] D133525: fix extra bytes when compressing for 32bit objcopy, and add zstd support to Decompressor

ckissane updated this revision to Diff 458871. ckissane added a comment. - fix extra bytes when compressing for 32bit objcopy - fix lldb compressed section zstd test File Size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133525/new/ https://review

[Lldb-commits] [PATCH] D133525: fix extra bytes when compressing for 32bit objcopy, and add zstd support to Decompressor

ckissane updated this revision to Diff 458875. ckissane added a comment. - remove lldb changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133525/new/ https://reviews.llvm.org/D133525 Files: llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp llvm/lib/ObjCo

[Lldb-commits] [PATCH] D133530: add zstd support for lldb

ckissane created this revision. ckissane added reviewers: MaskRay, phosek. Herald added subscribers: StephenFan, hiraditya, mgorny, emaste. Herald added a project: All. ckissane requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commit

[Lldb-commits] [PATCH] D133461: [LLDB][NativePDB] Set block address range.

This revision was automatically updated to reflect the committed changes. Closed by commit rG32530e0493c1: [LLDB][NativePDB] Set block address range. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133461/new/ https://reviews.l

[Lldb-commits] [lldb] 32530e0 - [LLDB][NativePDB] Set block address range.

Author: Zequan Wu Date: 2022-09-08T14:51:47-07:00 New Revision: 32530e0493c130229b8fe5e4e65abd7fe76a2dc4 URL: https://github.com/llvm/llvm-project/commit/32530e0493c130229b8fe5e4e65abd7fe76a2dc4 DIFF: https://github.com/llvm/llvm-project/commit/32530e0493c130229b8fe5e4e65abd7fe76a2dc4.diff LOG

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda created this revision. jasonmolenda added reviewers: JDevlieghere, jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. In an internal devel

[Lldb-commits] [PATCH] D133164: Add the ability to show when variables fails to be available when debug info is valid.

clayborg updated this revision to Diff 458912. clayborg added a comment. Herald added a reviewer: sscalpone. - Don't check for compiler arguments directly, look at all DIEs for a compile unit and return an error if there are no variable DIEs in any DIEs in each compile unit. - Use "assertIn(a, b

[Lldb-commits] [PATCH] D133164: Add the ability to show when variables fails to be available when debug info is valid.

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4161 + if (command) { +if (command->contains(" -gline-tables-only")) + return Status("-gline-tables-only enabled, no variable information is " labath wr

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jingham added a comment. So far just a bunch of random comments... Comment at: lldb/include/lldb/Target/Platform.h:1055 + /// Given an address of a binary, the platform may be able to + /// set the correct DynamicLoader plugin that should be used for Are th

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

MaskRay added a comment. Since the fix was not merged, I will revert this soon. I saw a clang segfault with `clang++ libstdc++-v3/src/c++98/complex_io.cc` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. In D111509#3778879 , @MaskRay wrote: > Since the fix was not merged, I will revert this soon. > > I saw a clang segfault with `clang++ libstdc++-v3/src/c++98/complex_io.cc` Would you mind if I just merge it? I was hoping there w

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

MaskRay added a comment. In D111509#3778882 , @mizvekov wrote: > In D111509#3778879 , @MaskRay wrote: > >> Since the fix was not merged, I will revert this soon. >> >> I saw a clang segfault with `clang++ libstdc+

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 458924. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting()/GetSettings() public APIs

hawkinsw added inline comments. Comment at: lldb/test/API/functionalities/source-map/TestTargetSourceMap.py:25 +src_dir = self.getSourceDir() +self.runCmd('settings set target.source-map . "%s"' % src_dir) + Sorry if this comment is not helpful, b

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting()/GetSettings() public APIs

yinghuitan updated this revision to Diff 458932. yinghuitan marked 11 inline comments as done. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files:

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

yinghuitan marked an inline comment as done. yinghuitan added a comment. @jingham , @clayborg, thanks for the feedback. Seems like the major concern is creating a general GetSettings() API instead of API for each setting. I like and agree with this idea. Per the reading, Comm

[Lldb-commits] [PATCH] D133546: [lldb][fuzz] Allow expression fuzzer to be passed as a flag.

rupprecht created this revision. rupprecht added reviewers: cassanova, JDevlieghere, mib. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The expression fuzzer checks an environment variable, `LLDB_FUZ

[Lldb-commits] [PATCH] D133525: fix extra bytes when compressing for 32bit objcopy

phosek added a comment. Would it be possible to write a test that covers this case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133525/new/ https://reviews.llvm.org/D133525 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D133530: [lldb] Add zstd support

MaskRay added inline comments. Comment at: lldb/test/Shell/ObjectFile/ELF/compressed-sections-zstd.yaml:19 +Content: deadbeefbaadf00d +## The legacy .zdebug format is not supported. + - Name:.zdebug_info Delete `.zdebug`. It is unrelated

[Lldb-commits] [PATCH] D133525: fix extra bytes when compressing for 32bit objcopy

MaskRay added a comment. See `test/tools/llvm-objcopy/ELF/compress-debug-sections-zstd.test`. Use a similar file for ELFCLASS32 which runs `llvm-objcopy --compress-debug-sections=zstd` then `llvm-objcopy --decompress-debug-sections`. Then compare the output with the original with just one `ll

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

hawkinsw added inline comments. Comment at: lldb/test/API/functionalities/source-map/TestTargetSourceMap.py:25 +src_dir = self.getSourceDir() +self.runCmd('settings set target.source-map . "%s"' % src_dir) + yinghuitan wrote: > hawkinsw wrote: > >

[Lldb-commits] [PATCH] D133525: fix extra bytes when compressing for 32bit objcopy

MaskRay added inline comments. Comment at: llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp:509 + const ElfType OutputElfType = + getOutputElfType(Config.OutputArch.value_or(MachineInfo())); + const bool Is64Bit = This is incorrect. Config.OutputArch is usually unset (

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda marked an inline comment as done. jasonmolenda added a comment. Thanks Jim! Really helpful feedback and questions. Comment at: lldb/source/Core/DynamicLoader.cpp:191 ModuleSP module_sp; PlatformSP platform_sp = process->GetTarget().GetPlatform(); Target &

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/API/SBDebugger.h:119 + /// Get all settings into SBStructuredData. + lldb::SBStructuredData GetSetting(); +