[Lldb-commits] [PATCH] D129487: [lldb][AArch64] Add UnpackTagsFromCoreFileSegment to MemoryTagManager

DavidSpickett updated this revision to Diff 446099. DavidSpickett added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129487/new/ https://reviews.llvm.org/D129487 Files: lldb/include/lldb/Target/MemoryTagManager.h lldb/source

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

DavidSpickett updated this revision to Diff 446100. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129489/new/ https://reviews.llvm.org/D129489 Files: lldb/incl

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. @JDevlieghere @teemperor ping Can you please verify that everything works with LLDB, we just changed how those types are printed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

DavidSpickett added a comment. > You mean "memory read --show-tags"? The details > are tested on live processes already but a simple smoke test wouldn't hurt, > I'll do that. I checked and to include the memory contents takes the core file from 20k to 300 something k. This isn't the end of th

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

sammccall added a comment. In D112374#3657640 , @mizvekov wrote: > In general, I would not expect external tools to care about the shape of the > AST. I would expect the type API would be used in a way where we ignore a > type sugar node we have no reas

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

jj10306 requested changes to this revision. jj10306 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:288 +decoded_thread.NotifyTsc(execution.thread_execution.GetLowestKnownTSC()); decoded_thread.NotifyCPU(execution.thread_executio

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 446173. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-include-fixer/f

[Lldb-commits] [lldb] 360c111 - Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2022-07-20T09:09:19-07:00 New Revision: 360ce358c4c7e8591953ce9548d60c9410a6 URL: https://github.com/llvm/llvm-project/commit/360ce358c4c7e8591953ce9548d60c9410a6 DIFF: https://github.com/llvm/llvm-project/commit/360ce358c4c7e8591953ce9548d60c9410a6.diff L

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3665249 , @sammccall wrote: > I've seen plenty of (useful) out-of-tree tidy checks written by people fuzzy > on the difference between a Type and a TypeLoc, or what sugar is. Clang makes > it (almost) easy to write t

[Lldb-commits] [PATCH] D130098: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan

JDevlieghere accepted this revision. JDevlieghere added a comment. The changes themselves look good, but please undo the formatting/unrelated changes before landing this. When I've been in a situation like this where I accidentally formatted unrelated things, I usually unstage my changes and use

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

Michael137 added a comment. This seems to cause issues when `var->getType() == const llvm::APFloatBase::roundingMode`. Triggered assertion `Assertion failed: (type->isIntegerType() && "Illegal type in IntegerLiteral"), function IntegerLiteral, file Expr.cpp, line 892` when doing the following:

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

JDevlieghere added a comment. In D112374#3665989 , @mizvekov wrote: > If anyone wants to take a look at the new changes to lldb tests, be my guest. > Otherwise I will try to land this again soon. It might well be that we figure > out some other in-tree

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

teemperor added a comment. import-std-module test changes look good to me, thanks for fixing that up. And yes, ideally the tests should never use any libc++ internal names (and LLDB should never print them for those tests). So I think not having those in the here is a step in the right directio

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

kimgr added a comment. From a purely personal perspective, I'd prefer if this landed after the branch for llvm-15. We try to co-release IWYU shortly after LLVM/Clang are released, to get a public API-compatible release out there. So it would be really nice if we didn't have to spend time worki

[Lldb-commits] [PATCH] D130045: Implement better path matching in FileSpecList::FindFileIndex(...).

JDevlieghere added a comment. The relative/absolute caching seems like a nice improvement. Splitting it into a separate patch would make it easier to review. I'm slightly worried about the change to make the new "fuzzy" matching the default. While it makes sense for the breakpoints, I wouldn't

[Lldb-commits] [PATCH] D130098: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan

fixathon updated this revision to Diff 446262. fixathon added a comment. Remove formatting for unrelated lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130098/new/ https://reviews.llvm.org/D130098 Files: lldb/include/lldb/Core/EmulateInstru

[Lldb-commits] [PATCH] D130098: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan

fixathon marked 3 inline comments as done. fixathon added a comment. Address the comments: revert the formatting for lines unrelated to my changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130098/new/ https://reviews.llvm.org/D130098 _

[Lldb-commits] [PATCH] D130045: Implement better path matching in FileSpecList::FindFileIndex(...).

clayborg added a comment. sounds good, I will split out the caching into a separate patch. I will try to use the llvm::Optional as long as it doesn't increase the size of FileSpec which is currently at 24 bytes. I will also split out the file index matching into a new function that allows rela

[Lldb-commits] [PATCH] D130098: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG459cfa5e94d7: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan (authored by fixathon). Repository:

[Lldb-commits] [lldb] 459cfa5 - [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan

Author: Slava Gurevich Date: 2022-07-20T14:50:48-07:00 New Revision: 459cfa5e94d75b08aa421b79765ba1cd2126c4a4 URL: https://github.com/llvm/llvm-project/commit/459cfa5e94d75b08aa421b79765ba1cd2126c4a4 DIFF: https://github.com/llvm/llvm-project/commit/459cfa5e94d75b08aa421b79765ba1cd2126c4a4.diff

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace updated this revision to Diff 446281. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130054/new/ https://reviews.llvm.org/D130054 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb/Target/TraceDum

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace updated this revision to Diff 446303. wallace edited the summary of this revision. wallace added a comment. final version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130054/new/ https://reviews.llvm.org/D130054 Files: lldb/include/lldb

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix evaluation of types with constant initialized enum typedefs

Michael137 created this revision. Michael137 added reviewers: aprantl, jingham, werat, labath. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `IntegerLiteral::Create` expects integer types. For that

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix evaluation of types with constant initialized enum typedefs

Michael137 updated this revision to Diff 446305. Michael137 added a comment. - Remove redundant header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130213/new/ https://reviews.llvm.org/D130213 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSys

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace updated this revision to Diff 446306. wallace added a comment. fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130054/new/ https://reviews.llvm.org/D130054 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb/Target/T

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

Michael137 added a comment. Doing this instead: if (const EnumType *enum_type = llvm::dyn_cast(qt.getTypePtr()->getUnqualifiedDesugaredType())) { resolves the crash, though unclear if that's the right thing to do In D81471#3666071 , @Michael137 wrote:

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:288 +decoded_thread.NotifyTsc(execution.thread_execution.GetLowestKnownTSC()); decoded_thread.NotifyCPU(execution.thread_execution.cpu_id); jj10306 wrote: >

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix evaluation of types with constant initialized enum typedefs

Michael137 updated this revision to Diff 446315. Michael137 added a comment. - Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130213/new/ https://reviews.llvm.org/D130213 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.c

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix evaluation of types with constant initialized enum typedefs

Michael137 updated this revision to Diff 446316. Michael137 added a comment. - Remove drive-by whitespace change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130213/new/ https://reviews.llvm.org/D130213 Files: lldb/source/Plugins/TypeSystem/Cla

[Lldb-commits] [PATCH] D130219: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList

jgorbe created this revision. jgorbe added a reviewer: labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. Extract a bit of copy/pasted regex filtering logic into a separate function and simplify it