[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

2022-07-04 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. Some random comments. Also agree that a test for what happens when there is no header found would be good. Comment at: lldb/test/API/macosx/unregistered-macho/TestUnregisteredMacho.py:21 +self.build() +(target, process, thread, b

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

2022-07-04 Thread Michael Buch via Phabricator via lldb-commits
Michael137 created this revision. Michael137 added reviewers: aprantl, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. This patch adds support for

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

2022-07-04 Thread Michael Buch via Phabricator via lldb-commits
Michael137 added a comment. The is a draft for now, but feel free to comment on the approach. I'm still evaluating some other alternatives to this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 ___

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

2022-07-04 Thread Michael Buch via Phabricator via lldb-commits
Michael137 updated this revision to Diff 442102. Michael137 added a comment. - [LLDB][Expression] Allow instantiation of IR Entity from ValueObject - WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

2022-07-04 Thread Michael Buch via Phabricator via lldb-commits
Michael137 updated this revision to Diff 442104. Michael137 added a comment. Correct email config Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files: lldb/include/lldb/Expression/UserExpression.h l

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

2022-07-04 Thread Michael Buch via Phabricator via lldb-commits
Michael137 planned changes to this revision. Michael137 added a comment. Remove from review queue for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 ___ ll

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

2022-07-04 Thread Andy Yankovsky via Phabricator via lldb-commits
werat updated this revision to Diff 442126. werat added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Rebase on latest HEAD - Address review comments - Add a check for field being integer/enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

2022-07-04 Thread Andy Yankovsky via Phabricator via lldb-commits
werat marked an inline comment as done. werat added a comment. Reviving the patch and taking over. @jankratochvil @shafik @labath can you please take another look? Thanks! Comment at: lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp:172 + // Find the min/max value

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

2022-07-04 Thread Nico Weber via Phabricator via lldb-commits
thakis added a comment. What `--author` flag should I use for you when landing this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126464/new/ https://reviews.llvm.org/D126464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

2022-07-04 Thread Kaining Zhong via Phabricator via lldb-commits
PRESIDENT810 added a comment. In D126464#3628819 , @thakis wrote: > What `--author` flag should I use for you when landing this? Hi! Could you please use --author="Kaining Zhong "? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126464/n