[Lldb-commits] [PATCH] D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath

jingham added a comment. In D127605#3580123 , @kastiglione wrote: >> This is good, but it also illustrates how the strings "->" and ".'" should >> actually come from the typesystem and not be hardcoded. We're just lucky >> that all languages have a "."

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

stella.stamenova added a comment. In D125943#3587778 , @wallace wrote: > @stella.stamenova, I've just tried that compile command with several versions > of gcc, including g++ (GCC) 8.5.0 on CentOS and got no error Sadly I couldn't > install 7.3.1. Could

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

wallace added a comment. Hi @stella.stamenova, could you help fixing that one liner? I really have no way to install gcc7 on my linux machine (I don't have permission to install older gcc toolchains). I'm happy to chat with you on discord or anywhere else to get this resolved. Il giorno gio 16 gi

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, jingham, kastiglione. Herald added a project: All. JDevlieghere requested review of this revision. This patch adds a buffer logging mode to lldb. It can be enabled with `log buffered enable`, which enables logging

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

JDevlieghere added a comment. Adding a test is trivial, but I'm holding off on spending time on that until there's consensus about the approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127986/new/ https://reviews.llvm.org/D127986 ___ l

[Lldb-commits] [PATCH] D127922: [lldb] Introduce the concept of a log handler (NFC)

clayborg added inline comments. Comment at: lldb/source/Utility/Log.cpp:323-324 if (options.Test(LLDB_LOG_OPTION_THREADSAFE)) { static std::recursive_mutex g_LogThreadedMutex; std::lock_guard guard(g_LogThreadedMutex); +handler_sp->Emit(message);

[Lldb-commits] [PATCH] D127922: [lldb] Introduce the concept of a log handler (NFC)

JDevlieghere marked 3 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Utility/Log.cpp:323-324 if (options.Test(LLDB_LOG_OPTION_THREADSAFE)) { static std::recursive_mutex g_LogThreadedMutex; std::lock_guard guard(g_LogThreadedMutex

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

clayborg added a comment. I would vote to add new options to "log enable" and enable any such features on a per "log enable" invocation if possible? Otherwise each time you want to enable this you need to do two commands, and if someone already enables buffered mode, then you wouldn't be able t

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

clayborg added a comment. Something like: (lldb) log enable --buffered 10 lldb process state thread step If we do this, then we need to be able to specify which buffers to dump somehow. In case someone did: (lldb) log enable --buffered 10 lldb ... (lldb) log enable --buffered 100

[Lldb-commits] [PATCH] D127922: [lldb] Introduce the concept of a log handler (NFC)

mib added inline comments. Comment at: lldb/source/Utility/Log.cpp:325 std::lock_guard guard(g_LogThreadedMutex); -*stream_sp << message; -stream_sp->flush(); +handler_sp->Emit(message); +handler_sp->Flush(); JDevlieghere wrote: > clayborg wr

[Lldb-commits] [PATCH] D127922: [lldb] Introduce the concept of a log handler (NFC)

clayborg added inline comments. Comment at: lldb/source/Utility/Log.cpp:325 std::lock_guard guard(g_LogThreadedMutex); -*stream_sp << message; -stream_sp->flush(); +handler_sp->Emit(message); +handler_sp->Flush(); mib wrote: > JDevlieghere wr

[Lldb-commits] [PATCH] D127937: [lldb] Add RotatingLogHandler

kastiglione added inline comments. Comment at: lldb/include/lldb/Utility/Log.h:98 + + std::vector m_messages; + size_t m_next_index = 0; this could be an array, since it's not being dynamically resized. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[Lldb-commits] [PATCH] D127922: [lldb] Introduce the concept of a log handler (NFC)

JDevlieghere updated this revision to Diff 437618. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. - Make Emit take a StringRef - Move mutex in the log handler CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127922/new/ https://reviews.llvm.org/D127922 Files:

[Lldb-commits] [lldb] 1a3f996 - [trace][intelpt] Support system-wide tracing [13] - Add context switch decoding

Author: Walter Erquinigo Date: 2022-06-16T11:23:01-07:00 New Revision: 1a3f996972b175a6f7e4db1eabb8310e2e93f634 URL: https://github.com/llvm/llvm-project/commit/1a3f996972b175a6f7e4db1eabb8310e2e93f634 DIFF: https://github.com/llvm/llvm-project/commit/1a3f996972b175a6f7e4db1eabb8310e2e93f634.di

[Lldb-commits] [lldb] a19fcc2 - [trace][intelpt] Support system-wide tracing [14] - Decode per cpu

Author: Walter Erquinigo Date: 2022-06-16T11:23:01-07:00 New Revision: a19fcc2bec81989f90700cfc63b89a0dfd330197 URL: https://github.com/llvm/llvm-project/commit/a19fcc2bec81989f90700cfc63b89a0dfd330197 DIFF: https://github.com/llvm/llvm-project/commit/a19fcc2bec81989f90700cfc63b89a0dfd330197.di

[Lldb-commits] [lldb] ef99707 - [trace][intelpt] Support system-wide tracing [15] - Make triple optional

Author: Walter Erquinigo Date: 2022-06-16T11:23:01-07:00 New Revision: ef9970759b5b63fed40061cd960e6d9e8edabb48 URL: https://github.com/llvm/llvm-project/commit/ef9970759b5b63fed40061cd960e6d9e8edabb48 DIFF: https://github.com/llvm/llvm-project/commit/ef9970759b5b63fed40061cd960e6d9e8edabb48.di

[Lldb-commits] [PATCH] D126267: [trace][intelpt] Support system-wide tracing [13] - Add context switch decoding

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a3f996972b1: [trace][intelpt] Support system-wide tracing [13] - Add context switch decoding (authored by Walter Erquinigo ). Repo

[Lldb-commits] [lldb] ff15efc - [trace][intelpt] Support system-wide tracing [16] - Create threads automatically from context switch data in the post-mortem case

Author: Walter Erquinigo Date: 2022-06-16T11:23:02-07:00 New Revision: ff15efc1a701a8e76242ca2a105b5adf7d68e980 URL: https://github.com/llvm/llvm-project/commit/ff15efc1a701a8e76242ca2a105b5adf7d68e980 DIFF: https://github.com/llvm/llvm-project/commit/ff15efc1a701a8e76242ca2a105b5adf7d68e980.di

[Lldb-commits] [PATCH] D126394: [trace][intelpt] Support system-wide tracing [14] - Decode per cpu

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa19fcc2bec81: [trace][intelpt] Support system-wide tracing [14] - Decode per cpu (authored by Walter Erquinigo ). Changed prior to c

[Lldb-commits] [lldb] 03cc58f - [trace][intelpt] Support system-wide tracing [17] - Some improvements

Author: Walter Erquinigo Date: 2022-06-16T11:23:02-07:00 New Revision: 03cc58ff2a7a88b4eb8c1409169b662b46ec85d9 URL: https://github.com/llvm/llvm-project/commit/03cc58ff2a7a88b4eb8c1409169b662b46ec85d9 DIFF: https://github.com/llvm/llvm-project/commit/03cc58ff2a7a88b4eb8c1409169b662b46ec85d9.di

[Lldb-commits] [PATCH] D126990: [trace][intelpt] Support system-wide tracing [15] - Make triple optional

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef9970759b5b: [trace][intelpt] Support system-wide tracing [15] - Make triple optional (authored by Walter Erquinigo ). Herald added

[Lldb-commits] [PATCH] D127001: [trace][intelpt] Support system-wide tracing [16] - Create threads automatically from context switch data in the post-mortem case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff15efc1a701: [trace][intelpt] Support system-wide tracing [16] - Create threads… (authored by Walter Erquinigo ). Repository: rG

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03cc58ff2a7a: [trace][intelpt] Support system-wide tracing [17] - Some improvements (authored by Walter Erquinigo ). Repository: r

[Lldb-commits] [PATCH] D127922: [lldb] Introduce the concept of a log handler (NFC)

clayborg added inline comments. Comment at: lldb/include/lldb/Utility/Log.h:54 + virtual void Flush() = 0; + std::mutex &GetMutex() { return m_mutex; } + Maybe we don't expose this mutex at all and we have a EmitThreadSafe(...) method?: ``` void EmitThreadSafe

[Lldb-commits] [PATCH] D127997: Remember whether all owners of the site we hit were internal in StopInfoBreakpoint

jingham created this revision. jingham added reviewers: JDevlieghere, jasonmolenda. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We noticed several test suite failures (e.g. TestStopAtEntry.py) with t

[Lldb-commits] [PATCH] D127997: Remember whether all owners of the site we hit were internal in StopInfoBreakpoint

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Neat! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127997/new/ https://reviews.llvm.org/D127997 __

[Lldb-commits] [lldb] 561a61f - [trace][intelpt] Support system-wide tracing [18] - some more improvements

Author: Walter Erquinigo Date: 2022-06-16T11:42:21-07:00 New Revision: 561a61fb261bd3642f3c6187cf9c334502cac17f URL: https://github.com/llvm/llvm-project/commit/561a61fb261bd3642f3c6187cf9c334502cac17f DIFF: https://github.com/llvm/llvm-project/commit/561a61fb261bd3642f3c6187cf9c334502cac17f.di

[Lldb-commits] [PATCH] D127752: [trace][intelpt] Support system-wide tracing [18] - some more improvements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG561a61fb261b: [trace][intelpt] Support system-wide tracing [18] - some more improvements (authored by Walter Erquinigo ). Changed p

[Lldb-commits] [lldb] 67c2405 - [trace][intelpt] Support system-wide tracing [19] - Some other minor improvements

Author: Walter Erquinigo Date: 2022-06-16T11:42:21-07:00 New Revision: 67c24051450116c2c633e8a2740c08cf904e1605 URL: https://github.com/llvm/llvm-project/commit/67c24051450116c2c633e8a2740c08cf904e1605 DIFF: https://github.com/llvm/llvm-project/commit/67c24051450116c2c633e8a2740c08cf904e1605.di

[Lldb-commits] [PATCH] D127804: [trace][intelpt] Support system-wide tracing [19] - Some other minor improvements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67c240514501: [trace][intelpt] Support system-wide tracing [19] - Some other minor… (authored by Walter Erquinigo ). Repository: r

[Lldb-commits] [lldb] ea37cd5 - [trace][intelpt] Support system-wide tracing [22] - Some final touches

Author: Walter Erquinigo Date: 2022-06-16T11:42:22-07:00 New Revision: ea37cd52d147a5ee621418e65db93a3e6102ab89 URL: https://github.com/llvm/llvm-project/commit/ea37cd52d147a5ee621418e65db93a3e6102ab89 DIFF: https://github.com/llvm/llvm-project/commit/ea37cd52d147a5ee621418e65db93a3e6102ab89.di

[Lldb-commits] [lldb] 9f45f23 - [trace][intelpt] Support system-wide tracing [21] - Support long numbers in JSON

Author: Walter Erquinigo Date: 2022-06-16T11:42:22-07:00 New Revision: 9f45f23d860251edceed6128110855c51af4f39f URL: https://github.com/llvm/llvm-project/commit/9f45f23d860251edceed6128110855c51af4f39f DIFF: https://github.com/llvm/llvm-project/commit/9f45f23d860251edceed6128110855c51af4f39f.di

[Lldb-commits] [PATCH] D127819: [trace][intelpt] Support system-wide tracing [21] - Support long numbers in JSON

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f45f23d8602: [trace][intelpt] Support system-wide tracing [21] - Support long numbers in JSON (authored by Walter Erquinigo ). Rep

[Lldb-commits] [PATCH] D127881: [trace][intelpt] Support system-wide tracing [22] - Some final touches

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea37cd52d147: [trace][intelpt] Support system-wide tracing [22] - Some final touches (authored by Walter Erquinigo ). Changed prior

[Lldb-commits] [PATCH] D127997: Remember whether all owners of the site we hit were internal in StopInfoBreakpoint

jasonmolenda added a comment. Thanks for getting to the bottom of this one! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127997/new/ https://reviews.llvm.org/D127997 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D127922: [lldb] Introduce the concept of a log handler (NFC)

JDevlieghere updated this revision to Diff 437651. JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. - Add `EmitThreadSafe` - Remove `Flush` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127922/new/ https://reviews.llvm.org/D127922 Files: lldb/include/lldb/

[Lldb-commits] [lldb] dae2faf - Fix TraceGDBRemotePacketsTest

Author: Walter Erquinigo Date: 2022-06-16T11:53:13-07:00 New Revision: dae2fafe056c83a802c1f1a1baa3cd48416c06f7 URL: https://github.com/llvm/llvm-project/commit/dae2fafe056c83a802c1f1a1baa3cd48416c06f7 DIFF: https://github.com/llvm/llvm-project/commit/dae2fafe056c83a802c1f1a1baa3cd48416c06f7.di

[Lldb-commits] [lldb] f22db1f - Fix StopInfoBreakpoint::ShouldNotify when a callback deletes the site we hit.

Author: Jim Ingham Date: 2022-06-16T11:54:11-07:00 New Revision: f22db1fabfa165e9b18b1b49c78566d15f22bda1 URL: https://github.com/llvm/llvm-project/commit/f22db1fabfa165e9b18b1b49c78566d15f22bda1 DIFF: https://github.com/llvm/llvm-project/commit/f22db1fabfa165e9b18b1b49c78566d15f22bda1.diff LO

[Lldb-commits] [PATCH] D127997: Remember whether all owners of the site we hit were internal in StopInfoBreakpoint

This revision was automatically updated to reflect the committed changes. Closed by commit rGf22db1fabfa1: Fix StopInfoBreakpoint::ShouldNotify when a callback deletes the site we hit. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

mdaniels created this revision. mdaniels added reviewers: jingham, clayborg, labath. Herald added a project: All. mdaniels requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The DynamicLoaderPOSIXDYLD::GetStepThroughTrampolinePlan() function w

[Lldb-commits] [PATCH] D127922: [lldb] Introduce the concept of a log handler (NFC)

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127922/new/ https://reviews.llvm.org/D127922 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

clayborg added a comment. Is there a test that was failing with this? If not can we add one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999 ___ lldb-commits ma

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

clayborg added a comment. I could also imagine having multiple options. For example --buffered would specify to buffer the output and only flush if we go over bytes. This could improve logging speeds. --circular would enable circular buffering where things are never flushed unless manually

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

JDevlieghere updated this revision to Diff 437679. JDevlieghere added a comment. Implement Greg's suggestion of integrating this with `log enable`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127986/new/ https://reviews.llvm.org/D127986 Files: lldb/include/lldb/Core/Debugger.h ll

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

clayborg added a comment. The main questions is if we want --buffered for any log channel (file, callback, or circular). If we add a --circular flag, then we just let things accumulate in the LogHandler class. The idea would be to add more stuff to the LogHandler base class to support this: c

[Lldb-commits] [lldb] 6ff49af - [lldb] Introduce the concept of a log handler (NFC)

Author: Jonas Devlieghere Date: 2022-06-16T13:34:28-07:00 New Revision: 6ff49af33d093dd7e0659958185942d0d26a8b90 URL: https://github.com/llvm/llvm-project/commit/6ff49af33d093dd7e0659958185942d0d26a8b90 DIFF: https://github.com/llvm/llvm-project/commit/6ff49af33d093dd7e0659958185942d0d26a8b90.d

[Lldb-commits] [PATCH] D127922: [lldb] Introduce the concept of a log handler (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ff49af33d09: [lldb] Introduce the concept of a log handler (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D127922?vs=437651&id=437686#

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

clayborg added a comment. For this idea to work we would need to change the Emit() function to be DoEmit(...), then add logic to LogHandler: void LogHandler::Emit(StringRef message) { if (m_circular) { // Fill buffer in circular fashion return; } if (m_buffer_size > 0)

[Lldb-commits] [PATCH] D127937: [lldb] Add RotatingLogHandler

JDevlieghere updated this revision to Diff 437695. JDevlieghere added a comment. - Use dynamic array instead of vector. - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127937/new/ https://reviews.llvm.org/D127937 Files: lldb/include/lldb/Utility/Log.h lldb/source/Utility/Log

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

JDevlieghere added a comment. In D127986#3590157 , @clayborg wrote: > The main questions is if we want --buffered for any log channel (file, > callback, or circular). If we add a --circular flag, then we just let things > accumulate in the LogHandler cl

[Lldb-commits] [PATCH] D127937: [lldb] Add RotatingLogHandler

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. lgtm Comment at: lldb/unittests/Utility/LogTest.cpp:112 + handler.Dump(stream); + return stream.str(); +} minor: `return buffer;` CHANGES SINCE

[Lldb-commits] [PATCH] D127937: [lldb] Add RotatingLogHandler

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/unittests/Utility/LogTest.cpp:112 + handler.Dump(stream); + return stream.str(); +} kastiglione wrote: > minor: `return buffer;` I did that on purpose to avoid t

[Lldb-commits] [lldb] 663612d - [lldb] Remove references to epydoc from the documentation

Author: Jonas Devlieghere Date: 2022-06-16T15:17:40-07:00 New Revision: 663612dfd8f63e82936f32755fbba2aa219a7ae0 URL: https://github.com/llvm/llvm-project/commit/663612dfd8f63e82936f32755fbba2aa219a7ae0 DIFF: https://github.com/llvm/llvm-project/commit/663612dfd8f63e82936f32755fbba2aa219a7ae0.d

[Lldb-commits] [lldb] 6ac608b - [lldb] Add RotatingLogHandler

Author: Jonas Devlieghere Date: 2022-06-16T15:17:40-07:00 New Revision: 6ac608b3d897502c987e02667e87315c5fe0e90f URL: https://github.com/llvm/llvm-project/commit/6ac608b3d897502c987e02667e87315c5fe0e90f DIFF: https://github.com/llvm/llvm-project/commit/6ac608b3d897502c987e02667e87315c5fe0e90f.d

[Lldb-commits] [PATCH] D127937: [lldb] Add RotatingLogHandler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG6ac608b3d897: [lldb] Add RotatingLogHandler (authored by JDevlieghere). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

mdaniels updated this revision to Diff 437741. mdaniels added a comment. Added a simple test case that reproduces the issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOS

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

clayborg added a comment. The delegate idea is fine too! No need to overload the base class with extra stuff if not needed. I would just like there to be no predispositions on the kinds of logs that can be used when buffering is enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

clayborg added a comment. LGTM, just a question if we want to restrict this test to linux only. Comment at: lldb/test/API/lang/cpp/step-into-namespace/TestStepIntoNamespace.py:8 + +def test(self): +self.build() Do we want to limit this to linux? I

[Lldb-commits] [lldb] af6ec92 - [lldb] Cleanup Python API reference files after building the docs

Author: Jonas Devlieghere Date: 2022-06-16T16:30:49-07:00 New Revision: af6ec9200b09039573d85e349496c4f5b17c3d7f URL: https://github.com/llvm/llvm-project/commit/af6ec9200b09039573d85e349496c4f5b17c3d7f DIFF: https://github.com/llvm/llvm-project/commit/af6ec9200b09039573d85e349496c4f5b17c3d7f.d

[Lldb-commits] [PATCH] D128026: [lldb] Add a BufferedLogHandler

JDevlieghere created this revision. JDevlieghere added a reviewer: clayborg. Herald added a project: All. JDevlieghere requested review of this revision. Add a BufferedLogHandler as requested by Greg in D127986 . https://reviews.llvm.org/D128026 Files: lldb/

[Lldb-commits] [PATCH] D128026: [lldb] Add a BufferedLogHandler

JDevlieghere updated this revision to Diff 437784. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128026/new/ https://reviews.llvm.org/D128026 Files: lldb/include/lldb/Utility/Log.h lldb/source/Utility/Log.cpp lldb/unittests/Utility/LogTest.cpp Index: lldb/unittests/Utility/LogTes

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

JDevlieghere updated this revision to Diff 437786. JDevlieghere added a comment. Generalize support for buffering. You can see it in action below: (lldb) log enable -b 10 lldb default (lldb) target create ./bin/count Current executable set to '/Users/jonas/llvm/build-ra/bin/count' (arm64).

[Lldb-commits] [lldb] de74756 - [lldb] Remove LogHandler::Create functions (NFC)

Author: Jonas Devlieghere Date: 2022-06-16T21:04:08-07:00 New Revision: de7475657156658d16704e956a17a39709de2fdd URL: https://github.com/llvm/llvm-project/commit/de7475657156658d16704e956a17a39709de2fdd DIFF: https://github.com/llvm/llvm-project/commit/de7475657156658d16704e956a17a39709de2fdd.d

[Lldb-commits] [PATCH] D128026: [lldb] Add a BufferedLogHandler

JDevlieghere updated this revision to Diff 437788. JDevlieghere added a comment. Flush on destruction CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128026/new/ https://reviews.llvm.org/D128026 Files: lldb/include/lldb/Utility/Log.h lldb/source/Utility/Log.cpp lldb/unittests/Utili