[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

labath added a comment. Is there any difference in functionality between SymbolVendorELF and the new class introduced here? Could this have been achieved by teaching SymbolVendorELF (after renaming it to something else) to handle COFF files as well? Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D126015: [trace][intelpt] Support system-wide tracing [12] - Support multi-core trace load and save

wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:520 + /// core id -> data kind -> size + llvm::DenseMap> + m_live_core_data; jj10306 wrote: > Would this work instead? I noticed that the several other maps around this > code als

[Lldb-commits] [lldb] cf2c8e4 - [lldb] Fix TestDyldExecLinux with xml enabled

Author: Pavel Labath Date: 2022-06-14T11:44:59+02:00 New Revision: cf2c8e419dbc6575f82b8ac44b62a2306624899a URL: https://github.com/llvm/llvm-project/commit/cf2c8e419dbc6575f82b8ac44b62a2306624899a DIFF: https://github.com/llvm/llvm-project/commit/cf2c8e419dbc6575f82b8ac44b62a2306624899a.diff

[Lldb-commits] [PATCH] D127752: [trace][intelpt] Support system-wide tracing [18] - some more improvements

wallace created this revision. wallace added a reviewer: jj10306. Herald added subscribers: jsji, pengfei. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This applies the changes requested for diff 12.

[Lldb-commits] [PATCH] D127755: [lldb] Add test for resuming via c in multiprocess scenarios

mgorny created this revision. mgorny added reviewers: labath, jingham, emaste, krytarowski. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Add a test verifying that it is possible to resume a single process via the `c` packet when mul

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added inline comments. Herald added a subscriber: Michael137. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_logpoints.py:60 +[loop_line, after_loop_line], +[{'logMessage': logMessage}, {}] +) claybor

[Lldb-commits] [PATCH] D127755: [lldb] Add test for resuming via c in multiprocess scenarios

mgorny updated this revision to Diff 436869. mgorny added a comment. Rename the helper function to future-proof it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127755/new/ https://reviews.llvm.org/D127755 Files: lldb/test/API/tools/lldb-server/TestGdbRemoteFork.py lldb/test/API/t

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. Herald added a subscriber: Michael137. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50304/new/ https://reviews.llvm.org/D50304 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

RamNalamothu added a comment. Herald added a subscriber: Michael137. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48865/new/ https://reviews.llvm.org/D48865 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

clayborg added a comment. I would like to get to one array solution of LogMessagePart entries and avoid having two arrays of strings that need to stay in sync (rawTextMessages and evalExpressions). Simpler to understand and no need to document the interdependence of rawTextMessages and evalExpr

[Lldb-commits] [PATCH] D126394: [trace][intelpt] Support system-wide tracing [14] - Decode per cpu

wallace added inline comments. Herald added a subscriber: Michael137. Comment at: lldb/include/lldb/Utility/TraceIntelPTGDBRemotePackets.h:83-85 + uint64_t ToNanos(uint64_t tsc) const; + uint64_t ToTSC(uint64_t nanos) const; jj10306 wrote: > why get rid of ch

[Lldb-commits] [PATCH] D127001: [trace][intelpt] Support system-wide tracing [16] - Create threads automatically from context switch data in the post-mortem case

wallace added inline comments. Herald added a subscriber: Michael137. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTSessionFileParser.cpp:167-170 + // A list of known threads for the given process. When context switch + // data is provided, LLDB wi

[Lldb-commits] [PATCH] D127804: [trace][intelpt] Support system-wide tracing [19] - Some other minor improvements

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This addresses the issues in diffs [13], [14] and [16] - Add better documentation - Fix

[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

jingham accepted this revision. jingham added a comment. Sorry, I missed the "ping" notification. Still LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48865/new/ https://reviews.llvm.org/D48865 ___

[Lldb-commits] [PATCH] D127819: [trace][intelpt] Support system-wide tracing [21] - Support long numbers in JSON

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. llvm's JSON parser supports 64 bit integers, but other tools like the ones written in JS

[Lldb-commits] [lldb] ab7fcf2 - [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

Author: Venkata Ramanaiah Nalamothu Date: 2022-06-15T08:52:29+05:30 New Revision: ab7fcf24849d9365785dc981613e761e388e560d URL: https://github.com/llvm/llvm-project/commit/ab7fcf24849d9365785dc981613e761e388e560d DIFF: https://github.com/llvm/llvm-project/commit/ab7fcf24849d9365785dc981613e761e

[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

This revision was automatically updated to reflect the committed changes. Closed by commit rGab7fcf24849d: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID (authored by RamNalamothu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

PRESIDENT810 added a comment. Herald added a subscriber: Michael137. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126464/new/ https://reviews.llvm.org/D126464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. @jingham looks like you missed to notice this one as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50304/new/ https://reviews.llvm.org/D50304 ___ lldb-commits mailing