[Lldb-commits] [PATCH] D126240: [lldb] Tighten the scope of a couple of locks in DataFormatters.

2022-06-04 Thread Will Hawkins via Phabricator via lldb-commits
hawkinsw added inline comments. Comment at: lldb/source/DataFormatters/FormatManager.cpp:595 + { +std::lock_guard guard(m_language_categories_mutex); +m_language_categories_map[lang_type] = jgorbe wrote: > hawkinsw wrote: > > Forgive me if I am speaking

[Lldb-commits] [PATCH] D126015: [trace][intelpt] Support system-wide tracing [12] - Support multi-core trace load and save

2022-06-04 Thread Jakob Johnson via Phabricator via lldb-commits
jj10306 added a comment. feeback-v3 - completed review Comment at: lldb/docs/use/intel_pt.rst:168 :: { +"type": "intel-pt", Consider adding a section on the perfTscConversion parameters while we're editing this file as I don't currently see that in thi

[Lldb-commits] [lldb] 4969a69 - Use llvm::less_first (NFC)

2022-06-04 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2022-06-04T21:23:18-07:00 New Revision: 4969a6924dc1644d4fa6cf89a33b598e647f5513 URL: https://github.com/llvm/llvm-project/commit/4969a6924dc1644d4fa6cf89a33b598e647f5513 DIFF: https://github.com/llvm/llvm-project/commit/4969a6924dc1644d4fa6cf89a33b598e647f5513.diff L

[Lldb-commits] [lldb] 8cc9fa6 - Use static_cast from SmallString to std::string (NFC)

2022-06-04 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2022-06-04T22:09:27-07:00 New Revision: 8cc9fa6f78237a5771a5f85eb9ef129ea85a54cf URL: https://github.com/llvm/llvm-project/commit/8cc9fa6f78237a5771a5f85eb9ef129ea85a54cf DIFF: https://github.com/llvm/llvm-project/commit/8cc9fa6f78237a5771a5f85eb9ef129ea85a54cf.diff L