[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

labath added a comment. In D123020#3437246 , @llunak wrote: > In D123020#3426867 , @JDevlieghere > wrote: > >> FWIW the official policy is outlined here: >> https://llvm.org/docs/CodeReview.html > > I'm aware of

[Lldb-commits] [PATCH] D123128: don't extra notify ModulesDidLoad() from LoadModuleAtAddress()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123128/new/ https://reviews.llvm.org/D123128 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

labath added a comment. I'm looking at the SymbolFileOnDemand friendship and the forwarding of protected methods (mostly dealing with compile unit lists). Does this by any chance have something to do with the fact that there are now two compile unit lists (one in the actual symbol file, and one

[Lldb-commits] [PATCH] D123500: [lldb][NFC] Add more tests for GenerateOptionsUsage

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a few targeted tests to make sure that when refactoring this function later I don't break these proper

[Lldb-commits] [PATCH] D123501: [lldb][NFC] Simplify part of Options::GenerateOptionUsage

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use llvm::enumerate, remove an unused arg name stream and replace repeated uses of indexing to get the option de

[Lldb-commits] [PATCH] D123502: [lldb][NFC] Refactor printing of short options in help

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Instead of building a set twice for optional and required, build a set for each while walking the options once.

[Lldb-commits] [PATCH] D123500: [lldb][NFC] Add more tests for GenerateOptionsUsage

DavidSpickett added a reviewer: jingham. DavidSpickett added a subscriber: jingham. DavidSpickett added a comment. @jingham You suggested I take a look at this function after I did a small fix a while back so adding you on review for this and the following changes. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

llunak added a comment. In D123020#3442434 , @labath wrote: > In D123020#3437246 , @llunak wrote: > >> In D123020#3426867 , @JDevlieghere >> wrote: >> >>> FWIW the offici

[Lldb-commits] [PATCH] D123204: [lldb] Fix initialization of LazyBool/bool variables m_overwrite/m_overwrite_lazy. NFCI.

mstorsjo added a comment. Ping @jingham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123204/new/ https://reviews.llvm.org/D123204 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] 373d08a - [lldb] Silence warnings about unused static variables in RegisterInfos_arm64.h

Author: Martin Storsjö Date: 2022-04-11T19:50:48+03:00 New Revision: 373d08adb4454d416bd2232525e5a6fbe45935ab URL: https://github.com/llvm/llvm-project/commit/373d08adb4454d416bd2232525e5a6fbe45935ab DIFF: https://github.com/llvm/llvm-project/commit/373d08adb4454d416bd2232525e5a6fbe45935ab.diff

[Lldb-commits] [PATCH] D123206: [lldb] Silence warnings about unused static variables in RegisterInfos_arm64.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG373d08adb445: [lldb] Silence warnings about unused static variables in RegisterInfos_arm64.h (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [lldb] cbcb3bc - [lldb] Don't report progress in the REPL

Author: Jonas Devlieghere Date: 2022-04-11T13:06:40-07:00 New Revision: cbcb3bcee3efc8ea4e72bc36ae5cbaf946804b58 URL: https://github.com/llvm/llvm-project/commit/cbcb3bcee3efc8ea4e72bc36ae5cbaf946804b58 DIFF: https://github.com/llvm/llvm-project/commit/cbcb3bcee3efc8ea4e72bc36ae5cbaf946804b58.d

[Lldb-commits] [PATCH] D123426: [lldb] Don't report progress in the REPL

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbcb3bcee3ef: [lldb] Don't report progress in the REPL (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] 195a8b9 - don't extra notify ModulesDidLoad() from LoadModuleAtAddress()

Author: Luboš Luňák Date: 2022-04-12T00:36:33+02:00 New Revision: 195a8b977efe7a087709692f98821cdab1826346 URL: https://github.com/llvm/llvm-project/commit/195a8b977efe7a087709692f98821cdab1826346 DIFF: https://github.com/llvm/llvm-project/commit/195a8b977efe7a087709692f98821cdab1826346.diff L

[Lldb-commits] [PATCH] D123128: don't extra notify ModulesDidLoad() from LoadModuleAtAddress()

This revision was automatically updated to reflect the committed changes. Closed by commit rG195a8b977efe: don't extra notify ModulesDidLoad() from LoadModuleAtAddress() (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123128/new/

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. > Does this by any chance have something to do with the fact that there are now > two compile unit lists (one in the actual symbol file, and one in the > wrapping ondemand class? Yes, that's the major reason. We also need make SymbolFileOnDemand friend in SymbolFile

[Lldb-commits] [PATCH] D123375: [lldb][intelpt] Reduce trace memory usage by grouping instructions

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. I did a first pass on this diff. I'm asking to refactor a bit the InstructionBlock classes so that they are smarter. Besides that, if you use IDs more ubiquitously and stop using i

[Lldb-commits] [PATCH] D123358: [trace][intelpt] Remove code smell when printing the raw trace size

wallace added a comment. Well, not all theoretical trace plugins might have raw trace sizes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123358/new/ https://reviews.llvm.org/D123358 ___ lldb-commits ma

[Lldb-commits] [PATCH] D123501: [lldb][NFC] Simplify part of Options::GenerateOptionUsage

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123501/new/ https://reviews.llvm.org/D123501 ___

[Lldb-commits] [PATCH] D123502: [lldb][NFC] Refactor printing of short options in help

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/Options.cpp:457 - if (!options.empty()) { -// We have some required options with no arguments + if (required_options.size()) { strm.PutCString(" -"); I'm surprise