[Lldb-commits] [PATCH] D122944: [lldb] Prevent object file plugins from messing with the data buffer if they don't match

labath added a comment. It would be better if we could automatically "reset" these variables by having the plugins accept them as values instead of references. Does anyone I actually need the new values of the variables after these functions are done? I know of at least one place

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak created this revision. llunak added reviewers: clayborg, chandlerc. Herald added subscribers: dexonsmith, hiraditya. Herald added a project: All. llunak requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Pool::GetConst

[Lldb-commits] [PATCH] D122975: parallelize module loading in DynamicLoaderPOSIXDYLD()

llunak created this revision. llunak added reviewers: clayborg, labath. llunak added a project: LLDB. Herald added subscribers: usaxena95, JDevlieghere, kadircet. Herald added a project: All. llunak requested review of this revision. Herald added subscribers: lldb-commits, ilya-biryukov. If LLDB i

[Lldb-commits] [PATCH] D122980: make ConstStringTable use std::unordered_map rather than std::map

llunak created this revision. llunak added a reviewer: clayborg. llunak added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. The ordering is not needed, and std::unordered_map

[Lldb-commits] [PATCH] D122980: make ConstStringTable use std::unordered_map rather than std::map

JDevlieghere added a comment. I feel like this came up in the past and there was a reason an unordered map couldn't work? Maybe I'm confusing this with something else. Added Pavel as he would certainly know. Could we use a `llvm::DenseMap` here, as it's supposedly even faster than its STL coun

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

JDevlieghere added a comment. The ConstString/StringPool is pretty hot so I'm very excited about making it faster. I'm slightly concerned about the two hash values (the "full" hash vs the single byte one). That's not something that was introduced in this patch, but passing it around adds an op

[Lldb-commits] [PATCH] D122944: [lldb] Prevent object file plugins from messing with the data buffer if they don't match

JDevlieghere updated this revision to Diff 419993. JDevlieghere added a comment. Herald added subscribers: pmatos, asb, MaskRay, aheejin, sbc100, emaste. Prevent object files from changing the buffer by passing it by value CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122944/new/ https:

[Lldb-commits] [PATCH] D122980: make ConstStringTable use DenseMap rather than std::map

llunak updated this revision to Diff 419996. llunak retitled this revision from "make ConstStringTable use std::unordered_map rather than std::map" to "make ConstStringTable use DenseMap rather than std::map". llunak edited the summary of this revision. llunak added a comment. In D122980#34246

[Lldb-commits] [lldb] 1e5083a - [trace][intel pt] Handle better tsc in the decoder

Author: Walter Erquinigo Date: 2022-04-02T11:06:26-07:00 New Revision: 1e5083a563f8aca294feda60dcb4a814623ba321 URL: https://github.com/llvm/llvm-project/commit/1e5083a563f8aca294feda60dcb4a814623ba321 DIFF: https://github.com/llvm/llvm-project/commit/1e5083a563f8aca294feda60dcb4a814623ba321.di

[Lldb-commits] [PATCH] D122867: [trace][intel pt] Handle better tsc in the decoder

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e5083a563f8: [trace][intel pt] Handle better tsc in the decoder (authored by Walter Erquinigo ). Changed prior to commit: https://reviews.llvm.org/D122867?vs=419813&id=420001#toc Repos

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3424654 , @JDevlieghere wrote: > I'm slightly concerned about the two hash values (the "full" hash vs the > single byte one). That's not something that was introduced in this patch, but > passing it around adds an opp

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

clayborg added a comment. LGTM from a LLDB perspective. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.org/D122974 ___ lldb-commits mailing list lldb-commits@lists.llvm.or