[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:1323 +// CommandObjectThreadSiginfo + JDevlieghere wrote: > I know you're just being consistent with the rest of this file, but we'v

[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

mgorny updated this revision to Diff 405249. mgorny marked an inline comment as done. mgorny added a comment. Removed the comment and added `thread info`-style status above siginfos. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118473/new/ https://reviews.llvm.org/D118473 Files: lld

[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This commit makes lldb-server on Linux strip non-address bits from addresses passed to the followin

[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Without this change any memory read/write of a pointer with a signature would fail. I found it trying to extend memory find and using a pointer with both a signature and a memory tag. There's a couple of things I could do

[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

DavidSpickett added a comment. Also if anyone does know how or if debugserver handles this situation, that would be good to know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118794/new/ https://reviews.llvm.org/D118794 _

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, clayborg, labath. JDevlieghere requested review of this revision. Libraries which rely heavily on templates (e.g. boost) can generate extremely long symbol names, with mangled names in the 10 000 of characters. These symb

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, clayborg, labath. Herald added a subscriber: arphaman. JDevlieghere requested review of this revision. The symbol table needs to demangle all symbols when building its index. However, the index doesn't need the demangeld s

[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118473/new/ https://reviews.llvm.org/D118473 ___ lldb-commits maili

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

dblaikie added a comment. Any chance you might want a limit on the size of the demangled name too? (might be worth considering what the most densely encoded mangled name is (ie: what's the longest name that could be produced by a 10k long mangled name? and see if that's worth having another cut

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

kastiglione added a comment. Is it worth trying to come up with a limit that's not arbitrarily picked? Comment at: lldb/source/Symbol/Symtab.cpp:300 +const uint64_t mangling_limit = +ModuleList::GetGlobalModuleListProperties().GetDemanglingLimit(); ---

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

kastiglione added a comment. > the amount of memory we save here is well worth the small performance hit any numbers to share? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118814/new/ https://reviews.llvm.org/D118814 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

jingham added a comment. In D118812#3291109 , @dblaikie wrote: > Any chance you might want a limit on the size of the demangled name too? > (might be worth considering what the most densely encoded mangled name is > (ie: what's the longest name that cou

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

JDevlieghere added a comment. In D118814#3291174 , @kastiglione wrote: >> the amount of memory we save here is well worth the small performance hit > > any numbers to share? We have one scenario where this bring memory usage after attach down from 7gb

[Lldb-commits] [lldb] 287ce6b - [lldb] [Commands] Implement "thread siginfo"

Author: Michał Górny Date: 2022-02-02T19:31:44+01:00 New Revision: 287ce6b51675aee43870bebfff68bb144d1ab90e URL: https://github.com/llvm/llvm-project/commit/287ce6b51675aee43870bebfff68bb144d1ab90e DIFF: https://github.com/llvm/llvm-project/commit/287ce6b51675aee43870bebfff68bb144d1ab90e.diff

[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

This revision was automatically updated to reflect the committed changes. Closed by commit rG287ce6b51675: [lldb] [Commands] Implement "thread siginfo" (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

mgorny added a comment. Thanks for all the reviews and helpful suggestions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118473/new/ https://reviews.llvm.org/D118473 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

jingham added a comment. This patch does have one side-effect that I know of, which is that if we don't keep demangled names in the symbol table, then breaking on an overload by demangled name won't work. OTOH, that only worked if you exactly matched the demangler's output - no extra spaces, e

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

dblaikie added a subscriber: rsmith. dblaikie added a comment. In D118812#3291303 , @jingham wrote: > In D118812#3291109 , @dblaikie > wrote: > >> Any chance you might want a limit on the size of the demangled na

[Lldb-commits] [PATCH] D118842: Small fixes to platform packet documentation

jasonmolenda created this revision. jasonmolenda added a reviewer: mgorny. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. I have a standalone implementation of the lldb platform p

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

clayborg added a comment. Can we put a limit on the length of the kinds of names we are willing to demangle in the first place? How long are some of these names _prior_ to demangling? It would be great if we could skip demangling names that are too long to begin with. That would allow us to ski

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

JDevlieghere added a comment. In D118812#3291937 , @clayborg wrote: > Can we put a limit on the length of the kinds of names we are willing to > demangle in the first place? How long are some of these names _prior_ to > demangling? It would be great if

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

JDevlieghere added a comment. In D118812#3291482 , @dblaikie wrote: > In D118812#3291303 , @jingham wrote: > >> In D118812#3291109 , @dblaikie >> wrote: >> >>> Any chance

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

clayborg added a comment. In D118812#3291950 , @JDevlieghere wrote: > In D118812#3291937 , @clayborg > wrote: > >> Can we put a limit on the length of the kinds of names we are willing to >> demangle in the fir

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

JDevlieghere added a comment. In D118812#3291969 , @clayborg wrote: > Yikes sorry, I read line Symtab.cpp:311 as if it was demangling the name > first and then checking _its_ length... > > The settings leads one to believe that we don't ever demangle nam

[Lldb-commits] [lldb] f3e1ba1 - [LLDB] add sub regigter enums on x64 Windows

Author: Zequan Wu Date: 2022-02-02T14:21:08-08:00 New Revision: f3e1ba1d03927a35c23c27c896a13f326f28864a URL: https://github.com/llvm/llvm-project/commit/f3e1ba1d03927a35c23c27c896a13f326f28864a DIFF: https://github.com/llvm/llvm-project/commit/f3e1ba1d03927a35c23c27c896a13f326f28864a.diff LOG

[Lldb-commits] [PATCH] D118750: [LLDB] add sub register enums on x64 Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3e1ba1d0392: [LLDB] add sub regigter enums on x64 Windows (authored by zequanwu). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D118750: [LLDB] add sub register enums on x64 Windows

stella.stamenova added a comment. Herald added a subscriber: JDevlieghere. This broke the windows bot in the best way possible - by making some tests pass now that didn't use to. Could you un-xfail those too? https://lab.llvm.org/buildbot/#/builders/83/builds/14736 Repository: rG LLVM Github

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

jingham added a comment. If we can distinguish between "when we handle all mangled names" and "when we handle one" I think we should continue to demangle names in the "when we handle one" case, since you never know when somebody really might need to look at the whole name. But OTOH that's prob

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

zequanwu created this revision. zequanwu added a reviewer: stella.stamenova. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This attempts to fix this bot failure: https://lab.llvm.org/buildbot/#/builders/83/builds/14736 caused by

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

stella.stamenova added a comment. They should correspond to these files: lldb-api :: functionalities/inferior-crashing/TestInferiorCrashing.py => test/API/functionalities/inferior-crashing/TestInferiorCrashing.py lldb-api :: functionalities/inferior-crashing/TestInferiorCrashingStep.py => t

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

zequanwu updated this revision to Diff 405505. zequanwu added a comment. Un-xfail more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118866/new/ https://reviews.llvm.org/D118866 Files: lldb/test/API/commands/register/register/register_com

[Lldb-commits] [PATCH] D118842: Small fixes to platform packet documentation

jasonmolenda added a comment. FWIW I started updating my implementation by reading through all the changes to the docs, and implementing them. Then I went back and looked at the patches and found some small changes that were made but without documentation being updated, or the documentation no