labath added a reviewer: jingham.
labath added a comment.
Seems reasonable to me, but let's get Jim's opinion too.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118473/new/
https://reviews.llvm.org/D118473
___
lldb-commits mailing list
lldb-c
Author: Pavel Labath
Date: 2022-02-01T14:36:29+01:00
New Revision: b1127753b9dd9e76fa89e567345c0be0585b7498
URL:
https://github.com/llvm/llvm-project/commit/b1127753b9dd9e76fa89e567345c0be0585b7498
DIFF:
https://github.com/llvm/llvm-project/commit/b1127753b9dd9e76fa89e567345c0be0585b7498.diff
RKSimon added a comment.
mlir-windows buildbot looks to be green now - thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114639/new/
https://reviews.llvm.org/D114639
___
lldb-commits mailing list
lld
MaskRay added a comment.
Please abandon this revision.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115960/new/
https://reviews.llvm.org/D115960
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jingham added a comment.
I think it would help readability if you put the thread ID for the signinfo
before printing the siginfo value, otherwise if I list multiple threads (or use
"all") I have to count instances to figure out which thread goes with which
siginfo.
Otherwise this looks fine.
JDevlieghere added inline comments.
Comment at: lldb/source/Commands/CommandObjectThread.cpp:1323
+// CommandObjectThreadSiginfo
+
I know you're just being consistent with the rest of this file, but we've been
slowly phasing out these kind of comments.
CHAN
