[Lldb-commits] [PATCH] D117004: [lldb] Don't print "Command Options Usage:" for an alias with no options

DavidSpickett created this revision. Herald added a subscriber: jeroen.dobbelaere. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. "shell" is an alias to "platform shell -h --". Previously you would get this help text: (lldb)

[Lldb-commits] [PATCH] D116845: [LLDB][NativePDB] Add support for inlined functions

labath added a comment. In D116845#3232971 , @zequanwu wrote: >> The one part that bothers me is the "two-phased" setting of line tables. >> IIUC, the problem is that the inline line info is in the block descriptor, >> so you need to parse block info in

[Lldb-commits] [lldb] 6d8d1c5 - [lldb/qemu] Implement GetMmapArgumentList

Author: Pavel Labath Date: 2022-01-11T14:08:03+01:00 New Revision: 6d8d1c5ea307a6f8f86bb870535e426ccddccb4d URL: https://github.com/llvm/llvm-project/commit/6d8d1c5ea307a6f8f86bb870535e426ccddccb4d DIFF: https://github.com/llvm/llvm-project/commit/6d8d1c5ea307a6f8f86bb870535e426ccddccb4d.diff

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett updated this revision to Diff 398916. DavidSpickett added a comment. Rebase, update some comment wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103626/new/ https://reviews.llvm.org/D103626 Files: lldb/source/Commands/Comman

[Lldb-commits] [PATCH] D103626: [lldb] Remove non address bits from memory read arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88fdce5be696: [lldb] Remove non address bits from memory read arguments (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 88fdce5 - [lldb] Remove non address bits from memory read arguments

Author: David Spickett Date: 2022-01-11T13:24:09Z New Revision: 88fdce5be696c7ef992cffce9da9ec6895a1abfc URL: https://github.com/llvm/llvm-project/commit/88fdce5be696c7ef992cffce9da9ec6895a1abfc DIFF: https://github.com/llvm/llvm-project/commit/88fdce5be696c7ef992cffce9da9ec6895a1abfc.diff LOG

[Lldb-commits] [PATCH] D103626: [lldb] Remove non address bits from memory read arguments

DavidSpickett added a comment. Since there was no great pushback on this I've landed it. With the final justification being that the non-address bits are properties of the pointer not of the memory pointed to. I will do a follow up where I apply the same logic to the ReadMemory calls via the A

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett updated this revision to Diff 398921. DavidSpickett added a comment. - Revert back to the do...while structure. - Reword the explanatory comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115508/new/ https://reviews.llvm.org/D115

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett added a comment. @omjavaid ping! Using `fixed address != original address` inspired by https://reviews.llvm.org/D115431#change-7Gybl0dcCOwp. I first used `<` which I think works out the same but `!=` is clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D116845: [LLDB][NativePDB] Add support for inlined functions

zequanwu updated this revision to Diff 399001. zequanwu marked an inline comment as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116845/new/ https://reviews.llvm.org/D116845 Files: lldb/include/lldb/Symbo

[Lldb-commits] [lldb] c0e4154 - Fix clang-tidy bugprone-argument-comment that was mixed up

Author: Shafik Yaghmour Date: 2022-01-11T11:12:28-08:00 New Revision: c0e415471136a16cc98c9ce57392efd62db51c1f URL: https://github.com/llvm/llvm-project/commit/c0e415471136a16cc98c9ce57392efd62db51c1f DIFF: https://github.com/llvm/llvm-project/commit/c0e415471136a16cc98c9ce57392efd62db51c1f.dif

[Lldb-commits] [PATCH] D116982: Fix clang-tidy bugprone-argument-comment that was mixed up

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0e415471136: Fix clang-tidy bugprone-argument-comment that was mixed up (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D117004: [lldb] Don't print "Command Options Usage:" for an alias with no options

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117004/new/ https://reviews.llvm.org/D117004 ___

[Lldb-commits] [PATCH] D117004: [lldb] Don't print "Command Options Usage:" for an alias with no options

jingham accepted this revision. jingham added a comment. I was confused by your example of the "quit" command since the previous code output the banner before checking the NumCommandOptions, so that shouldn't have worked. Actually, there's a check in CommandObject::GenerateHelp for a null ret

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

kastiglione added a comment. > if I run “frame var” from HandleCommand in a script, with this change I can’t > rely on the command status to tell whether the command output had anything > interesting in it. That seems awkward. This could be resolved by introducing a new enum value to indicate p

[Lldb-commits] [PATCH] D116845: [LLDB][NativePDB] Add support for inlined functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG945aa520ef07: [LLDB][NativePDB] Add support for inlined functions (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116845/new/ https://

[Lldb-commits] [lldb] 945aa52 - [LLDB][NativePDB] Add support for inlined functions

Author: Zequan Wu Date: 2022-01-11T16:10:39-08:00 New Revision: 945aa520ef07a3edb655f3f38e4c3023658dd623 URL: https://github.com/llvm/llvm-project/commit/945aa520ef07a3edb655f3f38e4c3023658dd623 DIFF: https://github.com/llvm/llvm-project/commit/945aa520ef07a3edb655f3f38e4c3023658dd623.diff LOG

Re: [Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

Indeed not. Since you can get everything you would need straightforwardly using SBFrame::FindVariables, there’s no pressing need to give another way to do it using HandleCommand. Jim > On Jan 11, 2022, at 2:02 PM, Dave Lee via Phabricator > wrote: > > kastiglione added a comment. > >> if I

[Lldb-commits] [PATCH] D117065: [lldb/Plugins] Fix ScriptedInterface object ptr use-after-free

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLVM. mib requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch replaces all the ScriptedInterface object instance shared pointer by a raw pointer. The

[Lldb-commits] [PATCH] D117068: [lldb/Plugins] Add ScriptedProcess::GetThreadsInfo interface

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds a new method to the Scripted Process interface to retrive a dictionary of Scripted Threads. It uses the thread I

[Lldb-commits] [PATCH] D117070: [lldb/Plugins] Move ScriptedThreadInterface to ScriptedThread

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. Since we can have multiple Scripted Threads per Scripted Process, having only a single ScriptedThreadInterface (with a single ob

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds support of multiple Scripted Threads in a ScriptedProcess. This is done by fetch the Scripted Threads info dict

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

mib updated this revision to Diff 399146. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117071/new/ https://reviews.llvm.org/D117071 Files: lldb/examples/python/scripted_process/scripted_process.py lldb/source/Plugins/Process/scripted/ScriptedPr

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

mib updated this revision to Diff 399149. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117071/new/ https://reviews.llvm.org/D117071 Files: lldb/examples/python/scripted_process/scripted_process.py lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp lldb/source/Plugins/Process

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

mib updated this revision to Diff 399152. mib added a comment. Update `invalid_scripted_process.py` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117071/new/ https://reviews.llvm.org/D117071 Files: lldb/examples/python/scripted_process/scripted_process.py lldb/source/Plugins/Proces

[Lldb-commits] [PATCH] D117074: [lldb/Plugins] Enrich ScriptedThreads Stop Reasons with Exceptions

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a subscriber: kristof.beyls. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds Exceptions to the list of supported stop reasons for Scripted Threads.

[Lldb-commits] [PATCH] D117074: [lldb/Plugins] Enrich ScriptedThreads Stop Reasons with Exceptions

mib updated this revision to Diff 399164. mib added a comment. Update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117074/new/ https://reviews.llvm.org/D117074 Files: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp lldb/source/

[Lldb-commits] [lldb] 06c7bdc - [lldb] Specify LLVM target requirements in TestLaunchProcessPosixSpawn

Author: Dave Lee Date: 2022-01-11T19:00:47-08:00 New Revision: 06c7bdc8f1950dfa0cee19aabf13b8fce859ec98 URL: https://github.com/llvm/llvm-project/commit/06c7bdc8f1950dfa0cee19aabf13b8fce859ec98 DIFF: https://github.com/llvm/llvm-project/commit/06c7bdc8f1950dfa0cee19aabf13b8fce859ec98.diff LOG:

[Lldb-commits] [PATCH] D117076: [lldb/Plugins] Fix ScriptedThread IndexID reporting

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a subscriber: arphaman. mib requested review of this revision. Herald added a subscriber: lldb-commits. When listing all the Scripted Threads of a ScriptedProcess, we can see that all have the th

[Lldb-commits] [PATCH] D117076: [lldb/Plugins] Fix ScriptedThread IndexID reporting

mib updated this revision to Diff 399172. mib edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117076/new/ https://reviews.llvm.org/D117076 Files: lldb/include/lldb/Target/Thread.h lldb/source/Plugins/Process/scripted/ScriptedThread.cpp Index: lldb