[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

omjavaid added a comment. @clayborg This breaks LLDB Linux buildbots: https://lab.llvm.org/buildbot/#/builders/17/builds/15166 https://lab.llvm.org/buildbot/#/builders/96/builds/16114 https://lab.llvm.org/buildbot/#/builders/68/builds/23796 Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] caa7e76 - [lldb] Make ProcessLauncherPosixFork (mostly) async-signal-safe

Author: Pavel Labath Date: 2021-12-29T09:45:47+01:00 New Revision: caa7e765e5ae250c67eab3edd7cd324d3634f779 URL: https://github.com/llvm/llvm-project/commit/caa7e765e5ae250c67eab3edd7cd324d3634f779 DIFF: https://github.com/llvm/llvm-project/commit/caa7e765e5ae250c67eab3edd7cd324d3634f779.diff

[Lldb-commits] [lldb] daed479 - [lldb] Adjust TestModuleCacheSimple for D115951

Author: Pavel Labath Date: 2021-12-29T10:00:00+01:00 New Revision: daed4797fee4a5f1985388265f5af209b5cb3b10 URL: https://github.com/llvm/llvm-project/commit/daed4797fee4a5f1985388265f5af209b5cb3b10 DIFF: https://github.com/llvm/llvm-project/commit/daed4797fee4a5f1985388265f5af209b5cb3b10.diff

[Lldb-commits] [PATCH] D116165: [lldb] Make ProcessLauncherPosixFork (mostly) async-signal-safe

This revision was automatically updated to reflect the committed changes. Closed by commit rGcaa7e765e5ae: [lldb] Make ProcessLauncherPosixFork (mostly) async-signal-safe (authored by labath). Changed prior to commit: https://reviews.llvm.org/D116165?vs=395859&id=396500#toc Repository: rG LL

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

labath added a comment. The problem was that (without accelerator tables) we would always have more than one cache file for a given module. I have now adjusted the test (daed479 ) to check for the presence of one _symtab_ inde

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled

labath accepted this revision. labath added a comment. Cool. Thanks for fixing this. Do you need someone to commit this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116217/new/ https://reviews.llvm.org/D116217 ___ lldb-commits maili

[Lldb-commits] [lldb] 633b002 - [lldb] Fix PR52702 by fixing bool conversion of Mangled

Author: PoYao Chang Date: 2021-12-29T17:17:52+08:00 New Revision: 633b002944b966ddb64c85f4a8c017a858afb4fc URL: https://github.com/llvm/llvm-project/commit/633b002944b966ddb64c85f4a8c017a858afb4fc DIFF: https://github.com/llvm/llvm-project/commit/633b002944b966ddb64c85f4a8c017a858afb4fc.diff L

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG633b002944b9: [lldb] Fix PR52702 by fixing bool conversion of Mangled (authored by rZhBoYao). Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled

rZhBoYao added a comment. Thank you all for spending time reviewing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116217/new/ https://reviews.llvm.org/D116217 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] fdd741d - [lldb/linux] Fix a bug in wait status handling

Author: Pavel Labath Date: 2021-12-29T11:06:30+01:00 New Revision: fdd741dd31814d3d4e5c29185f27a529943050d2 URL: https://github.com/llvm/llvm-project/commit/fdd741dd31814d3d4e5c29185f27a529943050d2 DIFF: https://github.com/llvm/llvm-project/commit/fdd741dd31814d3d4e5c29185f27a529943050d2.diff

[Lldb-commits] [PATCH] D116255: [lldb] [Process/FreeBSDKernel] Support finding all processes

mgorny updated this revision to Diff 396512. mgorny marked 3 inline comments as done. mgorny added a comment. Update the code per suggestions, update the first test case. TODO: update the remaining tests, document the code better CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116255/new/

[Lldb-commits] [PATCH] D116255: [lldb] [Process/FreeBSDKernel] Support finding all processes

mgorny updated this revision to Diff 396514. mgorny added a comment. Add code comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116255/new/ https://reviews.llvm.org/D116255 Files: lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.cpp lldb/source/Plugins/Process/Fr

[Lldb-commits] [PATCH] D116372: [lldb-server/linux] Fix waitpid for multithreaded forks

labath created this revision. labath added reviewers: mgorny, DavidSpickett. labath requested review of this revision. Herald added a project: LLDB. The lldb-server code is currently set up in a way that each NativeProcess instance does its own waitpid handling. This works fine for BSDs, where the

[Lldb-commits] [PATCH] D116255: [lldb] [Process/FreeBSDKernel] Support finding all processes

mgorny updated this revision to Diff 396530. mgorny added a comment. Update all tests. Phab doesn't like git binary deltas for some reason, so I've uploaded the patch with `--no-binary`. New file sizes: -rw-r--r-- 1 mgorny mgorny 120K 12-29 15:36 lldb/test/API/functionalities/postmortem/Fre

[Lldb-commits] [PATCH] D116372: [lldb-server/linux] Fix waitpid for multithreaded forks

mgorny added a comment. Thank you a lot for doing this. I love how the code becomes simpler, and the cost doesn't seem much. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1909 + wait_status); +tid_events.try_emplace(thread_up->GetID(), wa

Re: [Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

Thanks Pavel, that fix is good. > On Dec 29, 2021, at 1:05 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > The problem was that (without accelerator tables) we would always have more > than one cache file for a given module. I have now adjusted the test (daed479 > <

[Lldb-commits] [PATCH] D116195: [LLDB] Allows overwriting the existing line entry at given file address when inserting

clayborg added a comment. In D116195#3211906 , @zequanwu wrote: > In D116195#3211346 , @labath wrote: > >> In D116195#3208476 , @zequanwu >> wrote: >> >>> In D116195#3207