[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing Mangled::operator!

labath added inline comments. Comment at: lldb/source/Core/Mangled.cpp:87 // { ... -bool Mangled::operator!() const { return !m_mangled; } +bool Mangled::operator!() const { return !m_mangled && !m_demangled; } rZhBoYao wrote: > Should we remove `Mangled::ope

[Lldb-commits] [PATCH] D115662: [lldb][DWARF] Remove duplicate DIE type assignment

labath accepted this revision. labath added a comment. I don't have any issues with this, if everything still works. I hoped there would be more of a discussion on this (I was hoping I'd maybe learn something from it). That obviously didn't happen, but I don't think it needs to hold this back.

[Lldb-commits] [PATCH] D116255: [lldb] [Process/FreeBSDKernel] Support finding all processes

labath added a comment. I think I've managed to figure out what the code is doing, but it wouldn't hurt to include a comment giving a high-level overview of what that code is doing and/or splitting it into smaller functions with helpful names. Can we expect to have a test for this? =

[Lldb-commits] [PATCH] D116211: With firmware debug sess, if gdb stub knows the UUID/address of binary, try to load it

labath added a comment. What happened to the test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116211/new/ https://reviews.llvm.org/D116211 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D116162: [lldb/python] Fix dangling Event and CommandReturnObject references

labath added a comment. This isn't a feature I would want advertise too broadly, or add special APIs to support it. The way I see it, if a user needs to check if an object has been cleared, something has gone wrong already. So I'd rather do something to discourage this use case instead of provi

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing Mangled::operator!

rZhBoYao added inline comments. Comment at: lldb/source/Core/Mangled.cpp:87 // { ... -bool Mangled::operator!() const { return !m_mangled; } +bool Mangled::operator!() const { return !m_mangled && !m_demangled; } labath wrote: > rZhBoYao wrote: > > Should we

[Lldb-commits] [PATCH] D116195: [LLDB] Allows overwriting the existing line entry at given file address when inserting

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. In D116195#3208476 , @zequanwu wrote: > In D116195#3207672 , @labath wrote: > >> How are you planni

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing Mangled::operator!

labath added inline comments. Comment at: lldb/source/Core/Mangled.cpp:87 // { ... -bool Mangled::operator!() const { return !m_mangled; } +bool Mangled::operator!() const { return !m_mangled && !m_demangled; } rZhBoYao wrote: > labath wrote: > > rZhBoYao wro

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled

rZhBoYao updated this revision to Diff 396395. rZhBoYao retitled this revision from "[lldb] Fix PR52702 by fixing Mangled::operator!" to "[lldb] Fix PR52702 by fixing bool conversion of Mangled". rZhBoYao edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D116255: [lldb] [Process/FreeBSDKernel] Support finding all processes

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.cpp:221 +ThreadSP thread_sp(new ThreadFreeBSDKernel( +*this, tid, pcb_addr, +llvm::formatv("(pid {0}) {1}/{2}", pid, comm, thread_name))); ---

[Lldb-commits] [lldb] a2154b1 - Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

Author: Greg Clayton Date: 2021-12-28T11:00:28-08:00 New Revision: a2154b19515304f42000160bed820630c3780db8 URL: https://github.com/llvm/llvm-project/commit/a2154b19515304f42000160bed820630c3780db8 DIFF: https://github.com/llvm/llvm-project/commit/a2154b19515304f42000160bed820630c3780db8.diff

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2154b195153: Cache the manual DWARF index out to the LLDB cache directory when the LLDB… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D116012: Fix "settings set -g" so it works again.

This revision was automatically updated to reflect the committed changes. Closed by commit rG48207b2559c6: Fix "settings set -g" so it works again. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116012/new/ https://reviews.llv

[Lldb-commits] [lldb] 48207b2 - Fix "settings set -g" so it works again.

Author: Greg Clayton Date: 2021-12-28T11:03:09-08:00 New Revision: 48207b2559c6b012ce167f2e76acea39e9d405cf URL: https://github.com/llvm/llvm-project/commit/48207b2559c6b012ce167f2e76acea39e9d405cf DIFF: https://github.com/llvm/llvm-project/commit/48207b2559c6b012ce167f2e76acea39e9d405cf.diff

[Lldb-commits] [PATCH] D116195: [LLDB] Allows overwriting the existing line entry at given file address when inserting

zequanwu added a comment. In D116195#3211346 , @labath wrote: > In D116195#3208476 , @zequanwu > wrote: > >> In D116195#3207672 , @labath wrote: >> >>> How are you planni