labath added a comment.
Thanks for the quick response.
I did another pass over the patch, and I think I have a fairly good
understanding of how it works. I have another round of comments, but nothing
major.
Comment at: lldb/include/lldb/Core/DataFileCache.h:9
+
+#ifndef LLDB
clayborg updated this revision to Diff 394656.
clayborg marked 7 inline comments as done.
clayborg added a comment.
- Fixed all review issues
- Moved tests to separate test files in SymbolTests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115324/ne
clayborg added inline comments.
Comment at: lldb/source/Core/Module.cpp:1679
+
+std::string Module::GetCacheKey() {
+ std::string key;
labath wrote:
> The cache key and cache signature algorithms are fairly similar but subtly
> different (IIUC, one is used to l
clayborg added a comment.
Pavel: I fixed all issues you identified. Let me know if there is anything else
you would like to see changed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115324/new/
https://reviews.llvm.org/D115324
__
Author: Adrian Prantl
Date: 2021-12-15T14:48:39-08:00
New Revision: 8b624290635fea64dfa14587b650dbb5077879a2
URL:
https://github.com/llvm/llvm-project/commit/8b624290635fea64dfa14587b650dbb5077879a2
DIFF:
https://github.com/llvm/llvm-project/commit/8b624290635fea64dfa14587b650dbb5077879a2.diff
Author: Adrian Prantl
Date: 2021-12-15T14:54:03-08:00
New Revision: 11c2af04f27a293de974ffdfc8faefe247a4e722
URL:
https://github.com/llvm/llvm-project/commit/11c2af04f27a293de974ffdfc8faefe247a4e722
DIFF:
https://github.com/llvm/llvm-project/commit/11c2af04f27a293de974ffdfc8faefe247a4e722.diff
