[Lldb-commits] [PATCH] D115570: [lldb] Use `GNUInstallDirs` to support custom installation dirs.

2021-12-12 Thread John Ericson via Phabricator via lldb-commits
Ericson2314 added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:1 +include(GNUInstallDirs) function(lldb_tablegen) I think a problem with D115544 was that `AddLLVM` was assuming `GNUInstallDirs` yet downstream packages didn't yet include it. By

[Lldb-commits] [lldb] d2377f2 - Ensure newlines at the end of files (NFC)

2021-12-12 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2021-12-12T11:04:44-08:00 New Revision: d2377f24e13549f08bbddfe9af8e8b61e9528581 URL: https://github.com/llvm/llvm-project/commit/d2377f24e13549f08bbddfe9af8e8b61e9528581 DIFF: https://github.com/llvm/llvm-project/commit/d2377f24e13549f08bbddfe9af8e8b61e9528581.diff L

[Lldb-commits] [PATCH] D115308: [LLDB] Uniquify Type in type list.

2021-12-12 Thread Zequan Wu via Phabricator via lldb-commits
zequanwu added a comment. In D115308#3184564 , @shafik wrote: > I would also like to know where this duplicate insertion is happening. Can > you walk us through the steps that lead to the duplicate entries? thank you! Firstly, I found that `SymbolFileDW