[Lldb-commits] [PATCH] D111634: [lldb] Print embedded nuls in char arrays (PR44649)

labath added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp:40 +//% self.expect_var_path("c.data", summary=r'"F\0O"') //% self.runCmd("setting set escape-non-printables false") //% self.expect_var_path('stdstring',

[Lldb-commits] [lldb] ca0ce99 - [lldb] Print embedded nuls in char arrays (PR44649)

Author: Pavel Labath Date: 2021-10-14T09:50:40+02:00 New Revision: ca0ce99fc87c9a49b4c4a69cc6e88594bf6eb13c URL: https://github.com/llvm/llvm-project/commit/ca0ce99fc87c9a49b4c4a69cc6e88594bf6eb13c DIFF: https://github.com/llvm/llvm-project/commit/ca0ce99fc87c9a49b4c4a69cc6e88594bf6eb13c.diff

[Lldb-commits] [PATCH] D111634: [lldb] Print embedded nuls in char arrays (PR44649)

This revision was automatically updated to reflect the committed changes. Closed by commit rGca0ce99fc87c: [lldb] Print embedded nuls in char arrays (PR44649) (authored by labath). Changed prior to commit: https://reviews.llvm.org/D111634?vs=378988&id=379619#toc Repository: rG LLVM Github Mo

[Lldb-commits] [lldb] 7106f58 - [lldb] Make the thread_local g_global_boundary accessed from a single file

Author: Martin Storsjö Date: 2021-10-14T11:17:20+03:00 New Revision: 7106f588567b59acb17c77f6116ba433b6226333 URL: https://github.com/llvm/llvm-project/commit/7106f588567b59acb17c77f6116ba433b6226333 DIFF: https://github.com/llvm/llvm-project/commit/7106f588567b59acb17c77f6116ba433b6226333.diff

[Lldb-commits] [PATCH] D111779: [lldb] Make the thread_local g_global_boundary accessed from a single file

This revision was automatically updated to reflect the committed changes. Closed by commit rG7106f588567b: [lldb] Make the thread_local g_global_boundary accessed from a single file (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] fa639ed - [lldb] Fix TestStackCorefile.py for ca0ce99fc8

Author: Pavel Labath Date: 2021-10-14T10:38:48+02:00 New Revision: fa639eda6535732a5fd79c3f551d5a667b810963 URL: https://github.com/llvm/llvm-project/commit/fa639eda6535732a5fd79c3f551d5a667b810963 DIFF: https://github.com/llvm/llvm-project/commit/fa639eda6535732a5fd79c3f551d5a667b810963.diff

[Lldb-commits] [PATCH] D108831: [lldb] [ABI/X86] Add pseudo-registers if missing

mgorny added a comment. In D108831#3063282 , @labath wrote: > We don't really want to support adding an arbitrary subset of sub-registers, > do we? I am thinking if this could be made simpler if it was all-or-nothing. > Like, during the initial pass you

[Lldb-commits] [PATCH] D111355: [lldb] Add serial:// protocol for connecting to serial port [WIP/PoC]

mgorny added a comment. I don't really have a strong opinion about this. I think we should leave the option of leaving port settings unchanged. I'll check what gdb does, as I suppose interoperability with gdbserver is also useful. I guess people are more likely to connect to other servers than

[Lldb-commits] [PATCH] D108831: [lldb] [ABI/X86] Add pseudo-registers if missing

labath added a comment. I don't think this is that critical over there, but I think you could do that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://reviews.llvm.org/D108831 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D108831: [lldb] [ABI/X86] Add pseudo-registers if missing

mgorny updated this revision to Diff 379652. mgorny added a comment. Use `ArchSpec` instead of passing hardcoded 64bit. Abort the whole process if at least one subreg is present, eliminating all the `have*` bools. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://review

[Lldb-commits] [PATCH] D108831: [lldb] [ABI/X86] Add pseudo-registers if missing

mgorny updated this revision to Diff 379653. mgorny added a comment. Move `LLDB_INVALID_REGNUM` check inside `addPartialRegister()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://reviews.llvm.org/D108831 Files: lldb/source/Plugins/ABI/X86/ABIX86.cpp lldb/source/

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett created this revision. Herald added a subscriber: dang. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds an option to the memory region command to print all regions at once. Like you can do by starting a

[Lldb-commits] [PATCH] D108831: [lldb] [ABI/X86] Add pseudo-registers if missing

mgorny updated this revision to Diff 379697. mgorny added a comment. Halfway through to a new approach for getting regnames. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://reviews.llvm.org/D108831 Files: lldb/source/Plugins/ABI/X86/ABIX86.cpp lldb/source/Plugins/

[Lldb-commits] [PATCH] D108831: [lldb] [ABI/X86] Add pseudo-registers if missing

labath added inline comments. Comment at: lldb/source/Plugins/ABI/X86/ABIX86.cpp:91 + ArchSpec arch = process_sp->GetTarget().GetArchitecture(); + bool is64bit; + switch (arch.GetMachine()) { I'd just do `is64bit = arch.GetAddressByteSize() == 8` ===

[Lldb-commits] [PATCH] D108831: [lldb] [ABI/X86] Add pseudo-registers if missing

mgorny updated this revision to Diff 379732. mgorny marked 3 inline comments as done. mgorny added a comment. Next iteration. I will try to simplify even more. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://reviews.llvm.org/D108831 Files: lldb/source/Plugins/ABI/X8

[Lldb-commits] [lldb] 722a2fb - [lldb] Fix 'frame diagnose' docstring typo

Author: Dave Lee Date: 2021-10-14T08:32:20-07:00 New Revision: 722a2fb7f9a3f7deea81276213c6a2a48a0827cd URL: https://github.com/llvm/llvm-project/commit/722a2fb7f9a3f7deea81276213c6a2a48a0827cd DIFF: https://github.com/llvm/llvm-project/commit/722a2fb7f9a3f7deea81276213c6a2a48a0827cd.diff LOG:

[Lldb-commits] [PATCH] D108831: [lldb] [ABI/X86] Add pseudo-registers if missing

mgorny updated this revision to Diff 379738. mgorny added a comment. Final round of refactoring. The code should be simpler and more readable now. I don't have a strong opinion wrt generating names in a loop vs hardcoding the list (possibly using a macro). Please decide how I should proceed ;-).

[Lldb-commits] [PATCH] D108831: [lldb] [ABI/X86] Add pseudo-registers if missing

mgorny updated this revision to Diff 379771. mgorny marked an inline comment as done. mgorny added a comment. Use inline lists instead of `for` loops for registers. Use `llvm::SmallDense*` types with `StringRef`s. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://review

[Lldb-commits] [lldb] 78e17e2 - [lldb] Rewrite TestDiamond and document some bugs.

Author: Raphael Isemann Date: 2021-10-14T20:32:07+02:00 New Revision: 78e17e23aa0fe525d00a2e8f0c7469f9a6b94f40 URL: https://github.com/llvm/llvm-project/commit/78e17e23aa0fe525d00a2e8f0c7469f9a6b94f40 DIFF: https://github.com/llvm/llvm-project/commit/78e17e23aa0fe525d00a2e8f0c7469f9a6b94f40.dif

[Lldb-commits] [lldb] e632e90 - [lldb] Remove logging from Platform::~Platform

Author: Raphael Isemann Date: 2021-10-14T20:42:45+02:00 New Revision: e632e900ac1092f581b42fb93662613db9977b5a URL: https://github.com/llvm/llvm-project/commit/e632e900ac1092f581b42fb93662613db9977b5a DIFF: https://github.com/llvm/llvm-project/commit/e632e900ac1092f581b42fb93662613db9977b5a.dif

[Lldb-commits] [PATCH] D111816: [lldb] Remove logging from Platform::~Platform

This revision was automatically updated to reflect the committed changes. Closed by commit rGe632e900ac10: [lldb] Remove logging from Platform::~Platform (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D111816: [lldb] Remove logging from Platform::~Platform

thakis added a comment. http://45.33.8.238/mac/37050/step_4.txt In file included from ../../lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:9: In file included from ../../lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.h:12: In file included from ../../../chrome/src/third_party/llv

[Lldb-commits] [PATCH] D111827: [lldb/API] Add GetIndexInDebugger to SBTarget

mib created this revision. mib added reviewers: jingham, JDevlieghere. mib added a project: LLDB. Herald added a subscriber: arphaman. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds a new SBTarget::GetIndexInDebugger method to the SBAPI. As its nam

[Lldb-commits] [PATCH] D111827: [lldb/API] Add GetIndexInDebugger to SBTarget

JDevlieghere added a comment. We already have `SBDebugger::GetIndexOfTarget`, would that work? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111827/new/ https://reviews.llvm.org/D111827 ___ lldb-commits

[Lldb-commits] [lldb] 482c53f - [lldb] Move ~Platform to source file

Author: Raphael Isemann Date: 2021-10-14T21:36:46+02:00 New Revision: 482c53fa0dce16c0edebb494117dcc8dd383427e URL: https://github.com/llvm/llvm-project/commit/482c53fa0dce16c0edebb494117dcc8dd383427e DIFF: https://github.com/llvm/llvm-project/commit/482c53fa0dce16c0edebb494117dcc8dd383427e.dif

[Lldb-commits] [PATCH] D111816: [lldb] Remove logging from Platform::~Platform

teemperor added a comment. Fixed, thanks! In D111816#3064923 , @thakis wrote: > http://45.33.8.238/mac/37050/step_4.txt > > In file included from > ../../lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:9: > In file included from > ../../lldb/s

[Lldb-commits] [PATCH] D111827: [lldb/API] Add GetIndexInDebugger to SBTarget

mib abandoned this revision. mib added a comment. In D111827#3065040 , @JDevlieghere wrote: > We already have `SBDebugger::GetIndexOfTarget`, would that work? Yes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

clayborg added inline comments. Comment at: lldb/include/lldb/Target/Statistics.h:23 +struct SuccessFailStats { + void Notify(bool success); + wallace wrote: > JDevlieghere wrote: > > I'd use an enum class with `Success` and `Failure` here instead of a bool > >

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

clayborg updated this revision to Diff 379860. clayborg added a comment. Herald added a subscriber: dang. Fixed issues identified in first review round: - typos in comments - create GlobalStats class to contain the global statistics - Make sure all code is using the new StatsClock, StatsDuration,

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

clayborg added a comment. Ok, take a look now. I added a GlobalStats class that contains the "enable/disable" state of the statistics gathering. This shows how things can be organized and dumped. A few things about the current approach: Stats classes in Statistics.h are designed to be able to

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

clayborg added a comment. Right now if you run: (lldb) statistics dump It will dump stats for the current target only as one target dictionary. We can change this if desired. (lldb) statistics dump --all-targets will dump an dictionary that contains a top level "targets" key/value pair where the

[Lldb-commits] [PATCH] D108831: [lldb] [ABI/X86] Add pseudo-registers if missing

mgorny updated this revision to Diff 379921. mgorny added a comment. Use `ConstString::GetStringRef()` directly instead of converting through `const char *`. Not that it has any practical difference right now… CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://reviews.ll

[Lldb-commits] [lldb] 7c704c0 - [NFC] fix a typo

Author: Shao-Ce SUN Date: 2021-10-15T14:51:49+08:00 New Revision: 7c704c0f53bd7f785ec99fc6bedd71569816a28c URL: https://github.com/llvm/llvm-project/commit/7c704c0f53bd7f785ec99fc6bedd71569816a28c DIFF: https://github.com/llvm/llvm-project/commit/7c704c0f53bd7f785ec99fc6bedd71569816a28c.diff L

[Lldb-commits] [lldb] 35d7101 - Use Module's FileSpec for limiting binaries to set dyld breakpoint in

Author: Jason Molenda Date: 2021-10-14T23:58:23-07:00 New Revision: 35d710148b98e2ec52056271e7f9103620593b7a URL: https://github.com/llvm/llvm-project/commit/35d710148b98e2ec52056271e7f9103620593b7a DIFF: https://github.com/llvm/llvm-project/commit/35d710148b98e2ec52056271e7f9103620593b7a.diff