[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

mgorny added a comment. In D110535#3047033 , @joerg wrote: > Can't you wrap `iterator_range` and possibly even support Twines like > that? That is, don't extend the life time of the iterators, but store it in > the range? I can but @labath didn't want

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

labath added a comment. In D110535#3047262 , @mgorny wrote: > In D110535#3047033 , @joerg wrote: > >> Can't you wrap `iterator_range` and possibly even support Twines like >> that? That is, don't extend the life

Re: [Lldb-commits] [lldb] 10f16bc - Revert "[lldb] [ABI/X86] Split base x86 and i386 classes"

On 06/10/2021 19:57, Stella Stamenova via lldb-commits wrote: Author: Stella Stamenova Date: 2021-10-06T10:56:45-07:00 New Revision: 10f16bc7b2bfa0fb3589ac62fc8392854a3a2226 URL: https://github.com/llvm/llvm-project/commit/10f16bc7b2bfa0fb3589ac62fc8392854a3a2226 DIFF: https://github.com/llvm

[Lldb-commits] [PATCH] D111295: [lldb] [Target] Make addSupplementaryRegister() work on RRI vector

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. mgorny requested review of this revision. Move DynamicRegisterInfo::AddSupplementaryRegister() into a standalone function working on std::vector. This will make it possible to use it without DynamicRegis

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 09/17: Include main unit DWARFUnit * inside DWARFDIEs

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96236/new/ https://reviews.llvm.org/D96236 ___

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 09/17: Pass main DWARFUnit * along DWARFDIEs

jankratochvil updated this revision to Diff 374770. jankratochvil retitled this revision from "[lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs" to "[lldb] DWZ 09/17: Pass main DWARFUnit * along DWARFDIEs". Herald added a subscriber: mgorny. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs

jankratochvil added a comment. Asking LLDB community whether to continue with this patchset upstreaming: Its advantage is sure compatibility with DWZ being used by {RHEL,CentOS}-{7,8}. The next version of {RHEL,CentOS} will use it as well. By my quick check Debian 12=Bookworm=testing is not usin

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add pseudo-regs if missing

mgorny updated this revision to Diff 377792. mgorny added a comment. Rewrite for `std::vector`-based augmentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109876/new/ https://reviews.llvm.org/D109876 Files: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp lldb/source/Target/Dyn

[Lldb-commits] [lldb] 81a2f39 - [lldb/gdb-remote] Delete SendPacketsAndConcatenateResponses

Author: Pavel Labath Date: 2021-10-07T13:09:27+02:00 New Revision: 81a2f39307a1f2169203abeb66c7bb00b5496edc URL: https://github.com/llvm/llvm-project/commit/81a2f39307a1f2169203abeb66c7bb00b5496edc DIFF: https://github.com/llvm/llvm-project/commit/81a2f39307a1f2169203abeb66c7bb00b5496edc.diff

[Lldb-commits] [lldb] 322e13b - [lldb] Rewrite/expand TestCppTypedef and document a lookup bug.

Author: Raphael Isemann Date: 2021-10-07T13:30:03+02:00 New Revision: 322e13b91aac23ab324c3dcbbcfe8e73894f4c28 URL: https://github.com/llvm/llvm-project/commit/322e13b91aac23ab324c3dcbbcfe8e73894f4c28 DIFF: https://github.com/llvm/llvm-project/commit/322e13b91aac23ab324c3dcbbcfe8e73894f4c28.dif

[Lldb-commits] [PATCH] D111295: [lldb] [Target] Make addSupplementaryRegister() work on RRI vector

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. I'm not sure about the RemoteRegisterInfo name, but that's a topic for the patch that introduces it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111295/new/ https://rev

[Lldb-commits] [PATCH] D111142: [lldb] [ABI] Apply AugmentRegisterInfo() to RemoteRegisterInfos

labath added a comment. I like everything except the class name. :) I don't think it makes sense in the new location, and ideally I'd like to also use this for other plugins in the future (so that e.g. core file plugins don't have to excruciatingly list everything). Maybe we could move it into

[Lldb-commits] [PATCH] D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack

tatyana-krasnukha added a comment. Added inline comment Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2842 - OverrideExecutionContext(m_debugger.GetSelectedExecutionContext()); - auto finalize = llvm::make_scope_exit([this]() { -RestoreExecutionContext(); +

[Lldb-commits] [PATCH] D111142: [lldb] [ABI] Apply AugmentRegisterInfo() to RemoteRegisterInfos

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/include/lldb/Target/DynamicRegisterInfo.h:80-82 + lldb_private::RegisterInfo * + GetRegisterInfo(llvm::StringRef reg_name); + labath wrote: > What's up with this? Probably l

[Lldb-commits] [PATCH] D111142: [lldb] [ABI] Apply AugmentRegisterInfo() to DynamicRegisterInfo::Registers

mgorny updated this revision to Diff 377831. mgorny marked an inline comment as done. mgorny retitled this revision from "[lldb] [ABI] Apply AugmentRegisterInfo() to RemoteRegisterInfos" to "[lldb] [ABI] Apply AugmentRegisterInfo() to DynamicRegisterInfo::Registers". mgorny edited the summary of

[Lldb-commits] [PATCH] D111295: [lldb] [Target] Make addSupplementaryRegister() work on Register vector

mgorny updated this revision to Diff 377833. mgorny retitled this revision from "[lldb] [Target] Make addSupplementaryRegister() work on RRI vector" to "[lldb] [Target] Make addSupplementaryRegister() work on Register vector". mgorny edited the summary of this revision. mgorny added a comment. R

[Lldb-commits] [PATCH] D111295: [lldb] [Target] Make addSupplementaryRegister() work on Register vector

mgorny updated this revision to Diff 377834. mgorny added a comment. Remove duplicate `ASSERT_REG`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111295/new/ https://reviews.llvm.org/D111295 Files: lldb/include/lldb/Target/DynamicRegisterInfo.h lldb/source/Target/DynamicRegisterInf

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add pseudo-regs if missing

mgorny updated this revision to Diff 377835. mgorny added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109876/new/ https://reviews.llvm.org/D109876 Files: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp lldb/test/API/functionalities/gdb_remote_client/TestGDBServe

[Lldb-commits] [lldb] ecfab0b - [lldb] [DynamicRegisterInfo] Support iterating over registers()

Author: Michał Górny Date: 2021-10-07T16:07:04+02:00 New Revision: ecfab0b6f581c69b3e3e8b230f97a84f317bbec2 URL: https://github.com/llvm/llvm-project/commit/ecfab0b6f581c69b3e3e8b230f97a84f317bbec2 DIFF: https://github.com/llvm/llvm-project/commit/ecfab0b6f581c69b3e3e8b230f97a84f317bbec2.diff

[Lldb-commits] [PATCH] D111136: [lldb] [DynamicRegisterInfo] Support iterating over registers()

This revision was automatically updated to reflect the committed changes. Closed by commit rGecfab0b6f581: [lldb] [DynamicRegisterInfo] Support iterating over registers() (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D111314: [lldb] [ConnectionFileDescriptorPosix] Use a single NativeFile

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. mgorny requested review of this revision. Replace separate read and write NativeFile instances with a single instance shared for reading and writing. There is no clear indication why two instances were u

[Lldb-commits] [lldb] 80e3936 - [lldb, mlir] Migrate from getNumArgOperands and arg_operands (NFC)

Author: Kazu Hirata Date: 2021-10-07T08:29:42-07:00 New Revision: 80e39366ee403ac420f2087883550398e5fbf968 URL: https://github.com/llvm/llvm-project/commit/80e39366ee403ac420f2087883550398e5fbf968 DIFF: https://github.com/llvm/llvm-project/commit/80e39366ee403ac420f2087883550398e5fbf968.diff L

[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/examples/python/scripted_process/my_scripted_process.py:126 def get_register_context(self) -> str: -return struct.pack( -

[Lldb-commits] [PATCH] D111321: [lldb] [ConnectionFileDescriptorPosix] Refactor scheme matching

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. mgorny requested review of this revision. Move the POSIX-specific fd:// and file:// scheme handling into separate methods. Replace the custom GetURLAddress() matching with splitting into scheme and path,

[Lldb-commits] [lldb] 5ecdb77 - [lldb] Mark abort signal test unsupported on AArch64 Linux

Author: David Spickett Date: 2021-10-07T16:09:47Z New Revision: 5ecdb77fc5e71daf994d39840fbe753f46aeca43 URL: https://github.com/llvm/llvm-project/commit/5ecdb77fc5e71daf994d39840fbe753f46aeca43 DIFF: https://github.com/llvm/llvm-project/commit/5ecdb77fc5e71daf994d39840fbe753f46aeca43.diff LOG

[Lldb-commits] [lldb] 3d7d543 - [lldb] Fix a "missing field" warning

Author: Kazu Hirata Date: 2021-10-07T10:25:05-07:00 New Revision: 3d7d5437433c16fd4a9a3674d3752c246961d70e URL: https://github.com/llvm/llvm-project/commit/3d7d5437433c16fd4a9a3674d3752c246961d70e DIFF: https://github.com/llvm/llvm-project/commit/3d7d5437433c16fd4a9a3674d3752c246961d70e.diff L

[Lldb-commits] [PATCH] D110298: Add "command multiword add" and the ability to add script commands into a user multiword hierarchy

JDevlieghere added a comment. A few more nits as I was reading through the code, but this generally LGTM. Comment at: lldb/source/Commands/CommandCompletions.cpp:811-813 + sort(to_delete.begin(), to_delete.end(), std::greater()); + for (size_t idx : to_delete) +args.Delet

[Lldb-commits] [PATCH] D111321: [lldb] [ConnectionFileDescriptorPosix] Refactor scheme matching

mgorny updated this revision to Diff 377948. mgorny added a comment. Rebase to match the original termios code without other of my patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111321/new/ https://reviews.llvm.org/D111321 Files: lldb/include/lldb/Host/posix/ConnectionFileDes

[Lldb-commits] [PATCH] D111030: [lldb] [Host] Add setters for common teletype properties to Terminal

mgorny updated this revision to Diff 377949. mgorny added a comment. Remove the changes to ConnectionFileDescriptorPosix from this patch. Now it's purely new Terminal API. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111030/new/ https://reviews.llvm.org/D111030 Files: lldb/include/

[Lldb-commits] [PATCH] D110997: [lldb] Restore tty attributes on disconnect

mgorny abandoned this revision. mgorny added a comment. If at all, this will be part of the new serial port API. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110997/new/ https://reviews.llvm.org/D110997 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D111339: [lldb] Parse and display reporting errors from JSON crashlogs

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, aprantl. JDevlieghere requested review of this revision. JSON crashlogs have an optional field named `reportNotes` that contains any potential errors encountered by the crash reporter when generating the crashlog. Parse a

[Lldb-commits] [PATCH] D111341: [lldb] Support missing threadState in JSON crashlogs

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, aprantl. JDevlieghere requested review of this revision. Gracefully deal with JSON crashlogs that don't have thread state available and print an error saying as much: "No thread state (register information) available". rda

[Lldb-commits] [PATCH] D111278: Recognize the Swift compiler in DW_AT_producer

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:684 + llvm::SmallVector matches; + if (g_swiftlang_version_regex.Execute(producer, &matches)) { + m_producer_version.tryParse(matches[1]); JDevlieghere wrote: > F

[Lldb-commits] [PATCH] D111278: Recognize the Swift compiler in DW_AT_producer

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:684 + llvm::SmallVector matches; + if (g_swiftlang_version_regex.Execute(producer, &matches)) { + m_producer_version.tryParse(matches[1]); aprantl wrote: > JDevli

[Lldb-commits] [PATCH] D111278: Recognize the Swift compiler in DW_AT_producer

aprantl updated this revision to Diff 377977. aprantl added a comment. Const. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111278/new/ https://reviews.llvm.org/D111278 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h lldb

[Lldb-commits] [PATCH] D111278: Recognize the Swift compiler in DW_AT_producer

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:684 + llvm::SmallVector matches; + if (g_swiftlang_version_regex.Execute(producer, &matches)

[Lldb-commits] [PATCH] D111339: [lldb] Parse and display reporting errors from JSON crashlogs

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. sgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111339/new/ https://reviews.llvm.org/D111339 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] 4651576 - Recognize the Swift compiler in DW_AT_producer

Author: Adrian Prantl Date: 2021-10-07T13:54:28-07:00 New Revision: 4651576edd09bb4b0978db8592e938484e7bbd4f URL: https://github.com/llvm/llvm-project/commit/4651576edd09bb4b0978db8592e938484e7bbd4f DIFF: https://github.com/llvm/llvm-project/commit/4651576edd09bb4b0978db8592e938484e7bbd4f.diff

[Lldb-commits] [PATCH] D111278: Recognize the Swift compiler in DW_AT_producer

This revision was automatically updated to reflect the committed changes. Closed by commit rG4651576edd09: Recognize the Swift compiler in DW_AT_producer (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D111278?vs=377977&id=378001#toc Repos

[Lldb-commits] [PATCH] D111355: [lldb] Add serial:// protocol for connecting to serial port [WIP/PoC]

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. mgorny requested review of this revision. Add a new serial:// protocol along with SerialPort that provides a new API to open serial ports. The URL consists of serial device path followed by URL-style opt

[Lldb-commits] [lldb] b913065 - [lldb] Support missing threadState in JSON crashlogs

Author: Jonas Devlieghere Date: 2021-10-07T15:53:52-07:00 New Revision: b913065bf470bcaf1ee8ff8b6a647b877110a4ba URL: https://github.com/llvm/llvm-project/commit/b913065bf470bcaf1ee8ff8b6a647b877110a4ba DIFF: https://github.com/llvm/llvm-project/commit/b913065bf470bcaf1ee8ff8b6a647b877110a4ba.d

[Lldb-commits] [lldb] b225c5f - [lldb] Parse and display reporting errors from JSON crashlogs

Author: Jonas Devlieghere Date: 2021-10-07T15:53:52-07:00 New Revision: b225c5f7861c7f99de3d52dc1ed23e358c5cce36 URL: https://github.com/llvm/llvm-project/commit/b225c5f7861c7f99de3d52dc1ed23e358c5cce36 DIFF: https://github.com/llvm/llvm-project/commit/b225c5f7861c7f99de3d52dc1ed23e358c5cce36.d

[Lldb-commits] [PATCH] D111341: [lldb] Support missing threadState in JSON crashlogs

This revision was automatically updated to reflect the committed changes. Closed by commit rGb913065bf470: [lldb] Support missing threadState in JSON crashlogs (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D111339: [lldb] Parse and display reporting errors from JSON crashlogs

This revision was automatically updated to reflect the committed changes. Closed by commit rGb225c5f7861c: [lldb] Parse and display reporting errors from JSON crashlogs (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt