[Lldb-commits] [PATCH] D108717: Fix Reference case for TypeSystemClang::GetChildCompilerTypeAtIndex(...) to avoid possible invalid cast

teemperor added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:6505 if (idx_is_valid) { - const clang::ReferenceType *reference_type = - llvm::cast(GetQualType(type).getTypePtr()); - CompilerType pointee_clang_type =

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/functionalities/dyld-launch-linux/TestDyldLaunchLinux.py:13 + +def test(self): +self.build() Could

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp:225 +m.SizeOfImage = static_cast( +mod->GetObjectFile()->GetByteSize()); +m.Checksum = static_cast(0); clayborg wrote: > I am not sure if the

[Lldb-commits] [PATCH] D108768: [lldb] [DynamicRegisterInfo] Fix mistaken reg type when calculating offsets

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jasonmolenda, JDevlieghere. mgorny requested review of this revision. Fix the DynamicRegisterInfo::ConfigureOffsets() method to treat value_regs as local register numbers (eRegisterKindLLDB) rather than gdb-remote n

[Lldb-commits] [PATCH] D108768: [lldb] [DynamicRegisterInfo] Fix mistaken reg type when calculating offsets

mgorny planned changes to this revision. mgorny added a comment. `TestRemoteRegNums` suggests that there's also code relying on remote regnums being used there. What a mess :-(. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108768/new/ https://reviews.llvm.org/D108768

[Lldb-commits] [lldb] 600a2a7 - [NFC] Remove deprecated Intel PT test

Author: Walter Erquinigo Date: 2021-08-26T10:34:04-07:00 New Revision: 600a2a7ec07aa0215c094d2d8b4c0325189ad30d URL: https://github.com/llvm/llvm-project/commit/600a2a7ec07aa0215c094d2d8b4c0325189ad30d DIFF: https://github.com/llvm/llvm-project/commit/600a2a7ec07aa0215c094d2d8b4c0325189ad30d.di

[Lldb-commits] [lldb] c62ef02 - [NFC] Removing deprecated intel-features test folder

Author: Walter Erquinigo Date: 2021-08-26T10:36:00-07:00 New Revision: c62ef0255d904fdd99173493e8e064a2dde598e8 URL: https://github.com/llvm/llvm-project/commit/c62ef0255d904fdd99173493e8e064a2dde598e8 DIFF: https://github.com/llvm/llvm-project/commit/c62ef0255d904fdd99173493e8e064a2dde598e8.di

[Lldb-commits] [PATCH] D108257: Add type to the output for FieldDecl when logging in ClangASTSource::layoutRecordType

shafik updated this revision to Diff 368935. shafik added a comment. Applying formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108257/new/ https://reviews.llvm.org/D108257 Files: lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp Index: lldb/source/Plugins/Expres

[Lldb-commits] [lldb] 2a4a498 - [LLDB] Add type to the output for FieldDecl when logging in ClangASTSource::layoutRecordType

Author: Shafik Yaghmour Date: 2021-08-26T11:17:47-07:00 New Revision: 2a4a498a884ad929dad5dc72e20c76adfecfc78c URL: https://github.com/llvm/llvm-project/commit/2a4a498a884ad929dad5dc72e20c76adfecfc78c DIFF: https://github.com/llvm/llvm-project/commit/2a4a498a884ad929dad5dc72e20c76adfecfc78c.dif

[Lldb-commits] [PATCH] D108257: Add type to the output for FieldDecl when logging in ClangASTSource::layoutRecordType

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a4a498a884a: [LLDB] Add type to the output for FieldDecl when logging in ClangASTSource… (authored by shafik). Herald added a project: LLDB. Reposi

[Lldb-commits] [PATCH] D108768: [lldb] [DynamicRegisterInfo] Fix mistaken reg type when calculating offsets

mgorny abandoned this revision. mgorny added a comment. Ok, I think it might just be `Dump()` being broken. I've found another bug with my code, and things seem to work after fixing it, so I suppose the problem is not really worth my effort right now. CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa updated this revision to Diff 368988. rdhindsa marked 6 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108061/new/ https://reviews.llvm.org/D108061 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa marked 2 inline comments as done and an inline comment as not done. rdhindsa added a comment. This patch caused a test failure when it was submitted two days ago, so I reverted it that day. However, I have not been able to reproduce the failure locally even using the cmake config from b

[Lldb-commits] [lldb] 3784fc4 - Remove set-but-unused variable

Author: David Blaikie Date: 2021-08-26T16:58:47-07:00 New Revision: 3784fc493eb254bbed422f0bc83f01bee94a8195 URL: https://github.com/llvm/llvm-project/commit/3784fc493eb254bbed422f0bc83f01bee94a8195 DIFF: https://github.com/llvm/llvm-project/commit/3784fc493eb254bbed422f0bc83f01bee94a8195.diff