[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:289 fprintf(stderr, "failed to create acceptor: %s", error.AsCString()); -exit(socket_error)

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

kimanh updated this revision to Diff 367758. kimanh marked 2 inline comments as done. kimanh added a comment. - Incorporating Jan's patch - Adding error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107456/new/ https://reviews.llvm.org/D107

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

kimanh added a comment. Thanks a lot for the review! Very sorry for my late update, I was out on vacation and then had to catch up with mails. Updated the revision now. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:537 +if (const llvm::DWARFUnitIndex::Entr

[Lldb-commits] [PATCH] D108395: [lldb] Delete IRExecutionUnit::CollectCandidateCPlusPlusNames

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I'm very supportive of the idea that we delete everything that isn't tested :) (and I'm only partly joking here). However removing this should cause a bunch of test failures on

[Lldb-commits] [PATCH] D108468: [lldb] [gdb-remote] Fix displaying i387_ext & vec regs with gdbserver

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, JDevlieghere, jasonmolenda. mgorny requested review of this revision. Adjust the encoding and format applied to i387_ext and vec* type registers from gdbserver to match lldb-server. Both types are now displayed as

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz marked 5 inline comments as done. saschwartz added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:289 fprintf(stderr, "failed to create acceptor: %s", error.AsCString()); -exit(socket_error); +return -1; } teemper

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz updated this revision to Diff 367815. saschwartz added a comment. Stick with integer return codes from lldb-platform Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 Files: lldb/test/Shell/lld

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! I'll merge this on Monday when I have time to watch the bots (unless ofc someone else merges this before then). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D108395: [lldb] Delete IRExecutionUnit::CollectCandidateCPlusPlusNames

bulbazord added a comment. In D108395#2957194 , @teemperor wrote: > I'm very supportive of the idea that we delete everything that isn't tested > :) (and I'm only partly joking here). I can sympathize, I'm only partly serious with this change! :D > How

[Lldb-commits] [lldb] 40aab04 - [test] Migrate -gcc-toolchain with space separator to --gcc-toolchain=

Author: Fangrui Song Date: 2021-08-20T15:24:58-07:00 New Revision: 40aab0412fe7a14781e133627c2bb0a22761eac8 URL: https://github.com/llvm/llvm-project/commit/40aab0412fe7a14781e133627c2bb0a22761eac8 DIFF: https://github.com/llvm/llvm-project/commit/40aab0412fe7a14781e133627c2bb0a22761eac8.diff