[Lldb-commits] [PATCH] D108228: Fix error handling in the libcxx std::string formatter

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. You could land all the formatting changes as its own commit just to make it clear that this is adding one `if (error)` and the other line changes are formatting updates. But I

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

OmarEmaraDev updated this revision to Diff 367171. OmarEmaraDev added a comment. - Address review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107869/new/ https://reviews.llvm.org/D107869 Files: lldb/include/lldb/Target/Target.h lldb/source/C

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat added a comment. Should I send this somehow back to review? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104413/new/ https://reviews.llvm.org/D104413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

teemperor added a comment. In D104413#2952057 , @PatriosTheGreat wrote: > Should I send this somehow back to review? Nope, this is (as it should be) in the review queue but I just didn't get around to this yet. Sorry for the delay, I'll try to take a l

[Lldb-commits] [PATCH] D108229: [lldb] Refactor Module::LookupInfo constructor

bulbazord updated this revision to Diff 367244. bulbazord added a comment. Delete now unused variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108229/new/ https://reviews.llvm.org/D108229 Files: lldb/include/lldb/Core/Module.h lldb/includ

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

rdhindsa updated this revision to Diff 367286. rdhindsa marked 7 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105732/new/ https://reviews.llvm.org/D105732 Files: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp Index

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa added a comment. I checked the status with both gdb and lldb using test case added here. It looks like breakpoint on main doesn't get hit even for gdb when called through ld.so. However, breakpoint on shared library functions is supported by gdb. With this patch, we are now able to set

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

JDevlieghere accepted this revision. JDevlieghere added a comment. Small nit about the comments, but otherwise LGTM Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:160 +// Don't close first three entries since they are +// stdin/stdout/stderr +

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

rdhindsa updated this revision to Diff 367311. rdhindsa added a comment. Updated comments as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105732/new/ https://reviews.llvm.org/D105732 Files: lldb/source/Host/posix/ProcessLauncherPosix

[Lldb-commits] [PATCH] D108327: [LLDB][GUI] Fix text field incorrect key handling

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The isprint libc function was used to determine if the key code re

[Lldb-commits] [PATCH] D108331: [LLDB][GUI] Handle return key for compound fields

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch handles the return key for compound fields like lists a

[Lldb-commits] [PATCH] D108228: Fix error handling in the libcxx std::string formatter

dblaikie added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string/main.cpp:102 +std::string *not_a_string = (std::string *) 0x0; +touch_string(*not_a_string); return 0; teemperor wrote: > dblai

[Lldb-commits] [PATCH] D108327: [LLDB][GUI] Fix text field incorrect key handling

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. This works much better now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108327/new/ https://reviews.llvm.org/D108327

[Lldb-commits] [PATCH] D108327: [LLDB][GUI] Fix text field incorrect key handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG698e2106362a: [LLDB][GUI] Fix text field incorrect key handling (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Mono

[Lldb-commits] [lldb] 698e210 - [LLDB][GUI] Fix text field incorrect key handling

Author: Omar Emara Date: 2021-08-18T15:06:27-07:00 New Revision: 698e2106362add2bd3aca6f8ffebe9dd90a50529 URL: https://github.com/llvm/llvm-project/commit/698e2106362add2bd3aca6f8ffebe9dd90a50529 DIFF: https://github.com/llvm/llvm-project/commit/698e2106362add2bd3aca6f8ffebe9dd90a50529.diff LO

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Work well now on macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107869/new/ https://reviews.llvm.org/D107869

[Lldb-commits] [PATCH] D108335: [lldb] Move UnixSignals subclasses to lldbTarget

bulbazord created this revision. bulbazord added reviewers: LLDB, clayborg, jingham, teemperor, JDevlieghere. Herald added subscribers: atanasyan, jrtc27, mgorny, sdardis, emaste. bulbazord requested review of this revision. Herald added a project: LLDB. I have created this change as a way to soli

[Lldb-commits] [lldb] 82507f1 - [LLDB][GUI] Add Process Launch form

Author: Omar Emara Date: 2021-08-18T15:43:30-07:00 New Revision: 82507f1798768280cf5d5aab95caaafbc7fe6f47 URL: https://github.com/llvm/llvm-project/commit/82507f1798768280cf5d5aab95caaafbc7fe6f47 DIFF: https://github.com/llvm/llvm-project/commit/82507f1798768280cf5d5aab95caaafbc7fe6f47.diff LO

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82507f179876: [LLDB][GUI] Add Process Launch form (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D108078: [lldb] Support gdbserver signals

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1344 "qEcho+", + "native-signals+", };

[Lldb-commits] [PATCH] D108078: [lldb] Support gdbserver signals

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Didn't mean to accept yet (originally I thought the native-signals check was inverted) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108078/new/ https://reviews

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid added a comment. Sorry, I haven't forgotten about this. Haven't had time to sit down for a proper debugging session this or last week. I definitely still plan to update and resend for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz created this revision. saschwartz added a reviewer: clayborg. saschwartz requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diff modifies the LLDB server return codes to more accurately reflect usage error paths. It additionall

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz updated this revision to Diff 367397. saschwartz added a comment. Fix unannotated fallthrough in switch statement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 Files: lldb/test/Shell/lldb-

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz updated this revision to Diff 367401. saschwartz added a comment. Also propagate platform mode return codes and add additional test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 Files: