[Lldb-commits] [PATCH] D107182: [LLDB][GUI] Refactor form drawing using subsurfaces

OmarEmaraDev added a comment. @jasonmolenda `is_pad` is defined by ncurses. According to the man page, it is an extension that is `not supported on Version 7, BSD or System V implementations.`, but that shouldn't be a problem as far as I know. Can you maybe check the ncurses header and see if

[Lldb-commits] [PATCH] D107182: [LLDB][GUI] Refactor form drawing using subsurfaces

OmarEmaraDev added a comment. `is_pad` was added in 2009 in ncurses 5.7 - patch 20090906. So it is sufficiently old to be used, is it not? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107182/new/ https://reviews.llvm.org/D107182

[Lldb-commits] [PATCH] D107625: Add a stack-memory-only style for Darwin process save-core

jasonmolenda created this revision. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. After adding the "dirty memory only" coredump style, I've been wondering how small a corefile I could get by only saving stack memory.

[Lldb-commits] [PATCH] D107182: [LLDB][GUI] Refactor form drawing using subsurfaces

jasonmolenda added a comment. In D107182#2930541 , @OmarEmaraDev wrote: > `is_pad` was added in 2009 in ncurses 5.7 - patch 20090906. So it is > sufficiently old to be used, is it not? Thanks Omar, I didn't know that. I was building on macOS 11.5.1 (c

[Lldb-commits] [PATCH] D107625: Add a stack-memory-only style for Darwin process save-core

jasonmolenda updated this revision to Diff 364731. jasonmolenda added a comment. Handle a bit of state tracking in ObjectFileMachO a little bit more readably. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107625/new/ https://reviews.llvm.org/D10762

[Lldb-commits] [PATCH] D107182: [LLDB][GUI] Refactor form drawing using subsurfaces

OmarEmaraDev added a comment. @jasonmolenda Okay, I will just reimplement the patch without `is_pad` somehow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107182/new/ https://reviews.llvm.org/D107182 __

[Lldb-commits] [PATCH] D107182: [LLDB][GUI] Refactor form drawing using subsurfaces

jasonmolenda added a comment. In D107182#2930666 , @OmarEmaraDev wrote: > @jasonmolenda Okay, I will just reimplement the patch without `is_pad` > somehow. Thanks! Sorry it's so very old. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D105182: [lldb] Add "memory tag write" command

DavidSpickett added a comment. > Many different types of memory tagging exist, MTE is but one. Sure. I'm not opposed to making changes to adapt to the properties of different tags. However the most concrete one I have access to it MTE so that has shaped the initial support and assumptions. > C

[Lldb-commits] [PATCH] D107213: Disassemble AArch64 pc-relative address calculations & symbolicate

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp:1328 +(m_adrp_insn & 0x9f00) == 0x9000 && +(m_adrp_insn & 0x1f) == ((value >> 5) & 0x1f)) { + // Bitmasking lifted from MachODump

[Lldb-commits] [PATCH] D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance

mgorny updated this revision to Diff 364781. mgorny added a comment. Add tests for server and client. Fix error handling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107475/new/ https://reviews.llvm.org/D107475 Files: lldb/docs/lldb-platform-packets.txt lldb/source/Plugins/Proces

[Lldb-commits] [lldb] 825a08f - [lldb] Fix TestFunctionStarts.py on AS

Author: Jonas Devlieghere Date: 2021-08-06T09:03:01-07:00 New Revision: 825a08f898f0eb727408e67fb75acc1ebdc1b85b URL: https://github.com/llvm/llvm-project/commit/825a08f898f0eb727408e67fb75acc1ebdc1b85b DIFF: https://github.com/llvm/llvm-project/commit/825a08f898f0eb727408e67fb75acc1ebdc1b85b.d

[Lldb-commits] [PATCH] D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names

jankratochvil created this revision. jankratochvil added reviewers: kimanh, labath, clayborg. jankratochvil added a project: LLDB. Herald added subscribers: JDevlieghere, arphaman. jankratochvil requested review of this revision. As this issue is a bit difficult to debug it is better to make it sa

[Lldb-commits] [PATCH] D106270: [DWARF5] Fix offset check when using .debug_names

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/find-variable-file.cpp:34 +// RUN: %clang -c -o %t-2.o --target=x86_64-pc-linux -gdwarf-5 -gsplit-dwarf -

[Lldb-commits] [PATCH] D105182: [lldb] Add "memory tag write" command

jrtc27 added a comment. In D105182#2930795 , @DavidSpickett wrote: >> Many different types of memory tagging exist, MTE is but one. > > Sure. I'm not opposed to making changes to adapt to the properties of > different tags. However the most concrete one

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

JDevlieghere created this revision. JDevlieghere added reviewers: friss, jingham. JDevlieghere requested review of this revision. Upstream support for NSConstantArray, NSConstantIntegerNumber, NSConstant{Float,Double}Number and NSConstantDictionary. We would've upstreamed this earlier but testin

[Lldb-commits] [PATCH] D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names

clayborg added a comment. Can we not just grab the skeleton unit when/if needed instead of asserting in many places? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107659/new/ https://reviews.llvm.org/D107659 __

[Lldb-commits] [PATCH] D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names

jankratochvil updated this revision to Diff 364861. jankratochvil added a comment. In D107659#2931836 , @clayborg wrote: > Can we not just grab the skeleton unit when/if needed instead of asserting in > many places? I agree it could be unified for API s

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Just a few little nits. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:509 +float flt_value = 0.0f; +memcpy(&flt_value, &flt_as_int, sizeof(flt_a

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

JDevlieghere updated this revision to Diff 364869. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. - Use `ReadPointerFromMemory` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107660/new/ https://reviews.llvm.org/D107660 Files: lldb/source/Plugins/Language

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:509 +float flt_value = 0.0f; +memcpy(&flt_value, &flt_as_int, sizeof(flt_as_int)); +NSNumber_FormatFloat(valobj, stream, flt_value, options.GetLanguage()); jin

[Lldb-commits] [PATCH] D107664: [lldb] [Commands] Remove 'append' from 'platform file open' mode

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jasonmolenda, JDevlieghere, clayborg. mgorny requested review of this revision. Remove File::eOpenOptionAppend from the mode used by 'platform file open' command. According to POSIX, O_APPEND causes all successive

[Lldb-commits] [PATCH] D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance

mgorny updated this revision to Diff 364873. mgorny added a comment. Fix `vFile:pread` to actually return the underlying error in client. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107475/new/ https://reviews.llvm.org/D107475 Files: lldb/docs/lldb-platform-packets.txt lldb/sourc

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. If the float/double pattern wasn't introduced here, then it's fine by me to fix it in a follow-on patch. Otherwise, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107660/new/

[Lldb-commits] [PATCH] D107665: [lldb] [Commands] Fix reporting errors in 'platform file read/write'

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jasonmolenda, clayborg, JDevlieghere. mgorny requested review of this revision. Fix 'platform file read' and 'platform file write' commands to correctly detect erraneous return and report it as such. Currently, er

[Lldb-commits] [lldb] 9ed7416 - [lldb] Try harder to find the __NSCFBoolean addresses

Author: Fred Riss Date: 2021-08-06T13:04:29-07:00 New Revision: 9ed7416aaf257b13079b48f856df9b45d783fab2 URL: https://github.com/llvm/llvm-project/commit/9ed7416aaf257b13079b48f856df9b45d783fab2 DIFF: https://github.com/llvm/llvm-project/commit/9ed7416aaf257b13079b48f856df9b45d783fab2.diff LOG

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

the tree, are they not? In this case, they seem redundant to me. Similarly, the address takes a lot of space and is included in the next level of details, so it might not be as important to include in this level either. F18404076: 20210806-225259.png <https://reviews.llvm.org/F18404076>

[Lldb-commits] [PATCH] D107669: Create "process trace save" command

hanbingwang created this revision. hanbingwang added reviewers: wallace, clayborg. Herald added subscribers: dang, mgorny. hanbingwang requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. added new command "process trace save -d ". -it only supp

[Lldb-commits] [PATCH] D107669: [trace] [intel pt] Create a "process trace save" command

hanbingwang updated this revision to Diff 364893. hanbingwang added a comment. fix a typo. change a string "the trace of ..." from "the trace or ..." CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107669/new/ https://reviews.llvm.org/D107669 Files: lldb/include/lldb/Target/Trace.h l

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

elete a breakpoint. I don't have a strong opinion about the addresses, but I think you do need the breakpoint & location ID's in the UI somewhere. > Similarly, the address takes a lot of space and is included in the next level > of details, so it might not be as important t

[Lldb-commits] [lldb] f362b05 - Add a "current" token to the ThreadID option to break set/modify.

Author: Jim Ingham Date: 2021-08-06T15:29:55-07:00 New Revision: f362b05d0dcd176348f19a63f8b7f4d4c0498bba URL: https://github.com/llvm/llvm-project/commit/f362b05d0dcd176348f19a63f8b7f4d4c0498bba DIFF: https://github.com/llvm/llvm-project/commit/f362b05d0dcd176348f19a63f8b7f4d4c0498bba.diff LO

[Lldb-commits] [PATCH] D107015: Add "current" token for the -t option to "break set/modify"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf362b05d0dcd: Add a "current" token to the ThreadID option to brea

[Lldb-commits] [PATCH] D107673: Use LC_DYLD_EXPORTS_TRIE to locate the dyld trie structure if present

jingham created this revision. jingham added a reviewer: JDevlieghere. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The pointer to the dyld trie data structure which lldb needs to parse to get "trampoline kinds" on Darwin used t

[Lldb-commits] [PATCH] D107673: Use LC_DYLD_EXPORTS_TRIE to locate the dyld trie structure if present

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107673/new/ https://reviews.llvm.org/D107673 ___

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add more comprehensive for `thread trace export ctf` command

jj10306 created this revision. jj10306 added a reviewer: wallace. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow up on https://reviews.llvm.org/D105741 - Add new test that exhaustively checks the output file's content - Fix

[Lldb-commits] [lldb] 34d78b6 - [lldb] Upstream support for Foundation constant classes

Author: Jonas Devlieghere Date: 2021-08-06T16:08:48-07:00 New Revision: 34d78b6a6755946e547afc47d38b59b6a2854457 URL: https://github.com/llvm/llvm-project/commit/34d78b6a6755946e547afc47d38b59b6a2854457 DIFF: https://github.com/llvm/llvm-project/commit/34d78b6a6755946e547afc47d38b59b6a2854457.d

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34d78b6a6755: [lldb] Upstream support for Foundation constant classes (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to com

[Lldb-commits] [lldb] bfeb281 - Use LC_DYLD_EXPORTS_TRIE to locate the dyld trie structure if present

Author: Jim Ingham Date: 2021-08-06T16:38:34-07:00 New Revision: bfeb281fbd8e348edfadf5052e9266e13b832171 URL: https://github.com/llvm/llvm-project/commit/bfeb281fbd8e348edfadf5052e9266e13b832171 DIFF: https://github.com/llvm/llvm-project/commit/bfeb281fbd8e348edfadf5052e9266e13b832171.diff LO

[Lldb-commits] [PATCH] D107673: Use LC_DYLD_EXPORTS_TRIE to locate the dyld trie structure if present

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbfeb281fbd8e: Use LC_DYLD_EXPORTS_TRIE to locate the dyld trie structure if present (authored by jingham). Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

saugustine added a comment. This change breaks various build bots with a missing file. See below. Reverting shortly. For example: https://lab.llvm.org/buildbot/#/builders/68/builds/16816 /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

JDevlieghere added a comment. Yep, I'm looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107660/new/ https://reviews.llvm.org/D107660 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] 4e5af6e - Revert "[lldb] Upstream support for Foundation constant classes"

Author: Sterling Augustine Date: 2021-08-06T16:56:59-07:00 New Revision: 4e5af6ef48590e7248e344ddabf245bb3de71c51 URL: https://github.com/llvm/llvm-project/commit/4e5af6ef48590e7248e344ddabf245bb3de71c51 DIFF: https://github.com/llvm/llvm-project/commit/4e5af6ef48590e7248e344ddabf245bb3de71c51.

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

saugustine added a comment. Thanks for looking. Reverted with 4e5af6ef48590e7248e344ddabf245bb3de71c51 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107660/new/ https://reviews

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

JDevlieghere added a comment. In D107660#2932321 , @saugustine wrote: > Thanks for looking. Reverted with 4e5af6ef48590e7248e344ddabf245bb3de71c51 > . What's the point of giving a hea

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

clayborg added a comment. I like the new UI! I think you are right in that we don't need the address on the breakpoint location line if we can expand it and see it in the location children, so lets remove it from there. Other than that it looks good. The only other suggestion I would have is if

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

saugustine added a comment. Some people complain if I revert without notification. So I always notify as soon as I find the patch with the problem. Some reverts are more complicated than others too. I guess it adds more noise but I try to default to more communication over less. Repository:

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

JDevlieghere added a comment. In D107660#2932334 , @saugustine wrote: > Some people complain if I revert without notification. So I always notify as > soon as I find the patch with the problem. Some reverts are more complicated > than others too. > > I

[Lldb-commits] [lldb] 9d5e95d - Re-land "[lldb] Upstream support for Foundation constant classes"

Author: Jonas Devlieghere Date: 2021-08-06T17:24:47-07:00 New Revision: 9d5e95d094ffc1a49aa4c9d379cec7c2b60fd3f2 URL: https://github.com/llvm/llvm-project/commit/9d5e95d094ffc1a49aa4c9d379cec7c2b60fd3f2 DIFF: https://github.com/llvm/llvm-project/commit/9d5e95d094ffc1a49aa4c9d379cec7c2b60fd3f2.d

[Lldb-commits] [PATCH] D107679: [lldb] Move Objective-C constants into ObjCConstants.h

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. JDevlieghere requested review of this revision. Move Objective-C constants into ObjCConstants.h and share them between Cocoa and AppleObjCTypeEncodingParser. https://reviews.llvm.org/D107679 Files: lldb/source/Plugin

[Lldb-commits] [PATCH] D107679: [lldb] Move Objective-C constants into ObjCConstants.h

JDevlieghere updated this revision to Diff 364916. JDevlieghere added a comment. Formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107679/new/ https://reviews.llvm.org/D107679 Files: lldb/source/Plugins/Language/ObjC/Cocoa.cpp lldb/source/Plugins/Language/ObjC/ObjCConstants.

[Lldb-commits] [PATCH] D107679: [lldb] Move Objective-C constants into ObjCConstants.h

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Nice, thanks for cleaning this up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107679/new/ https://reviews.llvm.org/D107679 ___ lldb-c