[Lldb-commits] [PATCH] D105181: [lldb][AArch64] Add memory tag writing to lldb

DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/MemoryTagManager.h:35 + // alignment/expansion over again. + struct TagManagerWithRange { +const MemoryTagManager *manager; omjavaid wrote: > I was wondering if you can explain reason

[Lldb-commits] [PATCH] D105179: [lldb][AArch64] Add tag repeat and unpack to memory tag manager

DavidSpickett updated this revision to Diff 356900. DavidSpickett added a comment. - Make granules default to 0 for UnpackTagsData - Add more comments to tests (I'll add a method to repeat packed tags in the later patch that'll use it) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D105181: [lldb][AArch64] Add memory tag writing to lldb

omjavaid added inline comments. Comment at: lldb/include/lldb/Target/MemoryTagManager.h:35 + // alignment/expansion over again. + struct TagManagerWithRange { +const MemoryTagManager *manager; DavidSpickett wrote: > omjavaid wrote: > > I was wondering if yo

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

DavidSpickett added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:56 # Run the packet stream context = self.expect_gdbremote_sequence() self.assertIsNotNone(context) omjavaid

[Lldb-commits] [PATCH] D105181: [lldb][AArch64] Add memory tag writing to lldb

DavidSpickett added inline comments. Comment at: lldb/source/Target/Process.cpp:6108 +range_callback) { Architecture *arch = GetTarget().GetArchitecturePlugin(); const MemoryTagManager *tag_manager = omjavaid wrote: > The point I was trying to estab

[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:512 virtual bool - LoadScriptingModule(const char *filename, bool init_session, + LoadS

[Lldb-commits] [PATCH] D105483: [LLDB] Testsuite: Add helper to check for AArch64 target

omjavaid added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1296 +"""Returns true if the architecture is AArch64.""" +return self.getArchitecture().lower() in ["aarch64"] + DavidSpickett wrote: > This can be: > ```

[Lldb-commits] [lldb] 29cc50e - [LLDB][GUI] Add initial forms support

Author: Omar Emara Date: 2021-07-07T17:17:46+02:00 New Revision: 29cc50e17a6800ca75cd23ed85ae1ddf3e3dcc14 URL: https://github.com/llvm/llvm-project/commit/29cc50e17a6800ca75cd23ed85ae1ddf3e3dcc14 DIFF: https://github.com/llvm/llvm-project/commit/29cc50e17a6800ca75cd23ed85ae1ddf3e3dcc14.diff LO

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29cc50e17a68: [LLDB][GUI] Add initial forms support (authored by OmarEmaraDev, committed by teemperor). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [lldb] d4cb286 - [NFC][lldb-vscode] Fix launch test

Author: Walter Erquinigo Date: 2021-07-07T10:01:19-07:00 New Revision: d4cb286b05f5192f6cbae310bd30cad3f05f13ac URL: https://github.com/llvm/llvm-project/commit/d4cb286b05f5192f6cbae310bd30cad3f05f13ac DIFF: https://github.com/llvm/llvm-project/commit/d4cb286b05f5192f6cbae310bd30cad3f05f13ac.di

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103172/new/ https://reviews.llvm.org/D103172 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik created this revision. shafik added reviewers: aprantl, teemperor, labath. Herald added a subscriber: arphaman. shafik requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Currently when we have a member function that has an auto return

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

aprantl added a comment. I think it would be best to split out the Clang change into a separately tested patch. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1694 + // If the declared return type is "auto" we want the linkage name to go + // with the defintion. In ca

[Lldb-commits] [lldb] 3ebfeb2 - [lldb][docs] Force documentation emission of special Python class members

Author: Raphael Isemann Date: 2021-07-07T19:49:50+02:00 New Revision: 3ebfeb258698db82b7525cfaa1efd04db93d72ba URL: https://github.com/llvm/llvm-project/commit/3ebfeb258698db82b7525cfaa1efd04db93d72ba DIFF: https://github.com/llvm/llvm-project/commit/3ebfeb258698db82b7525cfaa1efd04db93d72ba.dif

[Lldb-commits] [PATCH] D105480: [lldb][docs] Force documentation emission of special Python class members

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ebfeb258698: [lldb][docs] Force documentation emission of special Python class members (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [lldb] e81ba28 - [lldb/lua] Add scripted watchpoints for Lua

Author: Siger Yang Date: 2021-07-07T14:51:02-03:00 New Revision: e81ba283131cf76ae62fa9b601a24d080578efaa URL: https://github.com/llvm/llvm-project/commit/e81ba283131cf76ae62fa9b601a24d080578efaa DIFF: https://github.com/llvm/llvm-project/commit/e81ba283131cf76ae62fa9b601a24d080578efaa.diff LO

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe81ba283131c: [lldb/lua] Add scripted watchpoints for Lua (authored by Siger Yang , committed by tammela). Changed prior to co

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

aprantl added a comment. I think it would be best to split out the Clang change into a separately tested patch. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2693 +if (!try_resolving_type) + return true; + This block looks like

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2693 +if (!try_resolving_type) + return true; + aprantl wrote: > This block looks like it's more complicated than it needs to be. Could you > just say >

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

aprantl added a comment. Could LLDB find the linkage name on the declaration, look that name up in the symbol table, and find the DW_TAG_subprogram DIE for the symbol's start address? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105564/new/ https://reviews.llvm.org/D105564 __

[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

JDevlieghere updated this revision to Diff 357037. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. - Address code review feedback - Use `LoadScriptOptions` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105327/new/ https://reviews.llvm.org/D105327 Files: l

[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:2795 Locker::FreeAcquiredLock | - (init_session ? Locker::TearDownSession : 0)); + (init_session ? L

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

wallace requested changes to this revision. wallace added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/variables/TestVSCode_variables.py:292 +Tests the evaluated expression expands successfully after "scopes" packets +and permanent +

[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

clayborg added a comment. We also have the notion of a IOHandler being interactive or not: bool IOHandler::GetIsInteractive(); Maybe we can use this to set the "silent" option in the LoadScriptOptions object correctly in more cases than just when the user specifies the option?

[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

clayborg added a comment. I think the only time we should not be silent is when the user types "command script import" from an interactive terminal. If this command comes in from the equivalent of "command source ...", sourcing init files then that IOHandler isn't interactive and we can easily

Re: [Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

Scripts can actually do work when they get imported (not just register commands) and you might for instance `command script import` a module that's going to do some work & present output in a breakpoint command or stop hook. But breakpoint commands and stop hooks are not interactive. So I'm a

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Target/TraceCursor.h:64-65 + TraceCursor(lldb::ThreadSP thread_sp) : m_thread_sp(thread_sp) {} + /// Move the cursor to

[Lldb-commits] [PATCH] D105389: [lldb] Add AllocateMemory/DeallocateMemory to the SBProcess API

clayborg added inline comments. Comment at: lldb/bindings/interface/SBProcess.i:420 +lldb::addr_t +AllocateMemory(size_t size, uint32_t permissions, lldb::SBError &error); Add doc string that describes this function for python users. Something about "p

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

omjavaid updated this revision to Diff 357101. omjavaid edited the summary of this revision. omjavaid added a comment. This adds pointer signing before we set watchpoint on the tagged_ptr. LLDB should be able to successfully set a watchpoint on a signed pointer. We can hit the watchpoint on tagg

[Lldb-commits] [PATCH] D105389: [lldb] Add AllocateMemory/DeallocateMemory to the SBProcess API

housel updated this revision to Diff 357131. housel added a comment. Updated based on reviewer suggestions, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105389/new/ https://reviews.llvm.org/D105389 Files: lldb/bindings/interface/SBProcess.i lldb/include/lldb/API/SBProcess.