[Lldb-commits] [PATCH] D102597: [lldb][NFC] Remove all uses of StringRef::withNullAsEmpty in LLDB

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. A long time ago LLDB wanted to start using StringRef instead of C-Strings/ConstString but was blocked by the fa

[Lldb-commits] [lldb] 4112f5e - [lldb][NFC] Specify guidelines for API tests

Author: Raphael Isemann Date: 2021-05-17T11:01:47+02:00 New Revision: 4112f5ef69a166ae1d18da0cde60b8d6c402a5e4 URL: https://github.com/llvm/llvm-project/commit/4112f5ef69a166ae1d18da0cde60b8d6c402a5e4 DIFF: https://github.com/llvm/llvm-project/commit/4112f5ef69a166ae1d18da0cde60b8d6c402a5e4.dif

[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG4112f5ef69a1: [lldb][NFC] Specify guidelines for API tests (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D102428: [StopInfoMachException] Summarize arm64e BLRAx/LDRAx auth failures

DavidSpickett added a comment. I think some of my questions are too detailed for this initial patch, I'm sure we can improve the diagnostics over time as situations come up. Glad to see this being upstreamed. Not very knowledgeable on Mach specifics so I'll leave the final review to others.

[Lldb-commits] [lldb] 5b614eb - [lldb] Let dotest check for the `cassert` header instead of `algorithm` for libc++ check

Author: Raphael Isemann Date: 2021-05-17T11:16:58+02:00 New Revision: 5b614eb4ea6ce047daebc0517eb4efa83123fe58 URL: https://github.com/llvm/llvm-project/commit/5b614eb4ea6ce047daebc0517eb4efa83123fe58 DIFF: https://github.com/llvm/llvm-project/commit/5b614eb4ea6ce047daebc0517eb4efa83123fe58.dif

[Lldb-commits] [PATCH] D101056: [lldb] Let dotest check for the `cassert` header instead of `algorithm` for libc++ check

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b614eb4ea6c: [lldb] Let dotest check for the `cassert` header instead of `algorithm` for… (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

thakis added a comment. In both gcc and clang, -Wmisleading-indentation is part of -Wall as far as I can tell: https://godbolt.org/z/Msaz6Kb6T In which build configuration does this change have an effect? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D102624: [lldb] Optimize expressions

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. At the moment we codegen or interpret the IR in exactly the way as it is generated by Clang. This patch runs th

[Lldb-commits] [PATCH] D102624: [lldb] Optimize expressions

teemperor added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp:2026 + i = call->eraseFromParent(); + continue; +} I do wish we had a better way to do the iterate-while-erase algorithm

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil added a comment. ping#2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289/new/ https://reviews.llvm.org/D98289 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [PATCH] D102624: [lldb] Optimize expressions

vsk added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp:409 + // static MyClass *__lldb_expr_result_ptr = &c; // Points to stack. + // __lldb_expr_result_ptr(__lldb_expr_result_ptr); + // } // End of expressio

[Lldb-commits] [PATCH] D102624: [lldb] Optimize expressions

teemperor added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp:409 + // static MyClass *__lldb_expr_result_ptr = &c; // Points to stack. + // __lldb_expr_result_ptr(__lldb_expr_result_ptr); + // } // End of exp

[Lldb-commits] [lldb] 2182eda - [LLDB] Switch from using member_clang_type.GetByteSize() to member_type->GetByteSize() in ParseSingleMember

Author: Shafik Yaghmour Date: 2021-05-17T10:36:35-07:00 New Revision: 2182eda3062471e2e6994307c46ffcca7e39ecff URL: https://github.com/llvm/llvm-project/commit/2182eda3062471e2e6994307c46ffcca7e39ecff DIFF: https://github.com/llvm/llvm-project/commit/2182eda3062471e2e6994307c46ffcca7e39ecff.dif

[Lldb-commits] [PATCH] D102445: Switch from using member_clang_type.GetByteSize() to member_type->GetByteSize() in ParseSingleMember

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2182eda30624: [LLDB] Switch from using member_clang_type.GetByteSize() to member_type… (authored by shafik). Herald added a project: LLDB. Repositor

[Lldb-commits] [PATCH] D102597: [lldb][NFC] Remove all uses of StringRef::withNullAsEmpty in LLDB

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. 🚢 it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102597/new/ https://reviews.llvm.org/D102597 ___ lldb-comm

[Lldb-commits] [lldb] bd5751f - Reset the wakeup timeout when we re-enter the continue wait.

Author: Jim Ingham Date: 2021-05-17T10:49:47-07:00 New Revision: bd5751f3d249ec0798060bd98c07272174c52af0 URL: https://github.com/llvm/llvm-project/commit/bd5751f3d249ec0798060bd98c07272174c52af0 DIFF: https://github.com/llvm/llvm-project/commit/bd5751f3d249ec0798060bd98c07272174c52af0.diff LO

[Lldb-commits] [PATCH] D102562: Fix to the interrupt timeout handling: reset the timeout on re-entry

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd5751f3d249: Reset the wakeup timeout when we re-enter the continue wait. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D102428: [StopInfoMachException] Summarize arm64e BLRAx/LDRAx auth failures

vsk updated this revision to Diff 345940. vsk added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102428/new/ https://reviews.llvm.org/D102428 Files: lldb/include/lldb/Core/Address.h lldb/include/lldb/Core/D

[Lldb-commits] [PATCH] D102428: [StopInfoMachException] Summarize arm64e BLRAx/LDRAx auth failures

vsk added inline comments. Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:126 +Address brk_address; +if (!target.ResolveLoadAddress(fixed_bad_address, brk_address)) + return false; DavidSpickett wrote: > vsk wrote: > > Davi

[Lldb-commits] [lldb] 02286d9 - [lldb] Document ctrl-f for completing show-autosuggestion

Author: Dave Lee Date: 2021-05-17T12:52:20-07:00 New Revision: 02286d96dbb3862a7dc5f7a2481c1f763186b259 URL: https://github.com/llvm/llvm-project/commit/02286d96dbb3862a7dc5f7a2481c1f763186b259 DIFF: https://github.com/llvm/llvm-project/commit/02286d96dbb3862a7dc5f7a2481c1f763186b259.diff LOG:

[Lldb-commits] [PATCH] D102544: [lldb] Document ctrl-f for completing show-autosuggestion

This revision was automatically updated to reflect the committed changes. Closed by commit rG02286d96dbb3: [lldb] Document ctrl-f for completing show-autosuggestion (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102544/new/

[Lldb-commits] [lldb] 82a3883 - Revert "Reset the wakeup timeout when we re-enter the continue wait."

Author: Jim Ingham Date: 2021-05-17T15:37:26-07:00 New Revision: 82a38837150099288a1262391ef43e1fd69ffde4 URL: https://github.com/llvm/llvm-project/commit/82a38837150099288a1262391ef43e1fd69ffde4 DIFF: https://github.com/llvm/llvm-project/commit/82a38837150099288a1262391ef43e1fd69ffde4.diff LO

[Lldb-commits] [PATCH] D102630: [lit] Stop using PATH to lookup clang/lld/lldb unless requested

dblaikie added a comment. @thopre - as an aside: It'd be helpful if you could include some text in the text box when marking something "approved" through phabricator. There's a bug/limitation that approvals without text don't produce email to the mailing list - so it looks like a patch hasn't b

[Lldb-commits] [PATCH] D102658: [lldb/API] Use a valid LineEntry object in SBCompileUnit::FindLineEntryIndex

mib created this revision. mib added reviewers: JDevlieghere, jingham. mib added a project: LLDB. Herald added a subscriber: arphaman. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch updates `SBCompileUnit::FindLineEntryIndex` to pass a valid `LineEntry`

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

clayborg added a comment. No objections from me. Anyone else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289/new/ https://reviews.llvm.org/D98289 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D102658: [lldb/API] Use a valid LineEntry object in SBCompileUnit::FindLineEntryIndex

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102658/new/ https://reviews.llvm.org/D102658 ___

[Lldb-commits] [PATCH] D102658: [lldb/API] Use a valid LineEntry object in SBCompileUnit::FindLineEntryIndex

mib updated this revision to Diff 346023. mib added a comment. Add test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102658/new/ https://reviews.llvm.org/D102658 Files: lldb/source/API/SBCompileUnit.cpp lldb/test/API/functionalities/find-line-entry/Makefile lldb/test/API/functi

[Lldb-commits] [lldb] 1b4d5b3 - [lldb/API] Use a valid LineEntry object in SBCompileUnit::FindLineEntryIndex

Author: Med Ismail Bennani Date: 2021-05-18T01:28:53+01:00 New Revision: 1b4d5b3bf30656d39d94985a63f1c0514fcc6526 URL: https://github.com/llvm/llvm-project/commit/1b4d5b3bf30656d39d94985a63f1c0514fcc6526 DIFF: https://github.com/llvm/llvm-project/commit/1b4d5b3bf30656d39d94985a63f1c0514fcc6526.

[Lldb-commits] [PATCH] D102658: [lldb/API] Use a valid LineEntry object in SBCompileUnit::FindLineEntryIndex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b4d5b3bf306: [lldb/API] Use a valid LineEntry object in SBCompileUnit::FindLineEntryIndex (authored by mib). Repository: rG LLVM Github Monorepo