[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

pcc added inline comments. Comment at: lldb/source/Target/Process.cpp:5569-5570 + + if (m_code_address_mask == 0) +return -1; // All bits are used for addressing. + JDevlieghere wrote: > jasonmolenda wrote: > > pcc wrote: > > > Is this part correct? (Same be

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

jasonmolenda added inline comments. Comment at: lldb/source/Target/Process.cpp:5569-5570 + + if (m_code_address_mask == 0) +return -1; // All bits are used for addressing. + pcc wrote: > JDevlieghere wrote: > > jasonmolenda wrote: > > > pcc wrote: > > > > Is

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

pcc added inline comments. Comment at: lldb/source/Target/Process.cpp:5569-5570 + + if (m_code_address_mask == 0) +return -1; // All bits are used for addressing. + jasonmolenda wrote: > pcc wrote: > > JDevlieghere wrote: > > > jasonmolenda wrote: > > > > pc

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

JDevlieghere updated this revision to Diff 338128. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100515/new/ https://reviews.llvm.org/D100515 Files: lldb/include/lldb/Target/Process.h lldb/source/Target/Process.cpp lldb/source/Target/TargetProperties.td Index: lldb/source/Target/T

[Lldb-commits] [PATCH] D100521: [lldb] Fix up code addresses in RegisterContextUnwind

JDevlieghere updated this revision to Diff 338129. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100521/new/ https://reviews.llvm.org/D100521 Files: lldb/include/lldb/Target/ABI.h lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp lldb/source/Plugins/ABI/AArch64/ABIAArch64.h lldb/sou

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This looks good, thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100338/new/ https://reviews.llvm.org/D100338

[Lldb-commits] [PATCH] D100418: [lldb] [MainLoop] Support multiple callbacks per signal

mgorny updated this revision to Diff 338170. mgorny marked an inline comment as done. mgorny added a comment. Fixed the iterator, formatting and added a test for adding, running and removing multiple handlers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100418/new/ https://reviews.ll

[Lldb-commits] [lldb] 3dc24bc - [LLDB] Re-land: Use path relative to binary for finding .dwo files.

Author: Caroline Tice Date: 2021-04-16T11:12:39-07:00 New Revision: 3dc24bc31edbc01dea085b24a6a6b024d7ae531c URL: https://github.com/llvm/llvm-project/commit/3dc24bc31edbc01dea085b24a6a6b024d7ae531c DIFF: https://github.com/llvm/llvm-project/commit/3dc24bc31edbc01dea085b24a6a6b024d7ae531c.diff

Re: [Lldb-commits] [lldb] 3dc24bc - [LLDB] Re-land: Use path relative to binary for finding .dwo files.

For future reference it'd be good to include some details in a recommit including the original commit hash, the revert hash, the reason for the revert and what's changed in this commit to address that problem. For others reading along, according to the phab review this test hit a bug in lldb and t

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

justincohen added a comment. Out of curiosity: Typically should one be able to set target.process.virtual-addressable-bits after the target has been created? Or is it expected that users will need to run in the following order only: settings set target.process.virtual-addressable-bits ...

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

JDevlieghere added a comment. In D100515#2695395 , @justincohen wrote: > Out of curiosity: Typically should one be able to set > target.process.virtual-addressable-bits after the target has been created? > Or is it expected that users will need to run

[Lldb-commits] [lldb] fdbb5a7 - [lldb] Add code and data address mask to Process

Author: Jonas Devlieghere Date: 2021-04-16T12:30:54-07:00 New Revision: fdbb5a7a91b00d1e4a9a16fee96763917a411fff URL: https://github.com/llvm/llvm-project/commit/fdbb5a7a91b00d1e4a9a16fee96763917a411fff DIFF: https://github.com/llvm/llvm-project/commit/fdbb5a7a91b00d1e4a9a16fee96763917a411fff.d

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfdbb5a7a91b0: [lldb] Add code and data address mask to Process (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D100520: [lldb] Set code and data address mask from qHostInfo

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100520/new/ https://reviews.llvm.org/D100520 ___ lldb-commits mailin

[Lldb-commits] [lldb] db2da0c - [lldb] Set addressable bits from qHostInfo

Author: Jonas Devlieghere Date: 2021-04-16T13:49:38-07:00 New Revision: db2da0c8f907c444e0bf8b788d8186c4c67db0b2 URL: https://github.com/llvm/llvm-project/commit/db2da0c8f907c444e0bf8b788d8186c4c67db0b2 DIFF: https://github.com/llvm/llvm-project/commit/db2da0c8f907c444e0bf8b788d8186c4c67db0b2.d

[Lldb-commits] [PATCH] D100521: [lldb] Fix up code addresses in RegisterContextUnwind

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8770b4ecca55: [lldb] Implement ABI::Fix{Code,Data}Address for AArch64 (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to com

[Lldb-commits] [lldb] 8770b4e - [lldb] Implement ABI::Fix{Code, Data}Address for AArch64

Author: Jonas Devlieghere Date: 2021-04-16T13:49:38-07:00 New Revision: 8770b4ecca557b02d37188ae2fa5479e6136b2fb URL: https://github.com/llvm/llvm-project/commit/8770b4ecca557b02d37188ae2fa5479e6136b2fb DIFF: https://github.com/llvm/llvm-project/commit/8770b4ecca557b02d37188ae2fa5479e6136b2fb.d

[Lldb-commits] [PATCH] D100520: [lldb] Set code and data address mask from qHostInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb2da0c8f907: [lldb] Set addressable bits from qHostInfo (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny updated this revision to Diff 338232. mgorny added a comment. Added a unittest covering the whole server life cycle, including attaching a (mocked) process, forking, detaching a child, detaching the parent, forking from the child and detaching all processes. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

jasonmolenda added a comment. In D100515#2695559 , @JDevlieghere wrote: > In D100515#2695395 , @justincohen > wrote: > >> Out of curiosity: Typically should one be able to set >> target.process.virtual-addressa

[Lldb-commits] [lldb] e9fe788 - Target::ReadMemory read from read-only binary file Section, not memory

Author: Jason Molenda Date: 2021-04-16T16:13:07-07:00 New Revision: e9fe788d326090cb6155c0dec90b44c932273dd3 URL: https://github.com/llvm/llvm-project/commit/e9fe788d326090cb6155c0dec90b44c932273dd3 DIFF: https://github.com/llvm/llvm-project/commit/e9fe788d326090cb6155c0dec90b44c932273dd3.diff

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9fe788d3260: Target::ReadMemory read from read-only binary file Section, not memory (authored by jasonmolenda). Changed prior to commit: https://