[Lldb-commits] [PATCH] D100164: Don't treat corefile binaries like dylibs in the shared cache, even if they say they are

jasonmolenda created this revision. jasonmolenda added a reviewer: friss. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. There is a corefile writer that is including uninitialized data in the Mach-O header 'flags' field

[Lldb-commits] [lldb] 39ae25f - [lldb] Update object.test after 'nosync' inference was enabled.

Author: Alexander Belyaev Date: 2021-04-09T10:04:15+02:00 New Revision: 39ae25fb8c648b0e710ba2d2d46e7a5b7fafff19 URL: https://github.com/llvm/llvm-project/commit/39ae25fb8c648b0e710ba2d2d46e7a5b7fafff19 DIFF: https://github.com/llvm/llvm-project/commit/39ae25fb8c648b0e710ba2d2d46e7a5b7fafff19.d

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Add a NativeDelegate API to pass new processes (forks) to LLGS, and support detaching them via the 'D' packet. A 'D' packet without a specific PID detaches all processes, o

[Lldb-commits] [PATCH] D100192: [lldb][Arm/AArch64] Add basic disassemble tests for Arm/AArch64

DavidSpickett created this revision. Herald added subscribers: danielkiss, pengfei, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously the test would fail if you built on Arm/AArch64 but did not have the

[Lldb-commits] [PATCH] D100193: [lldb] Require x86 backend for a bunch of DWARF tests

DavidSpickett created this revision. Herald added subscribers: pengfei, arphaman. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. All these tests use x86 target triples. Repository: rG LLVM Github Monorepo https://reviews

[Lldb-commits] [PATCH] D100194: [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests

DavidSpickett created this revision. Herald added a subscriber: pengfei. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These tests fail if you build without the x86 llvm backend. Either because they use an x86 triple or try

[Lldb-commits] [PATCH] D100194: [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests

DavidSpickett added reviewers: zturner, labath. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. (not adding a reviewer for each file type since most are pretty straightforward I think) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D100194: [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests

DavidSpickett added inline comments. Comment at: lldb/test/Shell/SymbolFile/Breakpad/unwind-via-raSearch.test:45 # CHECK: frame #2: 0x000b1085 unwind-via-stack-win.exe`main + 5 # CHECK: frame #3: 0x77278494 kernel32.dll # CHECK-NOT: frame Same thing happens he

[Lldb-commits] [PATCH] D100195: [lldb] Require x86 for unwind no-return test

DavidSpickett created this revision. Herald added a subscriber: pengfei. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The core file used is built for i386 so we need the x86 backend to be able to load it. Repository: rG

[Lldb-commits] [PATCH] D100195: [lldb] Require x86 for unwind no-return test

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. (apologies for the review spam, you're the author of the test in this case) lldb in fact crashes when you try to load the core file. Would be nice to give a good failure message if we

[Lldb-commits] [PATCH] D100196: [lldb] Introduce new stop reasons: fork and vfork

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Introduce two new stop reasons for fork and vfork events. This includes server support for serializing fork/vfork events into gdb-remote protocol, and client support for de

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny updated this revision to Diff 336443. mgorny added a comment. Permit more-than-one-char 'D' packets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100191/new/ https://reviews.llvm.org/D100191 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h lldb/source/Plugins/Pr

[Lldb-commits] [PATCH] D99864: [lldb] Fork/vfork support via gdb-remote protocol [WIP]

mgorny added a comment. I've decided to take another approach for tracking forked processes. Rather than keeping them inside `NativeProcess*` and exposing via API to LLGS, I've decided to push them via `NativeDelegate` straight into LLGS and maintain there. This is now D100191

[Lldb-commits] [PATCH] D100206: [lldb] [llgs client] Support minimal fork/vfork handling

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Add a support for handling fork/vfork stops in LLGS client. At this point, it only sends a detach packet for the newly forked child (and implicitly resumes the parent). h

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason to client [WIP]

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Enable reporting fork/vfork events to the client when supported. This switches from implicit server-side handling to client-controlled gdb-remote protocol exchange. https

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason to client [WIP]

mgorny added a comment. This is the final piece for moving minimal fork/vfork support to gdb-remote protocol. However, for some reason (unlike the original code in D99864 ), it crashes on random assertions about `m_enabled_extensions` value — probably memory cor

[Lldb-commits] [PATCH] D100193: [lldb] Require x86 backend for a bunch of DWARF tests

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Rather than updating all the these tests, please move them into an x86 subdirectory and add a `lit.local.cfg` to mark the whole folder as unsupported without x86 support.

[Lldb-commits] [PATCH] D100212: [lldb] Delete dead StackFrameList::Merge

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor requested review of this revision. That code is unused since it's check-in in 2010 (and I believe it would leak memory when called as it releases the passed unique_ptr), so let's delete it. https://reviews.llvm.org/D10

[Lldb-commits] [PATCH] D100153: [lldb] [Process] Introduce protocol extension support API

mgorny updated this revision to Diff 336516. mgorny added a comment. Fix uninitialized `flags` variable in `GDBRemoteCommunicationServerLLGS::SetEnabledExtensions()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100153/new/ https://reviews.llvm.org/D100153 Files: lldb/include/lldb/

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason to client

mgorny added a comment. Ok, found the culprit. Now it's ready ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100208/new/ https://reviews.llvm.org/D100208 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D100212: [lldb] Delete dead StackFrameList::Merge

vsk accepted this revision as: vsk. vsk added a comment. This revision is now accepted and ready to land. +1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100212/new/ https://reviews.llvm.org/D100212 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D100212: [lldb] Delete dead StackFrameList::Merge

shafik added a comment. I think it is pretty safe to remove it after 10+ years is not being used. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100212/new/ https://reviews.llvm.org/D100212 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

gandhi21299 updated this revision to Diff 336249. gandhi21299 added a comment. - enclosing classes in PPCCallLowering,h within the llvm namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99812/new/ https://reviews.llvm.org/D99812 Files: llv

[Lldb-commits] [lldb] d9c9c0b - [LLDB][NFC] Add clarifying comments for AddCXXSummary and AddCXXSynthetic

Author: Shafik Yaghmour Date: 2021-04-09T12:07:24-07:00 New Revision: d9c9c0b2db0dc4ddf407edcafba0a5a806850ddc URL: https://github.com/llvm/llvm-project/commit/d9c9c0b2db0dc4ddf407edcafba0a5a806850ddc DIFF: https://github.com/llvm/llvm-project/commit/d9c9c0b2db0dc4ddf407edcafba0a5a806850ddc.dif