[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

mgorny updated this revision to Diff 328436. mgorny added a comment. Updated to enable on FreeBSD 13+ unconditionally. I've left the `#define` to avoid repeating the version in a few places. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96548/new/ https://reviews.llvm.org/D96548 Files

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

rovka added a comment. Hi Omair, I had a look and I think the commit message is slightly misleading because it says "Arm64 has dynamic features like SVE, Pointer Authentication and MTE", but then you don't set m_reg_infos_is_dynamic to true for SVE. This got me a bit confused at first. Maybe i

[Lldb-commits] [PATCH] D98001: [lldb/API] Add CommandInterpreter::{Get, Set}PrintErrors to SBAPI (NFC)

mib updated this revision to Diff 328569. mib added a comment. Add test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98001/new/ https://reviews.llvm.org/D98001 Files: lldb/bindings/interface/SBCommandInterpreterRunOptions.i lldb/include/lldb/API/SBCommandInterpreterRunOptions.h

[Lldb-commits] [PATCH] D98001: [lldb/API] Add CommandInterpreter::{Get, Set}PrintErrors to SBAPI (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the `\n`. Comment at: lldb/test/API/python_api/interpreter/TestRunCommandInterpreterAPI.py:113 +self.assertEqual(opts.GetAddToHistory(), False)

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

labath added a comment. In D97786#2603656 , @cmtice wrote: > I'm not sure about using target.debug-file-search-paths, and what the changes > Pavel is suggesting would entail. I imagine it would involve calling Symbols::LocateExecutableSymbolFile to loca

[Lldb-commits] [lldb] 36eab46 - [lldb/Interpreter] Add `interpreter.repeat-previous-command` setting

Author: Med Ismail Bennani Date: 2021-03-05T19:33:32+01:00 New Revision: 36eab4634f4cd4594e6d1409a66bc8f2d8fda04f URL: https://github.com/llvm/llvm-project/commit/36eab4634f4cd4594e6d1409a66bc8f2d8fda04f DIFF: https://github.com/llvm/llvm-project/commit/36eab4634f4cd4594e6d1409a66bc8f2d8fda04f.

[Lldb-commits] [lldb] c964741 - [lldb/API] Add CommandInterpreter::{Get, Set}PrintErrors to SBAPI (NFC)

Author: Med Ismail Bennani Date: 2021-03-05T19:33:33+01:00 New Revision: c964741996bcc3550c3598bb7237bd4551b03016 URL: https://github.com/llvm/llvm-project/commit/c964741996bcc3550c3598bb7237bd4551b03016 DIFF: https://github.com/llvm/llvm-project/commit/c964741996bcc3550c3598bb7237bd4551b03016.

[Lldb-commits] [PATCH] D97999: [lldb/Interpreter] Add `interpreter.repeat-previous-command` setting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36eab4634f4c: [lldb/Interpreter] Add `interpreter.repeat-previous-command` setting (authored by mib). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D98001: [lldb/API] Add CommandInterpreter::{Get, Set}PrintErrors to SBAPI (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc964741996bc: [lldb/API] Add CommandInterpreter::{Get,Set}PrintErrors to SBAPI (NFC) (authored by mib). Changed prior to commit: https://reviews.l

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added a comment. So we have had a vote for allowing multiple callbacks. Any other main issues with the approach in this patch? If everyone is mostly happy, please chime in and I will make unit tests and vscode tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

wallace added a comment. I'm quite happy with it besides the multiple callback thing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97739/new/ https://reviews.llvm.org/D97739 ___ lldb-commits mailing lis

[Lldb-commits] IMPORTANT NOTICE - Subscription to Mailman lists disabled immediately

All, We need to immediately disable subscription capabilities to all LLVM Mailman lists. The current Mailman server is being abused by subscribing valid email addresses to our lists and because the list requires confirmation, the email address gets “spam”. An email address is subscribed upward

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2162 + llvm::StringRef parent_type_name = GetDWARFDeclContext(parent) + .GetQualifiedNameAsConstString() +

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

jingham added a comment. This way of doing progress is going to look odd in anything that uses multiple debuggers. If I'm reading the code aright, if I have two debuggers, and a target in Debugger A starts doing something that would cause progress traffic, both debuggers will show activity. G

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added a comment. In D97739#2607869 , @jingham wrote: > This way of doing progress is going to look odd in anything that uses > multiple debuggers. If I'm reading the code aright, if I have two debuggers, > and a target in Debugger A starts doin

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added a comment. > SBDebugger currently doesn't vend any events so that would need to be added. I should clarify this: SBDebugger doesn't have any SBDebugger specific SBEvents that it vends or that people can sign up for. It does vend events for the targets / processes that it owns, ju

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added a comment. One serious vote against the SBEvent way of doing things is that it might stop progress notification from appearing in the UI immediately if someone is currently calling something that causes a long running operation from the main thread that is running the SBEvent loo

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

wallace added a comment. I think that the mechanism used to show progress should be lock-free and mostly unblocked, as it's merely an observer without side effects within LLDB. So from the last thing you said it seems that SBEvent doesn't like a good solution. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added a comment. I agree that we should avoid SBEvent after thinking about it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97739/new/ https://reviews.llvm.org/D97739 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

jingham added a comment. In D97739#2607993 , @clayborg wrote: > I agree that we should avoid SBEvent after thinking about it. First off, doing long running operations on a thread that is the one handling the major lldb events is obviously a bad idea. Se

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added a comment. In D97739#2608066 , @jingham wrote: > In D97739#2607993 , @clayborg wrote: > >> I agree that we should avoid SBEvent after thinking about it. > > First off, doing long running operations on

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

friss added a comment. In D97739#2607961 , @clayborg wrote: > In D97739#2607869 , @jingham wrote: > >> This way of doing progress is going to look odd in anything that uses >> multiple debuggers. If I'm reading th