[Lldb-commits] [PATCH] D97114: [lldb] [docs] Update platform support status

2021-02-20 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added subscribers: arphaman, arichardson. mgorny requested review of this revision. Update supported features on FreeBSD, and supported platform list on FreeBSD, Linux and NetBSD. https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D97114: [lldb] [docs] Update platform support status

2021-02-20 Thread Ed Maste via Phabricator via lldb-commits
emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. FreeBSD changes LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97114/new/ https://reviews.llvm.org/D97114 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D97114: [lldb] [docs] Update platform support status

2021-02-20 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski accepted this revision. krytarowski added a comment. NetBSD OK! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97114/new/ https://reviews.llvm.org/D97114 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

2021-02-20 Thread António Afonso via Phabricator via lldb-commits
aadsm added inline comments. Comment at: lldb/test/API/functionalities/module_load_attach/TestModuleLoadAttach.py:28 +def test_x(self): +process = self.build_launch_and_attach() +thread = process.GetSelectedThread() clayborg wrote: > Is this

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

2021-02-20 Thread António Afonso via Phabricator via lldb-commits
aadsm added inline comments. Comment at: lldb/test/API/functionalities/module_load_attach/TestModuleLoadAttach.py:32-33 +# Continue so that dlopen is called. +breakpoint = self.target().BreakpointCreateBySourceRegex( +"// break after dlopen", lldb.SBF

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

2021-02-20 Thread António Afonso via Phabricator via lldb-commits
aadsm updated this revision to Diff 325221. aadsm added a comment. Checks the module is not loaded right after we attach Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96637/new/ https://reviews.llvm.org/D96637 Files: lldb/packages/Python/lldbsui

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

2021-02-20 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added a comment. In D96778#2573076 , @jankratochvil wrote: > In D96778#2572816 , @dblaikie wrote: > >> rolls this into one file with two CUs - bit easier to deal with. > > Then one could not use the `.file

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

2021-02-20 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In D96778#2576881 , @dblaikie wrote: > In D96778#2573076 , @jankratochvil > wrote: > >> Personally I am not interested in DWZ, I am implementing it only as a >> compatibility with ex

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

2021-02-20 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added a comment. In D96778#2576913 , @jankratochvil wrote: > In D96778#2576881 , @dblaikie wrote: > >> In D96778#2573076 , @jankratochvil >> wrote: >> >>> Personal

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

2021-02-20 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In D96778#2576927 , @dblaikie wrote: > What part of DWZ is specified by DWARFv5? `DW_*_sup` being used by DWZ with DWARF-4 as `DW_*_GNU_*_alt` (and dwarfstd.org proposal

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

2021-02-20 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added a comment. In D96778#2576980 , @jankratochvil wrote: > In D96778#2576927 , @dblaikie wrote: > >> What part of DWZ is specified by DWARFv5? > > Only `DW_*_sup` - being used by DWZ with DWARF-4 as `DW_

[Lldb-commits] [lldb] b0186c2 - [lldb] Refine ThreadPlan::ShouldAutoContinue

2021-02-20 Thread Dave Lee via lldb-commits
Author: Dave Lee Date: 2021-02-20T17:25:31-08:00 New Revision: b0186c25c62e79869d37b81ad819c67a3e97b0cd URL: https://github.com/llvm/llvm-project/commit/b0186c25c62e79869d37b81ad819c67a3e97b0cd DIFF: https://github.com/llvm/llvm-project/commit/b0186c25c62e79869d37b81ad819c67a3e97b0cd.diff LOG:

[Lldb-commits] [PATCH] D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue

2021-02-20 Thread Dave Lee via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0186c25c62e: [lldb] Refine ThreadPlan::ShouldAutoContinue (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/D97076?vs=