[Lldb-commits] [PATCH] D96666: [lldb] Remove unused ThreadPlan tracer utilities (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Delete unused `EnableTracer()` and `SetTracer()` functions on `Thread`. By deleting these, their `ThreadP

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add MTE memory tag reading to lldb-server

omjavaid added a comment. This patch looks quite neat overall I have a few minor questions, comments and suggestions. 1. To get the review going consider further splitting up these patches into separate chunks containing, for example MemoryTagHandler API and related unit tests, GDB remote addo

[Lldb-commits] [lldb] 011791d - [lldb] [Process/FreeBSDRemote] Fix clang-formatting on ppc commit

Author: Michał Górny Date: 2021-02-14T22:34:25+01:00 New Revision: 011791dda43c55cd9d5e53b6119b0cf40c183c48 URL: https://github.com/llvm/llvm-project/commit/011791dda43c55cd9d5e53b6119b0cf40c183c48 DIFF: https://github.com/llvm/llvm-project/commit/011791dda43c55cd9d5e53b6119b0cf40c183c48.diff

[Lldb-commits] [PATCH] D96555: [lldb] Remove the legacy FreeBSD plugin

emaste added a comment. Not sure if you're missing something, but removing the old plugin LGTM Comment at: lldb/tools/lldb-server/CMakeLists.txt:13 if(CMAKE_SYSTEM_NAME MATCHES "FreeBSD") - list(APPEND LLDB_PLUGINS -lldbPluginProcessFreeBSDRemote -lldbPluginProcessFre

[Lldb-commits] [PATCH] D96555: [lldb] Remove the legacy FreeBSD plugin

emaste added inline comments. Comment at: lldb/tools/lldb-server/CMakeLists.txt:13 if(CMAKE_SYSTEM_NAME MATCHES "FreeBSD") - list(APPEND LLDB_PLUGINS -lldbPluginProcessFreeBSDRemote -lldbPluginProcessFreeBSD) + list(APPEND LLDB_PLUGINS lldbPluginProcessFreeBSDRemote)

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

aadsm created this revision. aadsm added reviewers: clayborg, labath, wallace, kusmour. aadsm requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. VSCode was not being informed whenever a location had been resolved (after being initated as non-

[Lldb-commits] [PATCH] D96687: [lldb] Lower GetRealStopInfo into ThreadPlanCallFunction (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `GetRealStopInfo` has only one call site, and in that call site a reference to the concrete thread plan i

[Lldb-commits] [PATCH] D96688: [lldb] Minor refinements to ThreadPlan::RestoreThreadState (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Correct `RestoreThreadState` to a `void` return type. Also, update the signature of its callee, `Thread::

[Lldb-commits] [PATCH] D96689: [lldb] Remove ThreadPlan::ShouldAutoContinue (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Remove `ShouldAutoContinue`, implemented in only one subclass. In the `ShouldAutoContinue::ShouldAutoCont