[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

2020-12-19 Thread Pedro Tammela via Phabricator via lldb-commits
tammela updated this revision to Diff 312942. tammela added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93481/new/ https://reviews.llvm.org/D93481 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp lldb/s

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

2020-12-19 Thread Pedro Tammela via Phabricator via lldb-commits
tammela added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:62 +case eIOHandlerWatchpoint: + break; +case eIOHandlerBreakpoint: JDevlieghere wrote: > Shouldn't this be the same for break- and watchpo

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

2020-12-19 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha added a comment. In D92164#2463734 , @labath wrote: > With this version of the patch, I am unable to reproduce the issue using the > approach I described in the previous comment. However, it still reproduces > when issuing the equivalen