[Lldb-commits] [PATCH] D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit

labath accepted this revision. labath added a comment. Let's give this another shot. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92187/new/ https://reviews.llvm.org/D92187 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [PATCH] D93299: [lldb] [unittests] Add tests for NetBSD register offsets/sizes

labath added inline comments. Comment at: lldb/unittests/Process/Utility/CMakeLists.txt:4-5 RegisterContextFreeBSDTest.cpp + RegisterContextNetBSDTest_i386.cpp + RegisterContextNetBSDTest_x86_64.cpp LinuxProcMapsTest.cpp What's reason for having these as

[Lldb-commits] [PATCH] D93299: [lldb] [unittests] Add tests for NetBSD register offsets/sizes

mgorny added inline comments. Comment at: lldb/unittests/Process/Utility/CMakeLists.txt:4-5 RegisterContextFreeBSDTest.cpp + RegisterContextNetBSDTest_i386.cpp + RegisterContextNetBSDTest_x86_64.cpp LinuxProcMapsTest.cpp labath wrote: > What's reason for

[Lldb-commits] [lldb] dbfdb13 - [lldb] [POSIX-DYLD] Update the cached exe path after attach

Author: Michał Górny Date: 2020-12-17T09:31:22+01:00 New Revision: dbfdb139f75470a9abc78e7c9faf743fdd963c2d URL: https://github.com/llvm/llvm-project/commit/dbfdb139f75470a9abc78e7c9faf743fdd963c2d DIFF: https://github.com/llvm/llvm-project/commit/dbfdb139f75470a9abc78e7c9faf743fdd963c2d.diff

[Lldb-commits] [lldb] 8666b90 - [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit

Author: Michał Górny Date: 2020-12-17T09:31:10+01:00 New Revision: 8666b9057f23badfe90548297f3c01937daa4a9c URL: https://github.com/llvm/llvm-project/commit/8666b9057f23badfe90548297f3c01937daa4a9c DIFF: https://github.com/llvm/llvm-project/commit/8666b9057f23badfe90548297f3c01937daa4a9c.diff

[Lldb-commits] [PATCH] D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit

This revision was automatically updated to reflect the committed changes. Closed by commit rG8666b9057f23: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92187/n

[Lldb-commits] [PATCH] D92264: [lldb] [POSIX-DYLD] Update the cached exe path after attach

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbfdb139f754: [lldb] [POSIX-DYLD] Update the cached exe path after attach (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [lldb] 722247c - [lldb] Unify the two CreateTypedef implementations in TypeSystemClang

Author: Raphael Isemann Date: 2020-12-17T10:49:26+01:00 New Revision: 722247c8124a6b840686757ae128b16cea248130 URL: https://github.com/llvm/llvm-project/commit/722247c8124a6b840686757ae128b16cea248130 DIFF: https://github.com/llvm/llvm-project/commit/722247c8124a6b840686757ae128b16cea248130.dif

[Lldb-commits] [PATCH] D93382: [lldb] Unify the two CreateTypedef implementations in TypeSystemClang

This revision was automatically updated to reflect the committed changes. Closed by commit rG722247c8124a: [lldb] Unify the two CreateTypedef implementations in TypeSystemClang (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

labath added a comment. This seems suspicious to me, on a couple of levels. You claim that BOOL is an unsigned type, but the apple documentation says "BOOL is explicitly signed so @encode(BOOL) is c rather than C even if -funsigned-cha

[Lldb-commits] [PATCH] D93438: ObjectFileELF: Test whether reloc_header is non-null instead of asserting.

labath added a comment. The fix seems reasonable but it would use a test case. Is it possible to generate appropriate input with `yaml2obj`? If so you could run `lldb-test symbols` on the resulting object file, and verify that the Symbol table is printed out correctly (whatever "correct" means

[Lldb-commits] [PATCH] D93299: [lldb] [unittests] Add tests for NetBSD register offsets/sizes

labath accepted this revision. labath added inline comments. Comment at: lldb/unittests/Process/Utility/CMakeLists.txt:4-5 RegisterContextFreeBSDTest.cpp + RegisterContextNetBSDTest_i386.cpp + RegisterContextNetBSDTest_x86_64.cpp LinuxProcMapsTest.cpp mgo

[Lldb-commits] [PATCH] D93299: [lldb] [unittests] Add tests for NetBSD register offsets/sizes

mgorny updated this revision to Diff 312418. mgorny added a comment. Made sources conditional to platform via CMake. If this is good, I'll update FreeBSD afterwards. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93299/new/ https://reviews.llvm.org/D93299 Files: lldb/unittests/Proces

[Lldb-commits] [lldb] b833898 - [lldb] Add std::array to the supported template list of the CxxModuleHandler

Author: Raphael Isemann Date: 2020-12-17T11:47:58+01:00 New Revision: b8338983e6f6ec6ebd48a7fc640b5d859e653b27 URL: https://github.com/llvm/llvm-project/commit/b8338983e6f6ec6ebd48a7fc640b5d859e653b27 DIFF: https://github.com/llvm/llvm-project/commit/b8338983e6f6ec6ebd48a7fc640b5d859e653b27.dif

[Lldb-commits] [PATCH] D93450: [lldb] [Process/FreeBSDRemote] Use RegSetKind consistently [NFC]

mgorny created this revision. mgorny added reviewers: emaste, krytarowski, labath. mgorny requested review of this revision. Use RegSetKind enum for register sets everything, rather than int. Always spell it as 'RegSetKind', without unnecessary 'enum'. Add missing switch case. While at it, use u

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

teemperor added a comment. Whether BOOL is `signed char` or `bool` is apparently depending on the architecture (???). See `ClangExpressionSourceCode::GetText`, Clang's `__OBJC_BOOL_IS_BOOL` macro and then there is also some preprocessor shenanigans for non-Clang ObjC (?) in the `objc.h` header

[Lldb-commits] [PATCH] D93299: [lldb] [unittests] Add tests for NetBSD register offsets/sizes

labath accepted this revision. labath added a comment. Looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93299/new/ https://reviews.llvm.org/D93299 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

teemperor added a comment. In D93421#2459853 , @labath wrote: > This seems suspicious to me, on a couple of levels. You claim that BOOL is an > unsigned type, but the apple documentation > says

[Lldb-commits] [lldb] 5644035 - [lldb] [unittests] Add tests for NetBSD register offsets/sizes

Author: Michał Górny Date: 2020-12-17T13:55:42+01:00 New Revision: 56440359d093ea6f8e9c91064fdd47928cf07092 URL: https://github.com/llvm/llvm-project/commit/56440359d093ea6f8e9c91064fdd47928cf07092 DIFF: https://github.com/llvm/llvm-project/commit/56440359d093ea6f8e9c91064fdd47928cf07092.diff

[Lldb-commits] [lldb] 37f99a5 - [lldb] [unittests] Filter FreeBSD through CMake rather than #ifdef

Author: Michał Górny Date: 2020-12-17T13:55:42+01:00 New Revision: 37f99a56065209627020428cecb78f55dfa90580 URL: https://github.com/llvm/llvm-project/commit/37f99a56065209627020428cecb78f55dfa90580 DIFF: https://github.com/llvm/llvm-project/commit/37f99a56065209627020428cecb78f55dfa90580.diff

[Lldb-commits] [PATCH] D93299: [lldb] [unittests] Add tests for NetBSD register offsets/sizes

This revision was automatically updated to reflect the committed changes. Closed by commit rG56440359d093: [lldb] [unittests] Add tests for NetBSD register offsets/sizes (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [lldb] e7a3c4c - [lldb-vscode] Speculative fix for raciness in TestVSCode_attach

Author: Pavel Labath Date: 2020-12-17T14:19:52+01:00 New Revision: e7a3c4c11e84ba99c3682ae6cf20c398f16cf3f5 URL: https://github.com/llvm/llvm-project/commit/e7a3c4c11e84ba99c3682ae6cf20c398f16cf3f5 DIFF: https://github.com/llvm/llvm-project/commit/e7a3c4c11e84ba99c3682ae6cf20c398f16cf3f5.diff

[Lldb-commits] [lldb] 5e31e22 - Remove Python2 fallback and only advertise Python3 in the doc

Author: serge-sans-paille Date: 2020-12-17T15:40:16+01:00 New Revision: 5e31e226b5b2b682607a6578ff5adb33daf4fe39 URL: https://github.com/llvm/llvm-project/commit/5e31e226b5b2b682607a6578ff5adb33daf4fe39 DIFF: https://github.com/llvm/llvm-project/commit/5e31e226b5b2b682607a6578ff5adb33daf4fe39.d

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think the proper fix here is to warn about BOOL bitfields with size 1 if BOOL is a typedef for signed char. I can make a Clang warning for that. I guess on the LLDB side we s

[Lldb-commits] [lldb] 122a4eb - Revert "[lldb] Make CommandInterpreter's execution context the same as debugger's one."

Author: Pavel Labath Date: 2020-12-17T17:47:53+01:00 New Revision: 122a4ebde3f4394a84e9f93b9c7085f088be6dd7 URL: https://github.com/llvm/llvm-project/commit/122a4ebde3f4394a84e9f93b9c7085f088be6dd7 DIFF: https://github.com/llvm/llvm-project/commit/122a4ebde3f4394a84e9f93b9c7085f088be6dd7.diff

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

labath added a comment. Sorry for not keeping track of this patch -- I'm not very active these days. Nevertheless, I did notice that this patch introduced some kind of nondeterminism/raciness/flakyness to the "finish" command. Specifically, it causes the command (as used in TestGuiBasicDebug.py

[Lldb-commits] [lldb] 9ead4e7 - [lldb] [Process/FreeBSDRemote] Replace GetRegisterSetCount()

Author: Michał Górny Date: 2020-12-17T18:01:14+01:00 New Revision: 9ead4e7b4a68d162122d861f5d5b6a3baf8d23c1 URL: https://github.com/llvm/llvm-project/commit/9ead4e7b4a68d162122d861f5d5b6a3baf8d23c1 DIFF: https://github.com/llvm/llvm-project/commit/9ead4e7b4a68d162122d861f5d5b6a3baf8d23c1.diff

[Lldb-commits] [lldb] 835f8de - [lldb] [Process/FreeBSDRemote] Use RegSetKind consistently [NFC]

Author: Michał Górny Date: 2020-12-17T18:01:46+01:00 New Revision: 835f8de8508953f4624534e36d54cd256e8800c9 URL: https://github.com/llvm/llvm-project/commit/835f8de8508953f4624534e36d54cd256e8800c9 DIFF: https://github.com/llvm/llvm-project/commit/835f8de8508953f4624534e36d54cd256e8800c9.diff

[Lldb-commits] [PATCH] D93396: [lldb] [Process/FreeBSDRemote] Replace GetRegisterSetCount()

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ead4e7b4a68: [lldb] [Process/FreeBSDRemote] Replace GetRegisterSetCount() (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D93450: [lldb] [Process/FreeBSDRemote] Use RegSetKind consistently [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rG835f8de85089: [lldb] [Process/FreeBSDRemote] Use RegSetKind consistently [NFC] (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

teemperor added a comment. I just realized that I got the char sign also mixed up. It's an `unsigned char` in LLDB, so the 255 is wrong (But I believe our char signedness handling is not correct in any C language). But the fact that we don't print YES/NO for that bitfield is right (just the int

[Lldb-commits] [PATCH] D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe.

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, vsk. Herald added a subscriber: jfb. JDevlieghere requested review of this revision. This is a speculative fix when looking at the finalization code in Process. It tackles the following issues: - Adds synchronization to p

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela created this revision. tammela requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. 1 - Partial Statements The interpreter loop runs every line it receives, so partial Lua statements are not being handled properly. This is a problem for

[Lldb-commits] [PATCH] D93225: [lldb] Add helper class for dealing with key:value; GDB responses

labath added a comment. I think that streamlining the packet (de)serialization process is badly needing. I'm not so sure about the approach though. On one hand, it's definitely an improvement. On the other, it does not handle the deserialization process, and I was hoping we could have a solutio

[Lldb-commits] [PATCH] D93438: ObjectFileELF: Test whether reloc_header is non-null instead of asserting.

pcc updated this revision to Diff 312608. pcc added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93438/new/ https://reviews.llvm.org/D93438 Files: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp lldb/test/Shell/Object

[Lldb-commits] [PATCH] D93495: CrashReason: Add MTE tag check faults to the list of crash reasons.

pcc created this revision. pcc added a reviewer: labath. Herald added a subscriber: emaste. pcc requested review of this revision. Herald added a project: LLDB. As of Linux 5.10, the kernel may report either of the two following crash reasons: - SEGV_MTEAERR: async MTE tag check fault - SEGV_MTES

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

shafik added a comment. After chatting with Raphael offline, we realize that `BOOL` will indeed always be signed. I was under the impression for some reason that it was actually unsigned. So the fix is simpler is that we just need to make the formatter use `GetValueAsSigned(...)` CHANGES SINC

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

shafik updated this revision to Diff 312636. shafik added a comment. Updating diff to reflect comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93421/new/ https://reviews.llvm.org/D93421 Files: lldb/source/Plugins/Language/ObjC/Cocoa.cpp lldb/test/API/functionalities/data-fo