[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

mgorny added a comment. In D92063#2416162 , @labath wrote: > +@mgorny, as he's been navigating these waters lately... > > So... I presume we can't just slap `__attribute__((packed))` on the > structure, because the kernel actually expects that the data st

[Lldb-commits] [lldb] 53a14a4 - [lldb] Fix TestThreadStepOut.py after "Flush local value map on every instruction"

Author: Raphael Isemann Date: 2020-11-26T09:43:47+01:00 New Revision: 53a14a47ee89dadb8798ca8ed19848f33f4551d5 URL: https://github.com/llvm/llvm-project/commit/53a14a47ee89dadb8798ca8ed19848f33f4551d5 DIFF: https://github.com/llvm/llvm-project/commit/53a14a47ee89dadb8798ca8ed19848f33f4551d5.dif

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

omjavaid added a comment. In D92063#2417815 , @mgorny wrote: > In D92063#2416162 , @labath wrote: > >> +@mgorny, as he's been navigating these waters lately... >> >> So... I presume we can't just slap `__attribute__

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

mgorny added a comment. I disagree. Since we're repeating gdb protocol, it would be nice to use offsets consistent with the gdb protocol, even if it means some extra padding. I do realize that this is broken right now and not trivially fixable but I don't think we should make things worse. CH

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

omjavaid added a comment. In D92063#2417948 , @mgorny wrote: > I disagree. Since we're repeating gdb protocol, it would be nice to use > offsets consistent with the gdb protocol, even if it means some extra > padding. I do realize that this is broken rig

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

labath added a comment. (I haven't looked at the new changes yet.) In D92063#2417948 , @mgorny wrote: > I disagree. Since we're repeating gdb protocol, it would be nice to use > offsets consistent with the gdb protocol, even if it means some extra paddin

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

mgorny added a comment. I was referring to: > Ideally offset calculation should look something like this: > reg[index].byte_offset = reg[index - 1].byte_offset + reg[index - > 1].byte_size. I'm not saying this is wrong for the time being but IMO we should assume that we might need to have a n

[Lldb-commits] [PATCH] D92164: Make SBDebugger internal variable getter and setter not use CommandInterpreter's context

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: jingham, JDevlieghere, labath. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. tatyana-krasnukha requested review of this revision. SBDebugger asks CommandInterpreter for execution context

[Lldb-commits] [PATCH] D91634: [lldb] Error when there are no ports to launch a gdbserver on

DavidSpickett updated this revision to Diff 307822. DavidSpickett added a comment. - Use auto for map find - Document PortMap functions - Remove unnecessary casts - Move tests to Process/gdb-remote - Cleanup Expected asserts The behaviour of AssociatePortWithProcess is a bit non obvious (that it

[Lldb-commits] [PATCH] D91634: [lldb] Error when there are no ports to launch a gdbserver on

DavidSpickett marked 6 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:234 if (ch == 'P') -gdbserver_portmap[portnum] = LLDB_INVALID_PROCESS_ID; +gdbserver_portmap.AllowPort(static_cast(port

[Lldb-commits] [PATCH] D92035: [lldb] Use llvm::Optional for port in LaunchGDBServer

DavidSpickett updated this revision to Diff 307824. DavidSpickett added a comment. - Reformat GDBRemoteCommunicationServerPlatform.h to fix include order. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92035/new/ https://reviews.llvm.org/D92035 Fil

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. Always set up entry point breakpoint on FreeBSD in order to establish the initial list of loaded libraries. Normally this list is cr

[Lldb-commits] [lldb] 3f6c856 - [ASTImporter] Import the default argument of TemplateTypeParmDecl

Author: Raphael Isemann Date: 2020-11-26T18:01:30+01:00 New Revision: 3f6c856bb5ae4426a586426bca9f1ef2848a2b12 URL: https://github.com/llvm/llvm-project/commit/3f6c856bb5ae4426a586426bca9f1ef2848a2b12 DIFF: https://github.com/llvm/llvm-project/commit/3f6c856bb5ae4426a586426bca9f1ef2848a2b12.dif

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f6c856bb5ae: [ASTImporter] Import the default argument of TemplateTypeParmDecl (authored by teemperor). Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Changed pr

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

teemperor added inline comments. Herald added a subscriber: JDevlieghere. Comment at: clang/lib/AST/ASTImporter.cpp:5161 - // FIXME: Import default argument and constraint expression. + // FIXME: Import constraint expression. martong wrote: > I wonder whet

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid updated this revision to Diff 307954. omjavaid added a comment. This update improves on last patch by adding support for register ordering in increasing order of register number even if register numbers are used randomly in target xml. Also we set offset to LLDB_INVALID_INDEX32 while in