[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

labath added a comment. Hm... Are you sure that this will help with anything? IIUC, the serialization of the VFS file map still happens in the context of the crashing process. This requires walking a bunch of data structures with liberally-asserting code, which will abort on any inconsistency i

[Lldb-commits] [lldb] dfb2266 - [lldb] Make DW_AT_declaration-with-children.s test more realistic

Author: Pavel Labath Date: 2020-10-19T10:34:13+02:00 New Revision: dfb22663287602a90ba249a96c9916227430a99e URL: https://github.com/llvm/llvm-project/commit/dfb22663287602a90ba249a96c9916227430a99e DIFF: https://github.com/llvm/llvm-project/commit/dfb22663287602a90ba249a96c9916227430a99e.diff

[Lldb-commits] [PATCH] D83302: [lldb/DWARF] Don't treat class declarations with children as definitions

labath added a comment. In D83302#2337264 , @jankratochvil wrote: > Fixed stale+unused `DW_AT_object_pointer`+`DW_AT_specification` by > rGfa89f641cf9f > . Thanks for catching that. I

[Lldb-commits] [PATCH] D89646: [nfc] [lldb] Move `LookupAddress` to `DWARFCompileUnit`

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks fine. The dwo construction code (SymbolFileDWARFDwo::GetDWOCompileUnitForHash) already ensures that the returned object is really a compile unit. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

labath added a comment. In D87868#2337537 , @aadsm wrote: > Should I still go ahead with this since @labath implemented the memory > allocation on lldb-server? I think going for global symbols still makes, and could still benefit some platforms, as my i

[Lldb-commits] [PATCH] D89383: [lldb] Correct vFile:pread/pwrite packet docs

DavidSpickett updated this revision to Diff 298954. DavidSpickett added a comment. - listing what we use decimal for is redundant - correct spelling of hexadecimal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89383/new/ https://reviews.llvm.org/D8

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:506 +for (uint32_t i = 0; i < num_sections; ++i) { + SectionSP section_sp(section_list->GetSectionAtIndex(i)); + const addr_t section_file_address = section_sp->GetFil

[Lldb-commits] [lldb] 0e5248b - [nfc] [lldb] Move LookupAddress to DWARFCompileUnit

Author: Jan Kratochvil Date: 2020-10-19T12:44:33+02:00 New Revision: 0e5248be8675db09b48680b9208b70f0e0908895 URL: https://github.com/llvm/llvm-project/commit/0e5248be8675db09b48680b9208b70f0e0908895 DIFF: https://github.com/llvm/llvm-project/commit/0e5248be8675db09b48680b9208b70f0e0908895.diff

[Lldb-commits] [PATCH] D89646: [nfc] [lldb] Move `LookupAddress` to `DWARFCompileUnit`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e5248be8675: [nfc] [lldb] Move LookupAddress to DWARFCompileUnit (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 299004. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 Files: lldb/bindings/interface/SBType.i lldb/include/lldb/API/SBModule.h lldb/include/lldb/API/SBType.h l

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum marked 2 inline comments as done. fallkrum added a comment. Did not noticed it must be 3 slashes instead of 2 :) > Also, please make sure that your patch is well formatted (git clang-format > HEAD~) before submitting it. git-clang-format HEAD~ says the patch is well formatted. Reposi

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. Can you please give me a couple of words on what m_static_type and m_dynamic_type is in TypeImpl class, in what cases can it be initialized with both of those types? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

labath added a comment. In D89283#2336280 , @vsk wrote: > In D89283#2336120 , @wallace wrote: > >> @vsk, I agree with you regarding the files. At the moment our implementation >> of intel-pt tracing doesn't support

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

labath added inline comments. Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:405 + bool HasError = false; + opt::InputArgList Args = Opts.parseArgs(argc - 1, argv + 1, OPT_UNKNOWN, + Saver, [&](llvm::StringRef Msg) { -

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

labath added a comment. In D87442#2334786 , @DavidSpickett wrote: >> Woa, back up. I though you were just going to add the one flag you need >> right now... :( > > I was going for the showing flags as a feature of the "memory region" command > then late

[Lldb-commits] [PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

bcardiff abandoned this revision. bcardiff added a comment. Closing in favor of D84563 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87590/new/ https://reviews.llvm.org/D87590 _

[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

JDevlieghere planned changes to this revision. JDevlieghere added a comment. In D89600#2337868 , @labath wrote: > Hm... Are you sure that this will help with anything? IIUC, the serialization > of the VFS file map still happens in the context of the crash

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

JDevlieghere added a comment. In D89334#2334881 , @labath wrote: > In D89334#2332452 , @JDevlieghere > wrote: > >> In D89334#2331903 , @labath wrote: >> >>> In D89334#233028

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Utility/Args.cpp:178 +Args::Args(llvm::ArrayRef args) : Args() { + for (llvm::StringRef arg : args) labath wrote:

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

jingham added a comment. You can make up types in the expression parser. So for instance, I can do: In D88483#2338408 , @fallkrum wrote: > Can you please give me a couple of words on what m_static_type and > m_dynamic_type is in TypeImpl class, in what

[Lldb-commits] [PATCH] D89716: [LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py

aganea created this revision. aganea added reviewers: amccarth, ted, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aganea requested review of this revision. Herald added a subscriber: JDevlieghere. Improve rG79809f58b02419a5d1bfb6c9a59dbd13cd038c77

[Lldb-commits] [PATCH] D89716: [LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yep Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89716/new/ https://reviews.llvm.org/D89716 ___ ll

[Lldb-commits] [PATCH] D89716: [LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG89b72209ad9b: [LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89716

[Lldb-commits] [lldb] 89b7220 - [LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py

Author: Alexandre Ganea Date: 2020-10-19T14:28:08-04:00 New Revision: 89b72209ad9baf585f6765df7c668da112dea230 URL: https://github.com/llvm/llvm-project/commit/89b72209ad9baf585f6765df7c668da112dea230 DIFF: https://github.com/llvm/llvm-project/commit/89b72209ad9baf585f6765df7c668da112dea230.dif

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Thanks! Done. On Sat, 17 Oct 2020 at 12:45, Galina Kistanova wrote: > Thanks everyone for keeping your annotated builders in the staging area! > Much appreciated. > > Please feel free to move all the green builders back to the production. It > has a new AnnotatedCommand now. > > Thanks > > Galin

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

There is some issue, at least on staging. http://lab.llvm.org:8014/#/builders/89/builds/184 has multiple failed stages but marked as SUCCESS On Mon, 19 Oct 2020 at 11:43, Vitaly Buka wrote: > Thanks! > Done. > > On Sat, 17 Oct 2020 at 12:45, Galina Kistanova > wrote: > >> Thanks everyone for k

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. In D88483#2339256 , @jingham wrote: > In D88483#2338408 , @fallkrum wrote: > >> Can you please give me a couple of words on what m_static_type and >> m_dynamic_type is in TypeImpl class, i

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

jingham added a comment. In D88483#2339845 , @fallkrum wrote: > In D88483#2339256 , @jingham wrote: > >> In D88483#2338408 , @fallkrum wrote: >> >>> Can you please give me a

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inlined comments for full details. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:506 +for (uint32_t i = 0; i < num_sections; ++i)

[Lldb-commits] [lldb] 8a203bb - [trace] rename ThreadIntelPT into TraceTrace

Author: Walter Erquinigo Date: 2020-10-19T15:15:02-07:00 New Revision: 8a203bb22d161d23c6b1195f85ae025e87f03bae URL: https://github.com/llvm/llvm-project/commit/8a203bb22d161d23c6b1195f85ae025e87f03bae DIFF: https://github.com/llvm/llvm-project/commit/8a203bb22d161d23c6b1195f85ae025e87f03bae.di

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to ThreadTrace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a203bb22d16: [trace] rename ThreadIntelPT into TraceTrace (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

clayborg added a comment. In D87868#2337537 , @aadsm wrote: > Should I still go ahead with this since @labath implemented the memory > allocation on lldb-server? yes! It might be best to move this lookup functionality into lldb_private::Target so other

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:506 +for (uint32_t i = 0; i < num_sections; ++i) { + SectionSP section_sp(section_list->GetSectionAtIndex(i)); + const addr_t section_file_address = section_sp->GetFile

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace marked 3 inline comments as done. wallace added a comment. @labath is right regarding the need of pre-baked binaries to test specific conditions. I'll remove the ld binary, as it really tests nothing useful, and i'll try to use yaml to represent the binaries in a more concise format.

[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

JDevlieghere updated this revision to Diff 299214. JDevlieghere added a comment. - Implement a FlushingFileCollector that appends paths to a file - Create the mapping out-of-process - Add an InProcessFinalizer that uses the current reproducer instance to copy over the files in-process CHANGES S

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

clayborg added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:31 +if (m_custom_error_message.empty()) { + std::ostringstream os; + os << pt_errstr(pt_errcode(GetErrorCode())) << ": 0x" << std::hex labath wrote: > `

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/test/API/commands/trace/TestTraceDumpInstructions.py:48 + [ 4] 0x40052d + [ 5] 0x400529 + [ 6] 0x400525 clayborg wrote: > If we reverse the direction, then hitting "enter

[Lldb-commits] [lldb] f96e16b - lldb: Update for change in `clang::Lexer`'s constructor

Author: Duncan P. N. Exon Smith Date: 2020-10-19T20:09:27-04:00 New Revision: f96e16bc15a9a10857681b85b6c8824b9addd9b2 URL: https://github.com/llvm/llvm-project/commit/f96e16bc15a9a10857681b85b6c8824b9addd9b2 DIFF: https://github.com/llvm/llvm-project/commit/f96e16bc15a9a10857681b85b6c8824b9add

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace marked 16 inline comments as done. wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/IntelPTDecoder.cpp:188 + if (int error = pt_image_set_callback(image, ReadProcessMemory, &process)) +return CreateLibiptError(error); + l

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 299236. wallace marked 3 inline comments as done. wallace added a comment. Addressed almost all changes. What's left to discuss: - I tried to use obj2yaml, but it creates files much larger than the binaries, so in terms of space, I'd rather keep the binarie

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

it's not just staging, this build must be marked as failed http://lab.llvm.org:8011/#/builders/74/builds/122 On Mon, 19 Oct 2020 at 11:50, Vitaly Buka wrote: > There is some issue, at least on staging. > http://lab.llvm.org:8014/#/builders/89/builds/184 has multiple failed > stages but marked a

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Thanks, Vitaly. Somebody is looking at this. On Mon, Oct 19, 2020 at 9:56 PM Vitaly Buka wrote: > it's not just staging, this build must be marked as failed > http://lab.llvm.org:8011/#/builders/74/builds/122 > > > On Mon, 19 Oct 2020 at 11:50, Vitaly Buka wrote: > >> There is some issue, at l

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

clayborg added a comment. In D89283#2340586 , @wallace wrote: > Addressed almost all changes. > > What's left to discuss: > > - I tried to use obj2yaml, but it creates files much larger than the > binaries, so in terms of space, I'd rather keep the binari

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace added a comment. > Do we need to know the instruction count? Again, won't this be really > expensive to calculate? It is expensive, but today I realized that it might be necessary to decode the entire trace if you want things to work nicely. Let's take, for example, a very common futur