[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 298052. wallace marked 11 inline comments as done. wallace added a comment. Changes: - Changed the callback signature of ForEachInstruction to receive an Expected - Use Expected more ubiquitously in IntelPTDecoder - Use MemoryBuffer to read the trace file -

[Lldb-commits] [PATCH] D89310: [lldb] Reject redefinitions of persistent variables

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb81e662a589: [lldb] Reject redefinitions of persistent variables (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [lldb] cb81e66 - [lldb] Reject redefinitions of persistent variables

Author: Raphael Isemann Date: 2020-10-14T10:24:35+02:00 New Revision: cb81e662a58908913f342520e4c010564a68126a URL: https://github.com/llvm/llvm-project/commit/cb81e662a58908913f342520e4c010564a68126a DIFF: https://github.com/llvm/llvm-project/commit/cb81e662a58908913f342520e4c010564a68126a.dif

[Lldb-commits] [PATCH] D89248: [lldb] [test/Register] Add read/write tests for multithreaded process

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89248/new/ https://reviews.llvm.org/D89248 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D89248: [lldb] [test/Register] Add read/write tests for multithreaded process

This revision was automatically updated to reflect the committed changes. Closed by commit rGcaedbc317a5a: [lldb] [test/Register] Add read/write tests for multithreaded process (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [lldb] caedbc3 - [lldb] [test/Register] Add read/write tests for multithreaded process

Author: Michał Górny Date: 2020-10-14T11:08:36+02:00 New Revision: caedbc317a5a4f046c345c136387e3ca199d8503 URL: https://github.com/llvm/llvm-project/commit/caedbc317a5a4f046c345c136387e3ca199d8503 DIFF: https://github.com/llvm/llvm-project/commit/caedbc317a5a4f046c345c136387e3ca199d8503.diff

[Lldb-commits] [PATCH] D89315: [debugserver] Add option to propagate SIGSEGV to target process

aarzilli updated this revision to Diff 298077. aarzilli added a comment. > I wonder if the implementation would be less intrusive (and keep some of > these functions from adding to their already too many arguments) if you added > this flag to the RNBContext that RNBRemote holds onto. Done. > Y

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

labath added a comment. The main question on my mind is should we be adding the directory of the python file to the path (which is what I believe is happening now), or if we should add the directory of the command file that is being sourced (and adjust the way we import the file). The main impa

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

DavidSpickett added a comment. > After some undefined transition period :) we change lldb to assume the > correct gdb-compatible behavior. > > The biggest hurdle for changing the default are iOS/watchOS devices out in > the field - we cannot update the old debugservers that run on them, so we >

[Lldb-commits] [PATCH] D89383: [lldb] Correct vFile:pread/pwrite packet docs

DavidSpickett created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere. The statement that lldb-server can handle decimal and hex numbers is misleading. (it can only handle

[Lldb-commits] [PATCH] D89335: [lldb] Generic support for caching register set reads/writes [WIP]

mgorny planned changes to this revision. mgorny added a comment. Ok, this is going to have to wait. I've found some hard bug in NetBSD's xstate support and don't have time+resources to figure it out at the moment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89335/new/ https://reviews

[Lldb-commits] [PATCH] D89335: [lldb] Generic support for caching register set reads/writes [WIP]

labath added a comment. I'm wondering if this could be implemented as some kind of a separate class which you "mix" into your register context when you want to do caching. Possibly something like this: class NRCLinux_MyArch: public NRCLinux, private RCCache::Backend { RCCache m_cache;

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

labath added a comment. Yeah, using qSupport also works. It just seems like it would be possible to handle this particular issue without adding the generic framework, so I was throwing that idea out too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] 6bb123b - [lldb] Modernize PseudoTerminal::OpenFirstAvailablePrimary

Author: Pavel Labath Date: 2020-10-14T14:55:03+02:00 New Revision: 6bb123b819c61c61197ec2ba54ceb6d16e9121cf URL: https://github.com/llvm/llvm-project/commit/6bb123b819c61c61197ec2ba54ceb6d16e9121cf DIFF: https://github.com/llvm/llvm-project/commit/6bb123b819c61c61197ec2ba54ceb6d16e9121cf.diff

[Lldb-commits] [lldb] 2c4226f - [lldb-server][linux] Add ability to allocate memory

Author: Pavel Labath Date: 2020-10-14T15:02:09+02:00 New Revision: 2c4226f8ac2c925d7e1d59d1de1660cd1dd63f31 URL: https://github.com/llvm/llvm-project/commit/2c4226f8ac2c925d7e1d59d1de1660cd1dd63f31 DIFF: https://github.com/llvm/llvm-project/commit/2c4226f8ac2c925d7e1d59d1de1660cd1dd63f31.diff

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c4226f8ac2c: [lldb-server][linux] Add ability to allocate memory (authored by labath). Changed prior to commit: https://reviews.llvm.org/D89124?v

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. In D82863#2324560 , @omjavaid wrote: > In D82863#2321647 , @labath wrote: > >> In D82863#2321370 , @omjavaid wrote: >> >>> In D82863#2320342

[Lldb-commits] [lldb] ea3a547 - [lldb] Remove bogus ProcessMonitor forward-decls

Author: Pavel Labath Date: 2020-10-14T16:43:45+02:00 New Revision: ea3a547f0be20d86b041778ae8e2779f2031f714 URL: https://github.com/llvm/llvm-project/commit/ea3a547f0be20d86b041778ae8e2779f2031f714 DIFF: https://github.com/llvm/llvm-project/commit/ea3a547f0be20d86b041778ae8e2779f2031f714.diff

[Lldb-commits] [lldb] 36f22cd - [lldb] Fix TestGdbRemoteMemoryAllocation on windows

Author: Pavel Labath Date: 2020-10-14T16:46:10+02:00 New Revision: 36f22cd28d5e57c197ea374048a06dbdc5a08214 URL: https://github.com/llvm/llvm-project/commit/36f22cd28d5e57c197ea374048a06dbdc5a08214 DIFF: https://github.com/llvm/llvm-project/commit/36f22cd28d5e57c197ea374048a06dbdc5a08214.diff

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/API/SBType.cpp:504 +if (!IsValid()) +return sb_module; + mib wrote: > It would be nice to r

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

JDevlieghere added a comment. In D89334#2329667 , @labath wrote: > The main question on my mind is should we be adding the directory of the > python file to the path (which is what I believe is happening now), or if we > should add the directory of the c

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

stella.stamenova added a comment. It looks like this changed caused a failure on the windows bot and your follow up change to fix the test left it still broken. Can you have a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89124/new/ https://

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT into TraceTrace

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. wallace requested review of this revision. Herald added a subscriber: JDevlieghere. Renamed ThreadIntelPT to TreaceThread, making it a top-level c

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 298184. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 Files: lldb/bindings/interface/SBType.i lldb/include/lldb/API/SBModule.h lldb/include/lldb/API/SBType.h l

[Lldb-commits] [PATCH] D89315: [debugserver] Add option to propagate SIGSEGV to target process

jingham added a comment. Thanks, that's a little better. It would be even nicer if the DNB API's you are adding "unmask_signals" to would take the Context instead. At this point they are pulling the launch flavor and the unmask signals from the context, so just getting the RNBContext would be

[Lldb-commits] [lldb] ff30bff - [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

Author: Michał Górny Date: 2020-10-14T19:56:46+02:00 New Revision: ff30bff136743817dae66029f512cdb3a009937f URL: https://github.com/llvm/llvm-project/commit/ff30bff136743817dae66029f512cdb3a009937f DIFF: https://github.com/llvm/llvm-project/commit/ff30bff136743817dae66029f512cdb3a009937f.diff

[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

This revision was automatically updated to reflect the committed changes. Closed by commit rGff30bff13674: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D89413: [lldb] [Process/FreeBSDRemote] Initial multithreading support

mgorny created this revision. mgorny added reviewers: krytarowski, labath, emaste. mgorny requested review of this revision. Implement initial support for watching thread creation and termination. Update ptrace() calls to correctly indicate requested thread. Watchpoints are not supported yet. Thi

[Lldb-commits] [lldb] a1ab2b7 - [lldb] More memory allocation test fixes

Author: Pavel Labath Date: 2020-10-14T20:43:47+02:00 New Revision: a1ab2b773b6d78ec71edfebd2474c403cbe77977 URL: https://github.com/llvm/llvm-project/commit/a1ab2b773b6d78ec71edfebd2474c403cbe77977 DIFF: https://github.com/llvm/llvm-project/commit/a1ab2b773b6d78ec71edfebd2474c403cbe77977.diff

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

labath added a comment. It looks like the windows lldb-server implementation does not support all permission combinations (`ConvertLldbToWinApiProtect` in `ProcessDebugger.cpp`). I've xfailed the test for now -- I'll try to add the missing bits tomorrow. I've also messed up the decorators on o

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to TraceTrace

wallace updated this revision to Diff 298208. wallace added a comment. some cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89408/new/ https://reviews.llvm.org/D89408 Files: lldb/include/lldb/Target/TraceSessionFileParser.h lldb/include/

[Lldb-commits] [PATCH] D89358: Add an API to get an SBBreakpoint's owning SBTarget

jingham updated this revision to Diff 298210. jingham added a comment. Use lldb-instr instead of hand-generating the reproducer wrappers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89358/new/ https://reviews.llvm.org/D89358 Files: lldb/bindin

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to TraceThread

wallace updated this revision to Diff 298211. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89408/new/ https://reviews.llvm.org/D89408 Files: lldb/include/lldb/Target/TraceSessionFileParser.h lldb/include/lldb/Tar

[Lldb-commits] [PATCH] D89413: [lldb] [Process/FreeBSDRemote] Initial multithreading support

mgorny updated this revision to Diff 298226. mgorny added a comment. Forgot to run `clang-format`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89413/new/ https://reviews.llvm.org/D89413 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp lldb/source/Plugins/

[Lldb-commits] [PATCH] D89155: [lldb] Minidump: check for .text hash match with directory

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Sorry for the delay, I was out of town until today. Changes look good! Always good to have more robust support for finding binaries in the sysroot. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D89428: Add support for more OS types to AddClangModuleCompilationOptionsForSDKType()

aprantl created this revision. aprantl added reviewers: JDevlieghere, teemperor. aprantl requested review of this revision. [This is upstreaming an Apple Silicon support patch rdar://problem/66927829] This patch also avoids hardcoding the clang options, which makes it less likely for them to bec

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 298253. wallace added a comment. - Moved the non intel-pt changes to D89408 - Added some more complex tests: - A multifile case in which even the dynamic linker code is decoded - A variation of that case that doesn't decla

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

I switched sanitizers and two rnk@ bots back to the primary server. http://lab.llvm.org:8011/#/waterfall?tags=sanitizer On Tue, 13 Oct 2020 at 22:42, Vitaly Buka wrote: > They do on staging. > http://lab.llvm.org:8014/#/builders/sanitizer-windows > http://lab.llvm.org:8014/#/builders/clang-x64-w

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Thanks everyone! I would like to keep the bots in the staging till Friday. And if everything is good, then apply the changes to the production and let you move all the green bots back there. Thanks Galina On Tue, Oct 13, 2020 at 10:43 PM Vitaly Buka wrote: > They do on staging. > http://lab.

[Lldb-commits] [lldb] b198568 - Fix typeo in attach failed error message.

Author: Jason Molenda Date: 2020-10-14T23:31:24-07:00 New Revision: b19856881c1624df8b667d672193be52dfa23846 URL: https://github.com/llvm/llvm-project/commit/b19856881c1624df8b667d672193be52dfa23846 DIFF: https://github.com/llvm/llvm-project/commit/b19856881c1624df8b667d672193be52dfa23846.diff

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 298311. wallace added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89283/new/ https://reviews.llvm.org/D89283 Files: lldb/include/lldb/Target/Trace.h lldb/source/Plugins/Process/Trace/P