[Lldb-commits] [PATCH] D88282: Add support for a "main bin spec" LC_NOTE for standalone/firmware corefile binaries in MachO corefiles

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: JDevlieghere. jasonmolenda requested review of this revision. This patch is primarily to ProcessMachCore to correctly lo

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

DavidSpickett updated this revision to Diff 294266. DavidSpickett added a comment. - Convert memory region to early return style to make the logic clearer - Only call ::GetLastError once when VirtualQueryEx fails Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1701 } else { if (command.GetArgumentCount() == 1) { auto load_addr_str = command[0].ref(); stella.stamenova wrote: > Actually, I would change

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

DavidSpickett updated this revision to Diff 294272. DavidSpickett added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88229/new/ https://reviews.llvm.org/D88229 Files: lldb/source/Commands/CommandObjectMemory.cpp lldb

[Lldb-commits] [PATCH] D88247: Fix memory leak in SBValue::GetAddress

werat added a comment. Thanks for reviewing and writing a follow-up change! Changing the ctor to accept a const reference is indeed a cleaner solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88247/new/ https://reviews.llvm.org/D88247 _

[Lldb-commits] [PATCH] D88249: [lldb] Make protected ctor and method of SBAddress take a const reference instead of a pointer.

werat accepted this revision. werat added a comment. This revision is now accepted and ready to land. Thanks for refactoring this! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88249/new/ https://reviews.llvm.org/D88249

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:302 + virtual StructuredData::GenericSP + CreateScriptedStopHook(lldb::TargetSP target_sp, con

[Lldb-commits] [PATCH] D88282: Add support for a "main bin spec" LC_NOTE for standalone/firmware corefile binaries in MachO corefiles

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:94 + // If we have a corefile binary hint, this enum + // specifies the binary type which we can use to `///` Comment at: lldb/include/lldb/Symbol/ObjectF

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88229/new/ https://reviews.llvm.org/D88229 _

[Lldb-commits] [lldb] 6cd4a4c - [lldb] Pass reference instead of pointer in protected SBAddress methods.

Author: Jonas Devlieghere Date: 2020-09-25T11:47:05-07:00 New Revision: 6cd4a4cd02dba6aed33c447114587eebf6854c43 URL: https://github.com/llvm/llvm-project/commit/6cd4a4cd02dba6aed33c447114587eebf6854c43 DIFF: https://github.com/llvm/llvm-project/commit/6cd4a4cd02dba6aed33c447114587eebf6854c43.d

[Lldb-commits] [PATCH] D88249: [lldb] Make protected ctor and method of SBAddress take a const reference instead of a pointer.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cd4a4cd02db: [lldb] Pass reference instead of pointer in protected SBAddress methods. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D88282: Add support for a "main bin spec" LC_NOTE for standalone/firmware corefile binaries in MachO corefiles

jasonmolenda added a comment. Thanks for the feedback! Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:5567 uuid = UUID::fromOptionalData(raw_uuid, sizeof(uuid_t)); + switch (binspec_type) { + case 0: --

[Lldb-commits] [lldb] 1bec6eb - Add support for firmware/standalone LC_NOTE "main bin spec" corefiles

Author: Jason Molenda Date: 2020-09-25T15:19:22-07:00 New Revision: 1bec6eb3f5cba594698bae5b2789744e0c8ee5f2 URL: https://github.com/llvm/llvm-project/commit/1bec6eb3f5cba594698bae5b2789744e0c8ee5f2 DIFF: https://github.com/llvm/llvm-project/commit/1bec6eb3f5cba594698bae5b2789744e0c8ee5f2.diff

[Lldb-commits] [PATCH] D88282: Add support for a "main bin spec" LC_NOTE for standalone/firmware corefile binaries in MachO corefiles

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bec6eb3f5cb: Add support for firmware/standalone LC_NOTE "main bi

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jingham marked 5 inline comments as done. Closed by commit rGb65966cff65b: Add the ability to write target stop-hooks using the ScriptInterpreter. (authored by jingham)

[Lldb-commits] [lldb] b65966c - Add the ability to write target stop-hooks using the ScriptInterpreter.

Author: Jim Ingham Date: 2020-09-25T15:44:55-07:00 New Revision: b65966cff65bfb66de59621347ffd97238d3f645 URL: https://github.com/llvm/llvm-project/commit/b65966cff65bfb66de59621347ffd97238d3f645 DIFF: https://github.com/llvm/llvm-project/commit/b65966cff65bfb66de59621347ffd97238d3f645.diff LO

[Lldb-commits] [lldb] 67782a0 - [lldb/bindings] Fix -Wformat after D88123

Author: Fangrui Song Date: 2020-09-25T17:33:12-07:00 New Revision: 67782a0f99c6a792c9d60267d42b21f7335814ba URL: https://github.com/llvm/llvm-project/commit/67782a0f99c6a792c9d60267d42b21f7335814ba DIFF: https://github.com/llvm/llvm-project/commit/67782a0f99c6a792c9d60267d42b21f7335814ba.diff