[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

2020-09-09 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for the cleanup! (And also having the second list of comments no longer always stating 'SpringBoard' is even better). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D87345: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS

2020-09-09 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87345/new/ https://reviews.llvm.org/D87345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [lldb] 4e4a3fe - [lldb][doc] Mention python3-dev instead of python2.7-dev in build docs

2020-09-09 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-09-09T09:31:27+02:00 New Revision: 4e4a3feecdb6bd56483b9c6ba9116609c20588aa URL: https://github.com/llvm/llvm-project/commit/4e4a3feecdb6bd56483b9c6ba9116609c20588aa DIFF: https://github.com/llvm/llvm-project/commit/4e4a3feecdb6bd56483b9c6ba9116609c20588aa.dif

[Lldb-commits] [lldb] 32c8da4 - [lldb] Don't infinite loop in SemaSourceWithPriorities::CompleteType when trying to complete a forward decl

2020-09-09 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-09-09T10:05:57+02:00 New Revision: 32c8da41dc0cb99651823a1a21130c2cbdf688e1 URL: https://github.com/llvm/llvm-project/commit/32c8da41dc0cb99651823a1a21130c2cbdf688e1 DIFF: https://github.com/llvm/llvm-project/commit/32c8da41dc0cb99651823a1a21130c2cbdf688e1.dif

[Lldb-commits] [PATCH] D87289: [lldb] Don't infinite loop in SemaSourceWithPriorities::CompleteType when trying to complete a forward decl

2020-09-09 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG32c8da41dc0c: [lldb] Don't infinite loop in SemaSourceWithPriorities::CompleteType when… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to co

[Lldb-commits] [lldb] 7866b91 - [lldb] Fix a crash when the ASTImporter is giving us two Imported callbacks for the same target decl

2020-09-09 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-09-09T10:31:39+02:00 New Revision: 7866b91405693df5b4cf6ba770b3a92d48b0c508 URL: https://github.com/llvm/llvm-project/commit/7866b91405693df5b4cf6ba770b3a92d48b0c508 DIFF: https://github.com/llvm/llvm-project/commit/7866b91405693df5b4cf6ba770b3a92d48b0c508.dif

[Lldb-commits] [PATCH] D85648: [lldb] Fix a crash when the ASTImporter is giving us two Imported callbacks for the same target decl

2020-09-09 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7866b9140569: [lldb] Fix a crash when the ASTImporter is giving us two Imported callbacks for… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [lldb] b852225 - [lldb] Enable std::pair in CxxModuleHandler

2020-09-09 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-09-09T10:49:53+02:00 New Revision: b85222520f861a1812f991d6bd65950dda22f31b URL: https://github.com/llvm/llvm-project/commit/b85222520f861a1812f991d6bd65950dda22f31b DIFF: https://github.com/llvm/llvm-project/commit/b85222520f861a1812f991d6bd65950dda22f31b.dif

[Lldb-commits] [PATCH] D85141: [lldb] Enable std::pair in CxxModuleHandler

2020-09-09 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb85222520f86: [lldb] Enable std::pair in CxxModuleHandler (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

2020-09-09 Thread Valentin Clement via Phabricator via lldb-commits
clementval created this revision. clementval added reviewers: sscalpone, schweitz, jeanPerier, DavidTruby, jdoerfert. Herald added subscribers: lldb-commits, rriddle. Herald added a project: LLDB. clementval requested review of this revision. Herald added subscribers: stephenneuendorffer, JDevlieg

[Lldb-commits] [PATCH] D87345: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS

2020-09-09 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87345/new/ https://reviews.llvm.org/D87345 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

2020-09-09 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/docs/resources/test.rst:427 +actual hardware. QEMU helper scripts and README.txt document can be found under +llvm-project/lldb/scripts/lldb-test-qemu which can help setup a virtual testing +environment for LLDB using QEMU. The

[Lldb-commits] [PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

2020-09-09 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:41 focus_tid(LLDB_INVALID_THREAD_ID), sent_terminated_event(false), - stop_at_entry(false), is_a

[Lldb-commits] [PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

2020-09-09 Thread Valentin Clement via Phabricator via lldb-commits
clementval added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:41 focus_tid(LLDB_INVALID_THREAD_ID), sent_terminated_event(false), - stop_at_entry(false), is_attach(false), - reverse_request_seq(0), waiting_for_run_in_terminal(false) { + sto

[Lldb-commits] [PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

2020-09-09 Thread Sourabh Singh Tomar via Phabricator via lldb-commits
SouraVX added a comment. Since `bbc` based test can't be added here, would you mind adding a unit-test here ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87389/new/ https://reviews.llvm.org/D87389 ___

[Lldb-commits] [PATCH] D87345: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS

2020-09-09 Thread Dave Lee via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG447ba60a224f: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87345/new/

[Lldb-commits] [lldb] 447ba60 - [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS

2020-09-09 Thread Dave Lee via lldb-commits
Author: Dave Lee Date: 2020-09-09T11:07:57-07:00 New Revision: 447ba60a224f63524a3bc40cdc1cfdbf1f8383db URL: https://github.com/llvm/llvm-project/commit/447ba60a224f63524a3bc40cdc1cfdbf1f8383db DIFF: https://github.com/llvm/llvm-project/commit/447ba60a224f63524a3bc40cdc1cfdbf1f8383db.diff LOG:

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

2020-09-09 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added a comment. @teemperor I'm not sure what these build errors mean, for example https://reviews.llvm.org/B70998. Also there's the linux build failure, but that's not relevant for debugserver, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

2020-09-09 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D87327#2263971 , @kastiglione wrote: > @teemperor I'm not sure what these build errors mean, for example > https://reviews.llvm.org/B70998. Also there's the linux build failure, but > that's not relevant for debugserver, rig

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

2020-09-09 Thread Dave Lee via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55dd731b291c: [debugserver] Extract function for default launch flavor (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [lldb] 55dd731 - [debugserver] Extract function for default launch flavor

2020-09-09 Thread Dave Lee via lldb-commits
Author: Dave Lee Date: 2020-09-09T11:35:44-07:00 New Revision: 55dd731b291c2d64f318f27c40a17d2255e16215 URL: https://github.com/llvm/llvm-project/commit/55dd731b291c2d64f318f27c40a17d2255e16215 DIFF: https://github.com/llvm/llvm-project/commit/55dd731b291c2d64f318f27c40a17d2255e16215.diff LOG:

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

2020-09-09 Thread Jordan Rupprecht via Phabricator via lldb-commits
rupprecht updated this revision to Diff 290799. rupprecht added a comment. - Don't use "localhost" to avoid dns latency. Instead, prefer either 127.0.0.1 or ::1 directly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87333/new/ https://reviews.llv

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

2020-09-09 Thread Jordan Rupprecht via Phabricator via lldb-commits
rupprecht updated this revision to Diff 290800. rupprecht added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87333/new/ https://reviews.llvm.org/D87333 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbre

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

2020-09-09 Thread Jordan Rupprecht via Phabricator via lldb-commits
rupprecht added a comment. This is ready for review now after scrubbing out the "localhost" changes I had earlier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87333/new/ https://reviews.llvm.org/D87333 __

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

2020-09-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Thanks for the extra work arounds! LGTM. Pavel? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87333/new/ https://reviews.llvm.org/D87333 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] 2955a27 - [lldb] Pass the arch as part of the triple in the ARCH_CFLAGS

2020-09-09 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-09-09T14:41:25-07:00 New Revision: 2955a27abc25cd1b9d737c211c2cfe11e2a5de3e URL: https://github.com/llvm/llvm-project/commit/2955a27abc25cd1b9d737c211c2cfe11e2a5de3e DIFF: https://github.com/llvm/llvm-project/commit/2955a27abc25cd1b9d737c211c2cfe11e2a5de3e.d