[Lldb-commits] [lldb] e89414f - [lldb/Utility] Clean up Scalar constructors

Author: Pavel Labath Date: 2020-07-27T10:06:56+02:00 New Revision: e89414f4060d3ff2afcd1c89fc028d61270c4d22 URL: https://github.com/llvm/llvm-project/commit/e89414f4060d3ff2afcd1c89fc028d61270c4d22 DIFF: https://github.com/llvm/llvm-project/commit/e89414f4060d3ff2afcd1c89fc028d61270c4d22.diff

[Lldb-commits] [lldb] 81d7eba - [lldb/Utility] Fix a bug in RangeMap::CombineConsecutiveRanges

Author: Pavel Labath Date: 2020-07-27T10:06:56+02:00 New Revision: 81d7ebaf5c369d42b77f9e3e47e2ac22c306ec04 URL: https://github.com/llvm/llvm-project/commit/81d7ebaf5c369d42b77f9e3e47e2ac22c306ec04 DIFF: https://github.com/llvm/llvm-project/commit/81d7ebaf5c369d42b77f9e3e47e2ac22c306ec04.diff

[Lldb-commits] [PATCH] D84623: Remove HAVE_VCS_VERSION_INC, not needed

hlopko created this revision. hlopko added a reviewer: gribozavr2. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, mgorny. Herald added a reviewer: MaskRay. Herald added projects: clang, LLDB, LLVM. This preprocessor define was meant to be used to conditionally include headers w

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h:22 +#define INCLUDE_LINUX_PTRACE_DEFINITIONS_FOR_SVE_ARM64 +#include "Plugins/Process/Utility/LinuxPTraceDefines_arm64sve.h" +#endif omjavaid wrote: >

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added a comment. In D81001#2172658 , @gedatsu217 wrote: > I do not intend for this feature to work with colors disabled. Right in that case, we should probably disable the feature if colors are disabled. > I found that pexpect output the below s

[Lldb-commits] [lldb] 2e828e7 - [lldb] Fix e89414f406 for msvc

Author: Pavel Labath Date: 2020-07-27T11:49:46+02:00 New Revision: 2e828e7579928e8cc1c5e53c84ab99ffb5afca03 URL: https://github.com/llvm/llvm-project/commit/2e828e7579928e8cc1c5e53c84ab99ffb5afca03 DIFF: https://github.com/llvm/llvm-project/commit/2e828e7579928e8cc1c5e53c84ab99ffb5afca03.diff

[Lldb-commits] [lldb] 1956cf1 - [lldb/DWARF] Don't treat class declarations with children as definitions

Author: Pavel Labath Date: 2020-07-27T12:58:22+02:00 New Revision: 1956cf1042d3c406d9e9cefe47d3b43adf2bdbe1 URL: https://github.com/llvm/llvm-project/commit/1956cf1042d3c406d9e9cefe47d3b43adf2bdbe1 DIFF: https://github.com/llvm/llvm-project/commit/1956cf1042d3c406d9e9cefe47d3b43adf2bdbe1.diff

[Lldb-commits] [PATCH] D83302: [lldb/DWARF] Don't treat class declarations with children as definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rG1956cf1042d3: [lldb/DWARF] Don't treat class declarations with children as definitions (authored by labath). Changed prior to commit: https://reviews.llvm.org/D83302?vs=276048&id=280847#toc Repository:

[Lldb-commits] [PATCH] D84402: [lldb/DWARF] Add more line table validation

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1044 for (const llvm::DWARFDebugLine::Sequence &seq : line_table->Sequences) { +if (!list.ContainsFileAddressRange(seq.LowPC, seq.Hig

[Lldb-commits] [PATCH] D84530: [lldb] Modernize away some snprintf calls

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb203e026847: [lldb] Modernize away some snprintf calls (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] db203e0 - [lldb] Modernize away some snprintf calls

Author: Raphael Isemann Date: 2020-07-27T14:27:54+02:00 New Revision: db203e0268479d16d36a318c726cce5a4a5f75a6 URL: https://github.com/llvm/llvm-project/commit/db203e0268479d16d36a318c726cce5a4a5f75a6 DIFF: https://github.com/llvm/llvm-project/commit/db203e0268479d16d36a318c726cce5a4a5f75a6.dif

[Lldb-commits] [lldb] 4322419 - [lldb][NFC] Use a StringRef for AddRegexCommand::AddRegexCommand parameters

Author: Raphael Isemann Date: 2020-07-27T14:36:47+02:00 New Revision: 432241955e032fba3d8b584ee6388212909bee9b URL: https://github.com/llvm/llvm-project/commit/432241955e032fba3d8b584ee6388212909bee9b DIFF: https://github.com/llvm/llvm-project/commit/432241955e032fba3d8b584ee6388212909bee9b.dif

[Lldb-commits] [PATCH] D84528: [lldb][NFC] Use a StringRef for AddRegexCommand::AddRegexCommand parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rG432241955e03: [lldb][NFC] Use a StringRef for AddRegexCommand::AddRegexCommand parameters (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG L

[Lldb-commits] [PATCH] D83767: [lldb] Use the basename of the Python test for the log name instead of the class name

teemperor planned changes to this revision. teemperor added a comment. Got reverted, so back to my TODO queue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83767/new/ https://reviews.llvm.org/D83767 _

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added a comment. > Could you create a patch to change the definition of ANSI_UNFAINT ? (might be > worth taking a quick look at git history if there is no good reason for why > it uses the color code that it uses) Sure. Should I create another patch? (In short, should I create it sep

Re: [Lldb-commits] [lldb] 1d9b860 - Unify the return value of GetByteSize to an llvm::Optional (NFC-ish)

Thanks, Eric! Sorry for not paying attention after landing this. -- adrian > On Jul 25, 2020, at 6:43 PM, Eric Christopher wrote: > > Hi Adrian, > > I'm really sorry, but I've just reverted this. I'm not sure what's up, but > it's causing massive test failures in lldb on linux. Happy to help

Re: [Lldb-commits] [lldb] 1d9b860 - Unify the return value of GetByteSize to an llvm::Optional (NFC-ish)

No problem, thanks! :) On Mon, Jul 27, 2020, 9:26 AM Adrian Prantl wrote: > Thanks, Eric! Sorry for not paying attention after landing this. > > -- adrian > > On Jul 25, 2020, at 6:43 PM, Eric Christopher wrote: > > Hi Adrian, > > I'm really sorry, but I've just reverted this. I'm not sure what

Re: [Lldb-commits] [lldb] 1d9b860 - Unify the return value of GetByteSize to an llvm::Optional (NFC-ish)

Do you happen to have a link to a bot with the failures? Or can you send me the output in case it's an internal bot? thanks, adrian > On Jul 27, 2020, at 9:54 AM, Eric Christopher wrote: > > No problem, thanks! :) > > On Mon, Jul 27, 2020, 9:26 AM Adrian Prantl > wr

Re: [Lldb-commits] [lldb] 1d9b860 - Unify the return value of GetByteSize to an llvm::Optional (NFC-ish)

On 27/07/2020 19:03, Adrian Prantl via lldb-commits wrote: > Do you happen to have a link to a bot with the failures? Or can you send > me the output in case it's an internal bot? > > thanks, > adrian > This should do it: http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/14598

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added a comment. In D81001#2176076 , @gedatsu217 wrote: > > Could you create a patch to change the definition of ANSI_UNFAINT ? (might > > be worth taking a quick look at git history if there is no good reason for > > why it uses the color code th

Re: [Lldb-commits] [lldb] 1d9b860 - Unify the return value of GetByteSize to an llvm::Optional (NFC-ish)

Thanks Pavel :) On Mon, Jul 27, 2020, 11:35 AM Pavel Labath wrote: > On 27/07/2020 19:03, Adrian Prantl via lldb-commits wrote: > > Do you happen to have a link to a bot with the failures? Or can you send > > me the output in case it's an internal bot? > > > > thanks, > > adrian > > > > This sho

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 updated this revision to Diff 281017. gedatsu217 added a comment. Revise Editline::ApplyAutosuggestCommand. (Change the return value.) Revise IOHandlerEditline::IOHandlerEditline (Disable to use autosuggestion if debugger.GetUseColor() is false.) Fix the test. CHANGES SINCE LAST AC

[Lldb-commits] [lldb] 536baa1 - [lldb] Remove CMAKE_VERSION checks now that the minimum version is 3.13.4

Author: Jonas Devlieghere Date: 2020-07-27T12:31:41-07:00 New Revision: 536baa11cfe12362ea646ad731a2274a07208cc0 URL: https://github.com/llvm/llvm-project/commit/536baa11cfe12362ea646ad731a2274a07208cc0 DIFF: https://github.com/llvm/llvm-project/commit/536baa11cfe12362ea646ad731a2274a07208cc0.d

[Lldb-commits] [lldb] 4c6eebf - [lldb/AppleSimulator] Always provide a -simulator environment

Author: Fred Riss Date: 2020-07-27T12:50:50-07:00 New Revision: 4c6eebf86a0734779cd20473cfcaa9d7c8899298 URL: https://github.com/llvm/llvm-project/commit/4c6eebf86a0734779cd20473cfcaa9d7c8899298 DIFF: https://github.com/llvm/llvm-project/commit/4c6eebf86a0734779cd20473cfcaa9d7c8899298.diff LOG

[Lldb-commits] [PATCH] D84402: [lldb/DWARF] Add more line table validation

clayborg added a comment. I really like the idea of coming up with a low PC that is the first valid .text address. This will filter out many of the zeroed out dead stripped DWARF and will make a cheap way for us to check addresses when parsing debug info and line tables. Checking for -1 and -2

[Lldb-commits] [lldb] 113f56f - Unify the return value of GetByteSize to an llvm::Optional (NFC-ish)

Author: Adrian Prantl Date: 2020-07-27T13:26:35-07:00 New Revision: 113f56fbb80e8d6f705be19f8ae169a3fee2e4f8 URL: https://github.com/llvm/llvm-project/commit/113f56fbb80e8d6f705be19f8ae169a3fee2e4f8 DIFF: https://github.com/llvm/llvm-project/commit/113f56fbb80e8d6f705be19f8ae169a3fee2e4f8.diff

[Lldb-commits] [lldb] ef748b5 - [lldb] NFC: Use early exit in ArchSpec::IsEqualTo

Author: Fred Riss Date: 2020-07-27T14:12:02-07:00 New Revision: ef748b58d3b3edfaf0278d454cb30f7816c04aee URL: https://github.com/llvm/llvm-project/commit/ef748b58d3b3edfaf0278d454cb30f7816c04aee DIFF: https://github.com/llvm/llvm-project/commit/ef748b58d3b3edfaf0278d454cb30f7816c04aee.diff LOG

[Lldb-commits] [PATCH] D84691: [CMake] Move find_package(ZLIB) to LLVMConfig

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Thanks, this is a great idea! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84691/new/ https://reviews.llvm.org/D84691 __

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

mehdi_amini added inline comments. Comment at: mlir/examples/standalone/CMakeLists.txt:35 +endif() + include(TableGen) mehdi_amini wrote: > I am a bit unsure that it is desirable that it is desirable to need this > change? > This requires every single user of L

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek marked 4 inline comments as done. phosek added inline comments. Comment at: mlir/examples/standalone/CMakeLists.txt:35 +endif() + include(TableGen) stephenneuendorffer wrote: > mehdi_amini wrote: > > mehdi_amini wrote: > > > I am a bit unsure that it is d

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

mehdi_amini added inline comments. Comment at: mlir/examples/standalone/CMakeLists.txt:35 +endif() + include(TableGen) I am a bit unsure that it is desirable that it is desirable to need this change? This requires every single user of LLVM to do this. Is there a

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

stephenneuendorffer added inline comments. Comment at: mlir/examples/standalone/CMakeLists.txt:35 +endif() + include(TableGen) mehdi_amini wrote: > mehdi_amini wrote: > > I am a bit unsure that it is desirable that it is desirable to need this > > change? > > T

[Lldb-commits] [PATCH] D84691: [CMake] Move find_package(ZLIB) to LLVMConfig

phosek created this revision. phosek added reviewers: smeenai, compnerd, mehdi_amini. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antia

[Lldb-commits] [PATCH] D84716: [lldb/ArchSpec] Always match simulator environment in IsEqualTo

friss created this revision. friss added a reviewer: aprantl. Herald added subscribers: dexonsmith, inglorion. Herald added a project: LLDB. Initially, Apple simulator binarie triples didn't use a `-simulator` environment and were just differentiated based on the architecture. For example, `x86_64

[Lldb-commits] [PATCH] D84716: [lldb/ArchSpec] Always match simulator environment in IsEqualTo

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Yes, this makes perfect sense. Thanks! Comment at: lldb/unittests/Utility/ArchSpecTest.cpp:329 ASSERT_FALSE(A.IsExactMatch(B)); // FIXME: See above, though the ex

[Lldb-commits] [lldb] 64d99cc - [CMake] Move find_package(ZLIB) to LLVMConfig

Author: Petr Hosek Date: 2020-07-27T17:13:55-07:00 New Revision: 64d99cc6abed78c00a2a7863b02ce54911a5264f URL: https://github.com/llvm/llvm-project/commit/64d99cc6abed78c00a2a7863b02ce54911a5264f DIFF: https://github.com/llvm/llvm-project/commit/64d99cc6abed78c00a2a7863b02ce54911a5264f.diff LO

[Lldb-commits] [PATCH] D84716: [lldb/ArchSpec] Always match simulator environment in IsEqualTo

friss marked an inline comment as done. friss added inline comments. Comment at: lldb/unittests/Utility/ArchSpecTest.cpp:329 ASSERT_FALSE(A.IsExactMatch(B)); // FIXME: See above, though the extra environment complicates things. ASSERT_FALSE(A.IsCompatibleMatch(B));

[Lldb-commits] [lldb] 8120eba - [lldb/ArchSpec] Always match simulator environment in IsEqualTo

Author: Fred Riss Date: 2020-07-27T17:33:37-07:00 New Revision: 8120eba5fce378083ef22651f2b7b6dcaa54a098 URL: https://github.com/llvm/llvm-project/commit/8120eba5fce378083ef22651f2b7b6dcaa54a098 DIFF: https://github.com/llvm/llvm-project/commit/8120eba5fce378083ef22651f2b7b6dcaa54a098.diff LOG

[Lldb-commits] [PATCH] D84716: [lldb/ArchSpec] Always match simulator environment in IsEqualTo

This revision was automatically updated to reflect the committed changes. Closed by commit rG8120eba5fce3: [lldb/ArchSpec] Always match simulator environment in IsEqualTo (authored by friss). Changed prior to commit: https://reviews.llvm.org/D84716?vs=281084&id=281088#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D84691: [CMake] Move find_package(ZLIB) to LLVMConfig

mehdi_amini added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84691/new/ https://reviews.llvm.org/D84691 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D84691: [CMake] Move find_package(ZLIB) to LLVMConfig

This revision was automatically updated to reflect the committed changes. Closed by commit rG64d99cc6abed: [CMake] Move find_package(ZLIB) to LLVMConfig (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84691/new/ https://reviews.l

[Lldb-commits] [PATCH] D84691: [CMake] Move find_package(ZLIB) to LLVMConfig

stephenneuendorffer added a comment. Perfect! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84691/new/ https://reviews.llvm.org/D84691 ___ lldb-commits mailing list lldb-commits@lists.llvm.org