[Lldb-commits] [PATCH] D83757: [lldb] Store StackFrameRecognizers in the target instead of a global list

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b7c9eae6dca: [lldb] Store StackFrameRecognizers in the target instead of a global list (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLV

[Lldb-commits] [lldb] 1b7c9ea - [lldb] Store StackFrameRecognizers in the target instead of a global list

Author: Raphael Isemann Date: 2020-07-17T09:26:27+02:00 New Revision: 1b7c9eae6dcad09c264e29e41a69bed0d34c2f5f URL: https://github.com/llvm/llvm-project/commit/1b7c9eae6dcad09c264e29e41a69bed0d34c2f5f DIFF: https://github.com/llvm/llvm-project/commit/1b7c9eae6dcad09c264e29e41a69bed0d34c2f5f.dif

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. This now looks good to me. I'll give the others a chance to take a look too but beside that I think this is ready to go IMHO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81001/new/ https://reviews.llvm.org/D81001 _

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing created this revision. Higuoxing added reviewers: jhenderson, grimar, MaskRay. Herald added subscribers: llvm-commits, lldb-commits, hiraditya, mgorny. Herald added projects: LLDB, LLVM. This patch refactors `emitDebugInfo()` to make the length field be inferred from its content. Besides

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing added a comment. I'll add some tests later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84008/new/ https://reviews.llvm.org/D84008 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] f3fab39 - [lldb/DWARF] Don't get confused by line sequences with tombstone values

Author: Pavel Labath Date: 2020-07-17T11:51:52+02:00 New Revision: f3fab392f57421a5bdabfb7e40820257d8f637b2 URL: https://github.com/llvm/llvm-project/commit/f3fab392f57421a5bdabfb7e40820257d8f637b2 DIFF: https://github.com/llvm/llvm-project/commit/f3fab392f57421a5bdabfb7e40820257d8f637b2.diff

[Lldb-commits] [PATCH] D83957: [lldb/DWARF] Don't get confused by line sequences with tombstone values

This revision was automatically updated to reflect the committed changes. labath marked 3 inline comments as done. Closed by commit rGf3fab392f574: [lldb/DWARF] Don't get confused by line sequences with tombstone values (authored by labath). Changed prior to commit: https://reviews.llvm.org/D83

[Lldb-commits] [PATCH] D83881: [lldb/COFF] Remove strtab zeroing hack

labath marked 2 inline comments as done. labath added a comment. Thanks for checking this out. Sorry for forgetting you Martin, I'll have to remember to add you to my future coff patches. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:672

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 278718. omjavaid added a comment. This revision updates SVE ptrace support to reflect changes we made in SVE core file support specially around handling of FPSR and FPCR. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79699/new/ https://reviews.llv

[Lldb-commits] [PATCH] D83881: [lldb/COFF] Remove strtab zeroing hack

This revision was automatically updated to reflect the committed changes. Closed by commit rGede7c02b38c0: [lldb/COFF] Remove strtab zeroing hack (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83881/new/ https://reviews.llvm.org

[Lldb-commits] [lldb] ede7c02 - [lldb/COFF] Remove strtab zeroing hack

Author: Pavel Labath Date: 2020-07-17T13:24:59+02:00 New Revision: ede7c02b38c0c3adf7fb9ee308bd0f6d92a0eb4e URL: https://github.com/llvm/llvm-project/commit/ede7c02b38c0c3adf7fb9ee308bd0f6d92a0eb4e DIFF: https://github.com/llvm/llvm-project/commit/ede7c02b38c0c3adf7fb9ee308bd0f6d92a0eb4e.diff

[Lldb-commits] [PATCH] D83975: Add an option to "break set" and "source list" that takes a line spec in the form file:line:column

labath added inline comments. Comment at: lldb/source/Interpreter/OptionValueFileColonLine.cpp:120-127 + // The setting value may have whitespace, double-quotes, or single-quotes + // around the file path to indicate that internal spaces are not word + // breaks.

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added a comment. The test looks wrong to me. If the feature is supposed to be off by default, then how can it test anything without first turning the feature on? Either the feature isn't really off, or the test is broken. I would expect it to be the latter, because the test sequence seem

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is as good as we can get right now. Thanks for sticking through. Two quick comments inline. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOS

[Lldb-commits] [PATCH] D83840: [lldb][test] Prevent infinite loop while looking for use_lldb_suite_root.py.

labath added a comment. In D83840#2156040 , @JDevlieghere wrote: > In D83840#2155308 , @labath wrote: > > > In D83840#2154263 , @shafik wrote: > > > > > @labath why do we ne

[Lldb-commits] [PATCH] D83904: [lldb] Unify sleep and time outs in GDB remote testcases

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds like a good idea. Comment at: lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py:63-64 # Wait until all threads have started. -thread

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. > The test looks wrong to me. If the feature is supposed to be off by default, > then how can it test anything without first turning the feature on? Either > the feature isn't

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

nickdesaulniers added a comment. Sounds like another approach was landed in https://reviews.llvm.org/D69403, and a follow up in https://reviews.llvm.org/D70277, and 9a3f892d018238dce5181e458905311db8e682f5 . Repository: rG

[Lldb-commits] [lldb] 0fbbf3a - [lldb] Unify sleep and time outs in GDB remote testcases

Author: Jonas Devlieghere Date: 2020-07-17T11:03:16-07:00 New Revision: 0fbbf3a98ca6fc75aafb6405943ee00e7c4d5594 URL: https://github.com/llvm/llvm-project/commit/0fbbf3a98ca6fc75aafb6405943ee00e7c4d5594 DIFF: https://github.com/llvm/llvm-project/commit/0fbbf3a98ca6fc75aafb6405943ee00e7c4d5594.d

[Lldb-commits] [PATCH] D83904: [lldb] Unify sleep and time outs in GDB remote testcases

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fbbf3a98ca6: [lldb] Unify sleep and time outs in GDB remote testcases (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D83904?vs=278297&id=278

[Lldb-commits] [PATCH] D84070: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84070 Files: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp lldb/test/Shell/ObjectFile/PECOFF/symbol.yaml In

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278894. aelitashen added a comment. Create help function in tests for code re-use. Take care of both macOS and Linux system. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D84070: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM. That was a nice catch on the other review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84070/new/ https://reviews.llvm.org/D84070

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 marked an inline comment as done. gedatsu217 added a comment. > help help frame should not have an autosuggestion to help frame. You can just > try to get the autosuggestion for help help frame and check for the error for > an invalid command. Sorry, I do not know what this means. No

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278898. aelitashen added a comment. Merge Codes and Improve Readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang-format/git-clang-f

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278900. aelitashen added a comment. Merge if statements in GetDebugInfoSizeInSection() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang-for

[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

michele.scandale added a comment. In D83454#2145086 , @michele.scandale wrote: > In D83454#2144386 , @JDevlieghere > wrote: > > > In D83454#2142719 , > > @michele.scandale

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. The logic looks very good, just some final comments and the code will be high quality Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:66

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278922. aelitashen added a comment. Add TODO comment for Linux, Use ostringstream for Debug Info Size message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files:

[Lldb-commits] [PATCH] D83975: Add an option to "break set" and "source list" that takes a line spec in the form file:line:column

jingham updated this revision to Diff 278928. jingham added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83975/new/ https://reviews.llvm.org/D83975 Files: lldb/include/lldb/Interpreter/OptionValue.h lldb/inc

[Lldb-commits] [PATCH] D83975: Add an option to "break set" and "source list" that takes a line spec in the form file:line:column

jingham marked 4 inline comments as done. jingham added inline comments. Comment at: lldb/source/Interpreter/OptionValueFileColonLine.cpp:120-127 + // The setting value may have whitespace, double-quotes, or single-quotes + // around the file path to indicate that inter

[Lldb-commits] [lldb] 53880b8 - [CMake] Make `intrinsics_gen` dependency unconditional.

Author: Michele Scandale Date: 2020-07-17T16:43:17-07:00 New Revision: 53880b8cb9c61e81457d13c0adefe51ff41664fa URL: https://github.com/llvm/llvm-project/commit/53880b8cb9c61e81457d13c0adefe51ff41664fa DIFF: https://github.com/llvm/llvm-project/commit/53880b8cb9c61e81457d13c0adefe51ff41664fa.di

[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

This revision was automatically updated to reflect the committed changes. Closed by commit rG53880b8cb9c6: [CMake] Make `intrinsics_gen` dependency unconditional. (authored by michele.scandale, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek reopened this revision. phosek added a comment. This revision is now accepted and ready to land. I had to revert this change because it broke bots that don't have zlib installed. What I haven't realized is that the shadowed variable will only be accessible from the same file. I could move

[Lldb-commits] [PATCH] D83857: Harmonize python shebang

This revision was automatically updated to reflect the committed changes. Closed by commit rG515bc8c1554f: Harmonize Python shebang (authored by serge-sans-paille). Herald added projects: clang, Sanitizers, LLDB, libc++, OpenMP, libc-project. Herald added subscribers: libc-commits, openmp-commits,

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 278216. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in lld/CMakeLists.txt

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

labath added a comment. I wouldn't mind separate (internal) cache variable, though I am somewhat surprised by this problem. A (non-cache) variable set in one of the parent scopes should still take precedence over a cache variable with the same name. And since config-ix.cmake is included from th

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2152747 , @labath wrote: > I wouldn't mind separate (internal) cache variable, though I am somewhat > surprised by this problem. A (non-cache) variable set in one of the parent > scopes should still take precedence over

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Oops, missed that I'd become a blocking reviewer for this (cos of requesting changes before). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D792

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c1a79dc12f3: [CMake] Simplify CMake handling for zlib (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

wallace accepted this revision. wallace added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:65 +@skipIfWindows +@ skipUnlessDarwin +@skipIfRemote remove this whitespace Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D84083: [lldb/ObjectFileMachO] Correctly account for resolver symbols

friss created this revision. friss added reviewers: jasonmolenda, jingham. Herald added a project: LLDB. The resolver addresses stored in the dyld trie are relative to the base of the __TEXT segment. This is usually 0 in a dylib, so this was never noticed, but it is not 0 for most dylibs integrate

[Lldb-commits] [PATCH] D84083: [lldb/ObjectFileMachO] Correctly account for resolver symbols

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84083/new/ https://reviews.llvm.org/D84083