[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

Higuoxing marked 3 inline comments as done. Higuoxing added a comment. Newly added tests are marked by inline comments since too many tests are updated 😂. Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml:685 + +## c) Test that yaml2obj emits correct DWARF sections

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

labath added a comment. In D83023#2128475 , @friss wrote: > In D83023#2128298 , @labath wrote: > > > I think this is a very interesting feature (lldb being able to load modules > > from memory; the mac shared cache

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

labath added a comment. What would you say if, instead of `AbbrevTableIndex`, we had a field like `AbbrevTableID`. The main difference would be that this "ID" field can be explicitly specified on the Abbrev table, and it does not have to be a sequentially increasing number (though it could of c

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

labath marked an inline comment as done. labath added a comment. Thanks. This looks is starting to look good now. I didn't get a chance to review all of the changes, but here's a few more things that I noticed. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

Higuoxing added a comment. In D83116#2130019 , @labath wrote: > What would you say if, instead of `AbbrevTableIndex`, we had a field like > `AbbrevTableID`. The main difference would be that this "ID" field can be > explicitly specified on the Abbrev tab

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

jhenderson added a comment. In D83116#2130019 , @labath wrote: > What would you say if, instead of `AbbrevTableIndex`, we had a field like > `AbbrevTableID`. The main difference would be that this "ID" field can be > explicitly specified on the Abbrev ta

[Lldb-commits] [lldb] 3faec83 - [lldb] Fix missing characters when autocompleting LLDB commands in REPL

Author: Martin Svensson Date: 2020-07-03T12:10:00+02:00 New Revision: 3faec833760fa7ab6e3180378da8c8fb4abbdb11 URL: https://github.com/llvm/llvm-project/commit/3faec833760fa7ab6e3180378da8c8fb4abbdb11 DIFF: https://github.com/llvm/llvm-project/commit/3faec833760fa7ab6e3180378da8c8fb4abbdb11.dif

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

Higuoxing marked an inline comment as done. Higuoxing added inline comments. Comment at: llvm/tools/obj2yaml/dwarf2yaml.cpp:19 #include +#include jhenderson wrote: > I'm slightly surprised you needed to add this. Did this not compile without > it? I guess i

[Lldb-commits] [PATCH] D82835: [lldb] Fix missing characters when autocompleting LLDB commands in REPL

This revision was automatically updated to reflect the committed changes. Closed by commit rG3faec833760f: [lldb] Fix missing characters when autocompleting LLDB commands in REPL (authored by poya, committed by teemperor). Changed prior to commit: https://reviews.llvm.org/D82835?vs=274322&id=27

[Lldb-commits] [lldb] 473fbc9 - [clang][NFC] Store a pointer to the ASTContext in ASTDumper and TextNodeDumper

Author: Bruno Ricci Date: 2020-07-03T13:59:22+01:00 New Revision: 473fbc90d1fbf17e16594dfb17248c4f50b4d399 URL: https://github.com/llvm/llvm-project/commit/473fbc90d1fbf17e16594dfb17248c4f50b4d399 DIFF: https://github.com/llvm/llvm-project/commit/473fbc90d1fbf17e16594dfb17248c4f50b4d399.diff L

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

labath added a comment. I like this. Comment at: lldb/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp:167 assert(target_arch.GetTriple().getOS() == llvm::Triple::FreeBSD); switch (target_arch.GetMachine()) { case llvm::Triple::aarch64: It would

[Lldb-commits] [PATCH] D82864: [lldb] Replace host-typed Scalar accessors with [SZ]ExtOrTruncInt

labath added a comment. Not relevant now that D82772 is in. It still may make sense to revisit this idea later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82864/new/ https://reviews.llvm.org/D82864 _

[Lldb-commits] [lldb] 228ea81 - [lldb/Utility] Simplify more Scalar methods

Author: Pavel Labath Date: 2020-07-03T16:35:14+02:00 New Revision: 228ea815832a863bfd4da0f0fd67675e0a02cb88 URL: https://github.com/llvm/llvm-project/commit/228ea815832a863bfd4da0f0fd67675e0a02cb88 DIFF: https://github.com/llvm/llvm-project/commit/228ea815832a863bfd4da0f0fd67675e0a02cb88.diff

[Lldb-commits] [lldb] b3b9528 - [lldb/DWARF] Look for complete member definitions in other modules

Author: Pavel Labath Date: 2020-07-03T16:50:49+02:00 New Revision: b3b952873f3705e6877644013461be7923c6caad URL: https://github.com/llvm/llvm-project/commit/b3b952873f3705e6877644013461be7923c6caad DIFF: https://github.com/llvm/llvm-project/commit/b3b952873f3705e6877644013461be7923c6caad.diff

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

labath added a comment. In D81697#2129407 , @bbli wrote: > > For example, the thing that's annoying me now is that whenever a test fails > > in the "make" phase (e.g. a compile error), we only get an error message > > with the return status, and the orig

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. > Ideally this error should include the actual command line So to clarify, you want to also print out the exact clang command/what flags were passed to clang whenever compile errors happen? > We have lots of areas that need improvement, so we can come up with > additional