[Lldb-commits] [lldb] 68a9356 - [lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol files

2020-05-09 Thread Jan Kratochvil via lldb-commits
Author: Jan Kratochvil Date: 2020-05-09T09:06:37+02:00 New Revision: 68a9356bdea69dbcec1233f8b1fab47e72fca991 URL: https://github.com/llvm/llvm-project/commit/68a9356bdea69dbcec1233f8b1fab47e72fca991 DIFF: https://github.com/llvm/llvm-project/commit/68a9356bdea69dbcec1233f8b1fab47e72fca991.diff

[Lldb-commits] [PATCH] D79649: [lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol files

2020-05-09 Thread Jan Kratochvil via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG68a9356bdea6: [lldb] [testsuite] TestReproducerAttach.py: Fix dependency on external symbol… (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D79649?vs=262941&id=262997#toc

[Lldb-commits] [PATCH] D79659: [lldb/Commands] Add ability to run shell command on the host.

2020-05-09 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 262999. mib added a comment. With the first implementation, I thought it'd be a good idea to have separate Command Objects for `platform shell` and `shell` because I was imagining the latter could be more "powerful": `shell` could have an interactive mode like

[Lldb-commits] [PATCH] D79659: [lldb/Commands] Add ability to run shell command on the host.

2020-05-09 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 263005. mib edited the summary of this revision. mib added a comment. It looks like command options are not supported on aliases that already have options: (lldb) shell -t 1 -- sleep 5 zsh:1: command not found: -t error: command returned with status 127 I

[Lldb-commits] [lldb] c9537b9 - [lldb/debugserver] Include TargetConditionals.h where needed

2020-05-09 Thread Fred Riss via lldb-commits
Author: Fred Riss Date: 2020-05-09T10:12:17-07:00 New Revision: c9537b9cc862b7ec1ba502043e42bc6ebd24dec0 URL: https://github.com/llvm/llvm-project/commit/c9537b9cc862b7ec1ba502043e42bc6ebd24dec0 DIFF: https://github.com/llvm/llvm-project/commit/c9537b9cc862b7ec1ba502043e42bc6ebd24dec0.diff LOG

[Lldb-commits] [PATCH] D79659: [lldb/Commands] Add ability to run shell command on the host.

2020-05-09 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:1625 +// When called from the `shell` alias with no argument, exit. +if (args.GetRawPart().empty()) Is this only true for the alias? Commen

[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

2020-05-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In D79614#2027869 , @jasonmolenda wrote: > In D79614#2027861 , @clayborg wrote: > > > Why not just fix qLaunchSuccess by passing the string through a > > "escape_string(...)" function? An

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-05-09 Thread Shoaib Meenai via Phabricator via lldb-commits
smeenai added inline comments. Comment at: lld/test/lit.site.cfg.py.in:16 config.target_triple = "@TARGET_TRIPLE@" -config.python_executable = "@Python3_EXECUTABLE@" -config.have_zlib = @HAVE_LIBZ@ +config.python_executable = "@PYTHON_EXECUTABLE@" +config.have_zlib = @LLVM_ENABL

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-05-09 Thread Petr Hosek via Phabricator via lldb-commits
phosek added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

2020-05-09 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. In D79614#2028295 , @clayborg wrote: > In D79614#2027869 , @jasonmolenda > wrote: > > > In D79614#2027861 , @clayborg > > wrote: > > > > > Why